Skip to content

Fix FabFilter VST3 ADD: preserve stereo/sidechain buses and show native failure reason in picker - #9

Closed
masarray wants to merge 4 commits into
feature/p2-native-state-presetsfrom
fix/p2-fabfilter-add-workflow
Closed

masarray wants to merge 4 commits into
feature/p2-native-state-presetsfrom
fix/p2-fabfilter-add-workflow

Conversation

@masarray

Copy link
Copy Markdown
Owner

Windows user report

FabFilter VST3 catalog successfully enumerates 240 plugins; every FabFilter ADD FX action appears to do nothing while ArSonKuPik previously works. Need exact failure diagnostics and compatibility improvement without breaking latest P2.4 presets/UI.

Confirmed source defects

  • Errors from engine_.addVst3 were displayed in a short toast behind an open blurred modal, leaving the user unaware why ADD failed.
  • The host unconditionally called setBusesLayout with exactly one stereo input and output; this can reject VST3 effects with optional sidechain/aux buses or valid existing layouts.

Implemented

  • Preserves already-supported stereo main input/output layouts without resetting them; otherwise attempts stereo main and disables optional auxiliary buses. One shared layout helper for ADD and native preset restore.
  • Each ADD request gets an ID, visible loading feedback, and a structured native success/failure result with elapsed milliseconds. Failures render inside the Add FX dialog, with actionable text and durable FX_LOAD_FAIL diagnostics. Success closes dialog and updates real FX chain.
  • New native UI contract regression tests and Windows packaging.

Validation

Windows MSVC Release + JS contract tests are required. Proprietary FabFilter modules are not present in CI, so a successful build cannot prove vendor-specific runtime behavior. User must retry and share the exact FX NOT LOADED text and audio diagnostics log if still failing. No UI redesign or audio callback changes. PR draft pending physical FabFilter test.

Copy link
Copy Markdown
Owner Author

Windows CI GREEN — FabFilter ADD FX diagnostic candidate

Commit: 7a43b89eb39560641c457b4e85f90d5ede2d83a3
Workflow: https://github.com/masarray/arsonmix/actions/runs/40159994766
Windows EXE: https://github.com/masarray/arsonmix/actions/runs/40159994766/artifacts/12586276483

Validated: JavaScript syntax, P2.3 UI regression and P2.4 preset tests, new FX add result contract test, MSVC x64 Release, CTest, executable packaging.

Source-level confirmed bugs fixed: failed Add FX error was hidden behind active modal; all plugin instances were forced into exactly one stereo input and output layout. New path preserves compatible default stereo layouts, attempts sidechain/aux bus disabling for stereo effects, and emits a correlated arMixAddResult visible inside the open selector. FX_LOAD_FAIL log contains plugin name, actual JUCE error and load elapsed time. Existing native preset recall uses same bus negotiation.

Caution: FabFilter proprietary binaries are unavailable to CI; compatibility on user's PC is unverified. Trial FabFilter Pro-C 2 and Pro-Q, confirm insertion + editor + bypass. If still failing, attach screenshot of FX NOT LOADED message and SIGNAL CHECK -> OPEN DIAGNOSTIC LOG. Keep PR draft until hardware confirmation.

Copy link
Copy Markdown
Owner Author

Backlog reconciliation — 2026-11-01. Closing as SUPERSEDED/ARCHIVED, not merged. This early P1/P2 branch is a historical stacked baseline (2026-10-24/25) that targets obsolete parent branches and overlapping native/GUI files. Its useful product requirements are now covered by the merged live 10CH/VST code plus PRD/ARD v5 and active M-U1 #266 / GUI #265. It is NOT certified as safely cherry-pickable on current main.

Canonical workflow: PRD v5, ARD v5, dynamic engine issue #192. Any unique test, VST compatibility or safety insight should be deliberately ported to #266, #265, #180 or #15 against current main with fresh proof—never merge this historical stacked head blindly. Original commits remain accessible; branch is not deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant