Repository navigation
fix(harmony): reconcile approved M14 into current main without losing dropout/bypass reliability - #509
fix(harmony): reconcile approved M14 into current main without losing dropout/bypass reliability#509masarray wants to merge 3 commits into
Conversation
…dropout reset with merged main
…ger through guide loss and fresh retarget
Deploying arsonmix with
|
| Latest commit: |
618cb67
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://76b3c08f.arsonmix.pages.dev |
| Branch Preview URL: | https://experiment-harmonice-p1-late.arsonmix.pages.dev |
|
/arsonmix-ci fat 618cb67 |
Exact source Windows qualification underway (same SHA; no code changes)Previous #506 Targeted current-main #509 exact SHA |
|
Cross-thread forward-port note: PR #512 selectively contains this PR's 3-file Harmony correction and PCM tests on latest main, plus previously missing ASIO recovery. Its exact combined source SHA is |
|
Superseded and integrated into current |
Critical cross-thread reconciliation — DRAFT, DO NOT AUTO-MERGE
This is the minimal forward-port of Harmony fixes missing from current
maininto a fresh branch based on merge commit6bcf88af30629d2e20026bfa8e0a84163c06c29e. It deliberately excludes the old QA branch history and isolates 3 files only. No changes to Player, WIRE, ASIO4ALL device recovery, Compressor, Vocal Throw,.smix, installer, or web UI.Why this PR exists
On 2026-11-10
mainadvanced by merge commit6bcf88afwhich merged #487 and #499, while the previously safe drafts #503/#506 remained separate.mainalready contains Music key scoring/hold policy, the 9-way WET/Space matrix and warm bypass; do not cherry-pick entire old QA branches or revert mixed M14 changes. Two specific fixes were missing frommain:ChannelHarmonyProcessor::prepareToPlay()previously never reported the rate to JUCE metadata, soFxInstancecaptured 0 and used 64 frames instead of 384 at 48k or 768 at 96k. Set metadata once OFF realtime before the lease is constructed.Real PCM regressions (not browser-only)
harmony_music_bank_test.cpp: live singer at 220Hz during guide dropout, exact untouched source PCM, first resumed A-minor block must not republish stale C-major; after acquiring fresh evidence it must report A minor.harmony_bypass_reliability_test.cpp: assert native JUCE processor rate and actual lease bypassFade 8ms across nine WET/Space combinations, 48/96 kHz and 64/128/256 periods, in addition to existing continuous wet/off/on exact PDC tests.Guardrails for parallel threads / release
main. Re-evaluate currentmainbefore any merge and run exact-SHA Windows MSVC full CTest + FAT/Inno. Fast CI alone is insufficient.main.Single cross-thread checkpoint
Canonical reconciliation and owner review gates: P0 integration contract #510. All workstreams must read it before carrying forward Harmony/PCM into release or modifying these files. This is advisory; enable branch rules for enforceable protection.