Repository navigation
DRAFT Harmonice P1 CPU — sample-exact PSOLA epoch scan and same-runner tail profiling - #515
Closed
masarray wants to merge 5 commits into
Conversation
…ompile-time legacy A/B
…e-runner CPU evidence
…e-runner CPU evidence
Owner
Author
Decision — REJECT candidate (2026-11-10), keep original production scanExact head
Optimized candidate was slower at all measured p50/p95, and mixed at p99.9. A synthetic same-runner microbenchmark does not justify adding complexity or altering the production pitch-synchronous implementation. Close without merge. Keep #514 P1 latency study isolated and retain #509 P0 reliability evidence. Do not assume Windows ASIO/no-XRUN qualification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1 CPU milestone, isolated from active routing/ASIO
Stacked on #514 (offline latency) → #509 (Windows 80/80 P0 Harmony fixes) → main. Keep draft, do not merge or change default DSP latency until acoustic and full native gates.
Exact-output optimization
Current
PitchSynchronousVoice::findPositiveEpoch()rescans a bounded source window for every scheduled voice grain, using repeated 64-bittime-tand ring-index arithmetic. Adjacent time positions map to adjacent ring slots. After computing the FIRST ring index, advance one ring slot per candidate; preserve every input sample, comparison order, strict greater-than tie rule, absolute source epoch, threshold and scheduling. No different source samples, no resampling interpolation, no tonal/phase policy change.A compile-time
FastEpochWalk=falseinstantiates the historical reference exclusively for offline A/B. The production template defaults to the cursor path with no runtime mode, mutex, IO, heap allocation, SPSC transaction, driver change or extra FX owner.Safety and evidence
Release/parallel-thread guardrails
PR #512 modifies native Harmony preparation and FX bypass tests; this PR modifies NONE of those.
ChannelHarmonyProcessor, audio callback authority, DeviceSession/WIRE/Player/Compressor/Vocal Throw/editor/.smix untouched. Vocal Throw sound is still a separate blocked workstream. Physical singer/no-XRUN/audio quality remain unverified.No automatic merge or production release.