Skip to content

P0 INTEGRATION CONTRACT — prevent cross-thread Harmony/PCM regressions after M14 merge #510

Closed as not planned

Description

@masarray

ArSonMix P0 cross-thread integration contract — checkpoint 2026-11-10

Purpose: prevent independent development threads from overwriting Harmony/PCM reliability when integrating Vocal Throw, Player, Compressor, WIRE, ASIO device recovery, updater, .smix/session, and release workflow. This issue is a coordination record, not a branch-protection rule and not a hardware certificate.

Verified live repo state

Current forward integration owner

PR #509 based on merge SHA 6bcf88af, current head 618cb67c476ffe41904175cc87890f075c9c3b21, DRAFT/NO AUTO-MERGE, only:

  1. engine/builtin_fx/ChannelHarmonyProcessor.h: restore correct 8ms FxInstance bypass rate metadata during control-side JUCE prepare, plus one-shot reset of stale Music guide detector on >2-second missing-source timeout.
  2. tests/harmony_bypass_reliability_test.cpp: actual native FxInstance fade length at 48/96 kHz and 64/128/256 host partitions; maintains 9-way wet/space warm bypass PCM test.
  3. tests/harmony_music_bank_test.cpp: live 220Hz singer remains active during missing guide, no stale C-major flash upon reconnection, fresh A-minor acquisition and unchanged source PCM.

Do not copy complete files from #503/#506 into new main: main already contains other Music detector and bypass fixes. #509 is a focused, reviewed forward-port retaining latest main behavior.

Required merge/release gates

Thread handoff rule

Anyone touching ChannelHarmonyProcessor.h, HarmonyMusicKey.h, FxBypassEnvelope.h, LiveChannelFxGraph.h or native PCM routing must: (a) check newest main and PR #509, (b) explicitly show before/after output-latency and DSP PCM tests, (c) preserve warm bypass even when rack/slot OFF, (d) avoid duplicate graph/audio callback or GUI rebind gate, and (e) reference this issue in their PR.

No GitHub hard branch lock was configured by creating this issue. Owners should enable required checks/reviews for main and use staged integration where appropriate.

Activity

  1. masarray commented on Nov 10, 2026

    @masarray
    OwnerAuthor

    Supplemental risk found: M15 Vocal Throw PR #507

    Open draft #507 head aca0441d is 7 ahead / 12 behind current main at 6bcf88af; its PR base metadata still points to old 9bd81a1b. The PR changed-files presentation includes many older Harmony files, while direct current-main SHA comparison shows 9 true M15 delta files. Critically the M15 branch snapshot includes old HarmonyMusicKey.h missing acceptMusicKeyCandidate, whereas current main contains it. Three-way reconciliation is required, never blind whole-file copy of M15 Harmony/PCM files. A safety/reconcile comment was added to #507. #509 remains the only current-main-focused missing Harmony fix branch, draft, and no CI-only mirrors are merge candidates.

  2. masarray commented on Nov 10, 2026

    @masarray
    OwnerAuthor

    Hardware owner report / Harmony continuation (2026-11-10)

    Owner says Vocal Throw audio quality is still unacceptable. Treat M15 #507 as HOLD / DO NOT MERGE OR RELEASE, separately from Harmony. This reported quality failure is not license to alter native mixer PCM graph, WIRE, ASIO direct-device recovery, Harmony DSP or .smix persistence. Added explicit owner-field blocker to #507.

    Current-main surgical Harmony #509 remains only 3 files / source 618cb67c476ffe41904175cc87890f075c9c3b21. The previous combined QA #506 80/80 Windows CTest PASS, FAT/Inno artifacts verified by workflow, but not a test of #509 source. A single exact-SHA Windows MSVC/CTest + FAT/Inno #42735079669 has been launched; preflight SUCCESS, native Windows job running. Physical ASIO/singer and true no-crackle performance still not certified. Never confuse code-contract tests with release acceptance.

  3. masarray commented on Nov 10, 2026

    @masarray
    OwnerAuthor

    2026-11-10 P0 shared integration checkpoint — forward-port branch in progress

    Canonical integration candidate: PR #512 fix/p0-reconcile-native-asio-harmony-20261110 at exact head 378ffbc2aba4b3de421f723270951365c563b981, based on main@6bcf88af30629d2e20026bfa8e0a84163c06c29e.

    Do not merge or overwrite it with original old-base #503/#506/#507 or #511 wholesale.

    Integration work is real code in draft PR #512; this note is an anti-regression checkpoint, not merge approval.

  4. masarray commented on Nov 10, 2026

    @masarray
    OwnerAuthor

    2026-11-10 Harmonice P1 thread checkpoint (safe independent branch, DO NOT AUTO-MERGE)

    Next legitimate stage: genuine vocal WAV A/B via tools/harmony_offline_ab --latency-study, human auditory evaluation, Windows exact-head CI when gated candidate is approved, hardware ASIO test.

  5. masarray commented on Nov 10, 2026

    @masarray
    OwnerAuthor

    2026-11-10 Harmonice Milestone D/E integration checkpoint (same-main, exact patch audit)

    Live main remains 6bcf88af30629d2e20026bfa8e0a84163c06c29e at inspection. I compared every line of the three #509 changed-file patches with PR #512. All three patches are byte-identical, including ChannelHarmonyProcessor.h, bypass PCM and Music ChannelId PCM regression. Hence if #512 merges first, #509's P0 forward-port is already represented and must NOT be separately duplicated; rebase only the independent P1 study on the then-current main and rerun relevant exact-SHA tests. No changes made to #512 or shared mixer/device/GUI files.

    The independent P1 study #514 head ffe429ff992314ffbf1674469b783f487b19b00f retains 32ms live; source-aligned offline 24/16ms, four-case synthetic WAV/JSON corpus, and native PSOLA causal low-note gate. Physics and 44.1/48/96k real PCM show 16ms cannot produce PSOLA-ready samples at 65Hz (needs 18.46ms minimum), so REJECT 16ms as full-range candidate; 24ms only research until human singer A/B. Fast Linux Harmony CI #42756943860 PASS.

    The DO-NOT-MERGE QA mirror #516 is exact same ffe429ff head, based on main to request owner-authorized one-time full Windows #42757047991. Check final conclusion and all CTest results; no Windows PASS is claimed until verified. Remain drafts; no Vocal Throw, no ASIO hardware/audio quality certification.

  6. masarray commented on Nov 10, 2026

    @masarray
    OwnerAuthor

    Harmonice visible-brand contract — PR #517 (2026-11-10)

    User requests Harmonice in built-in FX Picker and native GUI header instead of ArSon Harmony. Public name search found no exact VST/VST3 product collision in checked sources; this is not trademark clearance. Alternative Harmonis only if a real competing plugin is found.

    Scoped PR #517 exact head 1d62d62a5cca6d7b9aea15429a58673cd6b24847 based on current main@6bcf88af. Changes only UI/canonical display label, not engine DSP or device/routing. FX Picker, native JUCE getName, installed lease name, bridge catalog/fallback, GUI top title and engraved HARMONICE label are consistent. NativeMixerSessionFxRestore canonicalizes only the built-in Harmony instance's display name on old .smix restore to eliminate persistent 'ArSon Harmony' user-facing text, without rewriting the session or affecting VST3/preset/binary state. Source ID remains armix.builtin.arson-harmony.v1 so no session and editor control bridge ABI break. Browser preview opener accepts both old/new names.

    Current exact-head UI quick run 42760956302 and Windows preflight 42760956304 PASS. One actual Windows CTest was explicitly dispatched at exact head 42761094407; full Chromium branding/editor test dispatched on earlier UI-identical head 42760463223. At checkpoint both expensive runs in progress: don't claim PASS prematurely.

    Coordination: PR #512 and other mixer work modifies native Harmony, LiveAudioEngine, and session paths. On integration preserve #517's isolated display label + restore rule and #512's authoritative ASIO/mixer fixes, without renaming stable catalog ID or merging this draft automatically while full native checks pending. No physical ASIO claims.

  7. masarray commented on Nov 10, 2026

    @masarray
    OwnerAuthor

    2026-11-10 Harmonice integration checkpoint — source-authoritative results

    No unapproved ASIO/WIRE code modifications, Vocal Throw integration or public VST3-standalone artifact claim. Do not claim physical hardware qualification from synthetic CI.

  8. masarray commented on Nov 10, 2026

    @masarray
    OwnerAuthor

    Harmonice reconciled main checkpoint — 10 November 2026

    Verified final canonical main HEAD: 70cd7604d808c6152803bc377839ff6c8353e393. Three completed merges: #517 native catalog/picker/editor Harmonice display and backward-compatible .smix restoration (stable armix.builtin.arson-harmony.v1 ID), #519 cold-start Chromium fixture updated to current accepted Audio connection lost UI (exact-head full browser FAT SUCCESS), and #518 correct 8ms JUCE rate-prepared bypass + stale 2s Music-guide reset (exact-head Windows CTest 80/80 SUCCESS, Linux native DSP PASS). All are merged with GitHub acknowledgment, not merely draft.

    No loss and no duplicate integration: old #509 closed unmerged after byte-for-byte compare of 3 files against new main (ChannelHarmonyProcessor difference only approved name Harmonice). Old P1 #514/#516/#520 all closed unmerged and superseded by #521 current-main 9-file experimental draft at 8550ca7b613a90f4110660f7deeadc427b0dfa79; its fast Linux DSP 42783711206, native 42783711039, UI 42783711077 all PASS. No 24/16ms live latency change; 16ms disqualified for 65 Hz causal PSOLA; user singing & physical ASIO unverified.

    Still open outside this finished Harmony P0 scope: #512 ASIO/device/mixer architecture draft. Must reconcile separately against canonical main, exclude already merged Harmony hunks, and qualify hardware, not merge as-is. New main post-merge Windows 42783209892 was in progress when checked; do not claim post-merge job PASS until completed. This checkpoint preserves validated statuses, future integration rules, and target SHAs so other workstreams can proceed without regressions.

  9. masarray commented on Nov 10, 2026

    @masarray
    OwnerAuthor

    Administrative closure (2026-11-10)

    This issue is superseded as a coordination ledger, not "hardware completed." The historical draft references (#509/#503/#506 and QA mirrors) are retired; branded current-main repairs reached main via merged #517/#518. Its still-operative guards have been copied into the documentation in merged PR #524 and onto the concrete ownership issues #490/#412/#192.

    Keep one authoritative JUCE PCM callback, off-thread prepared graphs, real sample-rate 8ms Harmonice warm bypass, 2s stale Music-guide recovery, unchanged immutable catalog ID, native intent/ACK/snapshot, exact-SHA Windows tests and separate physical singer/ASIO FAT. DO NOT use closing this coordination issue to waive any of those gates. #450 stays open as the release controller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions