Skip to content

P0: stop fake native first paint + verified same-driver ASIO recovery (alpha.8 regression) - #511

Closed
masarray wants to merge 5 commits into
mainfrom
fix/p0-native-session-boot-generic-asio-20261110
Closed

masarray wants to merge 5 commits into
mainfrom
fix/p0-native-session-boot-generic-asio-20261110

Conversation

@masarray

Copy link
Copy Markdown
Owner

Release blocker after real owner Windows alpha.8 installation

The published v0.5.0-alpha.8 has NOT passed real-world product usability: owner reports a fake/reference console and ASIO/pipeline startup failure. Green CI alone is not accepted as proof. Do not promote a new release or merge this unqualified fix. See #490 and #412.

Root cause proven in shipped source

  1. site/preview-v2 initializes an interactive Pages reference model before the native bridge is ready. arMixGuiReady meant visual DOM only, while engine startup and native graph are deferred until a valid device is open; a failed/closed ASIO device leaves the reference mixer visible.
  2. Reattach & automatic restart require ASIO4ALL in LiveAudioEngine and Main even when the existing full registration/CLSID identity fence verified the same different ASIO driver.
  3. No-device logical session editing remains unimplemented; P0 first-launch: genuine SOURCE NONE ChannelId mixer, zero-capture output-only FX workspace #491 (SOURCE NONE with verified playback) is already in main but is NOT full [P0] First-launch real editable mixer + device-independent FX/WIRE/session (remove fake startup gate) #490.

Code at exact SHA 088f3cb609c2aa2a05d52f606e3f09703326a4a0

  • Native build-only reversible boot guard keeps the demo channels/wires hidden until a real installed native graph readback. Public /preview/ stays byte-identical. No fake meters, no forced demo model mutation. Retained accepted ChannelId session may be displayed as retained/unbound, not audible.
  • Native GUI handshake now requires actual injected bridge and narrow native scope; src/Main.cpp validates the bridge flag before counting GUI ready.
  • Same registered ASIO vendor may recover its retained mixer after a restart. The pinned CLSID, matching device identity and verified output pins remain required; ASIO4ALL-specific unique physical speaker adoption remains ASIO4ALL only.
  • Updated cold Chromium boot, bundle roundtrip/guard and native ASIO policy tests.

Qualification / remaining P0 blocker

This is a fail-closed first fix, NOT offline logical model/editor. Still to implement: editor-backed authoritative MixerSessionDocument with zero devices, explicit logical edit ACK separated from PCM admit ACK, deferred device binding, genuine output-only Player → FX → MAIN, no blocking vendor calls, and real ASIO hardware FAT. Do not equate hidden fake GUI with complete usability. Exact-SHA fast checks first, then a single bounded Windows FAT run (avoid parallel redundant dispatches). Existing alpha.8 public tag remains untouched.

…SIO mixer

Only reveal the shipped mixer after callback-backed native ChannelId/M4 readback; preserve public /preview/ byte-for-byte. Reject fake GUI-ready handshakes. Generalize pinned same-ASIO rebind beyond ASIO4ALL with verified hardware output policy and tests. Preserve safe mute/identity checks, existing VST3/WIRE graph and logical session. No new release until Windows and real hardware qualification.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6d92bbc
Status: ✅  Deploy successful!
Preview URL: https://01ea7d09.arsonmix.pages.dev
Branch Preview URL: https://fix-p0-native-session-boot-g.arsonmix.pages.dev

View logs

…iver restart

A callback epoch transition must never strand an unedited native mixer in the Pages-only reference state. Only the same registered ASIO driver, identical output masks/labels and rate can rebuild the silent unpatched ChannelId publisher; authored FX/WIRE use the existing retained transaction. No guessed MAIN device, no auto-arm and no callback allocations.

Copy link
Copy Markdown
Owner Author

Forensic reconciliation — preserve Work #491; do NOT reimplement the recovered mixer

Verified 10 Nov 2026 against exact Work #491 head 3015960b92c0c7547049a11ef6f0fe5ecec9e487, public alpha.8 source ffdf279a60009cbcdde19c197506151adbc87946, and main 6bcf88af30629d2e20026bfa8e0a84163c06c29e.

Proof of ancestry: Work #491 is a direct ancestor of the published alpha.8 candidate (GitHub compare 3015960...ffdf279...: ahead 125, behind 0), and therefore also of main. SOURCE NONE, 0-capture native PCM, .smix recovery, ASIO4ALL named-pin verification and PlayerDeck work were NOT dropped wholesale by the release integration.

Exact proven GUI regression: commit 0b0e637b7da0d404ec578504259fbde68d0a4acf, 2026-11-09 22:34 UTC, removed Work #491's reversible native-only <style id="native-mixer-startup"> rule:
html:not([data-armix-native-roster]) :is(.console-pane,#trackCount){visibility:hidden}
from scripts/build_approved_native_gui.py::NATIVE_EVENT_HOOKS and added tests asserting it must NOT exist. This intentionally changed first paint to a visible Pages reference mixer before native readback. The release used a descendant of that commit via #503/#505; owner installed alpha.8 and observed exactly this regression. This deletion was missed by the release reconciliation, even though all Work #491 commits were ancestors.

ASIO comparison: source slices are byte-identical at Work #491 HEAD versus published alpha.8 for:

  • Main.cpp::serviceAsioMixerRestart and finishAudioSetupAndRecoverMixer
  • LiveAudioEngine.h::sameRetainedAsioDriver, selectedRetainedAsioDriverForReopen, authorizeRetainedAsioRestart, reattachRetainedAsioMixer
  • NativeMixerSessionDocument.h::proposedOutputs, apply
  • approved-native-bridge.js native unadmitted/readback block.
    There is currently no evidence that these Work ASIO paths were removed; the physical device failure is still unverified and must be reproduced with callback/readback diagnostics. Do NOT rewrite the Work recovery from scratch.

Important scope qualifier: PR #491 itself documented full mixer editing with NO playback device, physical ASIO4ALL/Realtek listening, and non-returning vendor calls as remaining blockers. SOURCE NONE with verified playback was implemented; a truly device-independent editable mixer was not claimed complete in that PR.

Draft #511 status: previous assistant started an additive boot-guard/generic ASIO fix on main, latest 6d92bbcc77e595b55ad77dbb3049fc311d0c683a, fast checks passed, but it has NOT been merged, Windows native/MSVC/physical FAT was NOT run. This branch should be reconciled against Work #491 rather than accepted blindly; in particular, generic-ASIO expansion needs separate hardware/identity proof. Retain one SSOT ChannelId PCM renderer, no duplicate graph/JS DSP, never auto-arm an unverified physical pair.

Next precise work: (1) restore Work native-ready/readback first-paint semantics without blackout or hiding Audio I/O when driver unavailable; (2) remove stale native-mixer-startup contradiction in test while protecting accessible recovery UI; (3) inspect exact startup order and error/retry state on real Windows (GUI Ready -> engine.start -> device open -> native snapshot -> .smix restore -> MAIN); (4) verify ASIO feedback with precise physical driver/masks and artifact provenance; (5) implement genuinely device-independent logical editor only if still required, as a separate architecture milestone. Test initial no-device, verified 0-IN/2-OUT, ASIO restart, input loss, Player-only, device retarget, .smix persisted. Only then release a qualified installer; do not trigger duplicate costly CI or silently resurrect NEEDS REMAP as operator workflow.

Copy link
Copy Markdown
Owner Author

P0 cross-thread reconciliation audit — 2026-11-10 (hold merge)

Verified against main@6bcf88af30629d2e20026bfa8e0a84163c06c29e, Work 3015960b92c0c7547049a11ef6f0fe5ecec9e487, release ffdf279a60009cbcdde19c197506151adbc87946, this draft 6d92bbcc77e595b55ad77dbb3049fc311d0c683a. Re-check live refs before acting.

Code provenance: Work is an ancestor of both alpha.8/main (125 later commits); release and current main compare with zero file differences. Work blob identity is preserved on main for src/NativeMixerSessionDocument.h, engine/core/DynamicChannelRoster.h, integration/ApprovedNativeRuntimeSnapshot.h, web/approved-native-contract.js. Native engine/publisher/bridge files evolved with integrated features, not evidence of a wholesale loss of Work. Commit 0b0e637 removed the earlier CSS startup guard.

Actual architecture blocker, not solved by hiding the reference DOM: LiveAudioEngine::startUnpatchedProductionSession() currently requires a device and approved DIRECT fence; approved-native-contract.js requires physical outputs for admitted PCM and permits zero supported operations on a retained NEEDS_REMAP graph. approved-native-bridge.js consequently does not offer general track/FX/WIRE editing without a callback. This PR's CSS armix-native-boot-guard hides #tracks/#master/#wireLayer until accepted graph, so it is a fail-closed visual mitigation, not acceptance of owner-required device-independent editable logical mixer. Keep physical speaker admission strict; do not fabricate PCM.

Safe recovery direction: retain existing MixerSessionDocument, ChannelIds, FX leases and native publisher; add explicit logical authority/revision and native logical-edit ACK/readback separate from PCM/output admission. Load/create durable logical workspace before trying to open ASIO, allow CREATE/DELETE/RENAME/FX/WIRE/BUS/.smix with zero inputs or outputs, then attach compiled PCM to verified physical hardware transactionally without replacing session. No second callback, M4 routing authority, auto-remap wizard or fake demo metering. Retain same registered driver identity + pin fences for this PR's generic ASIO reopen; preserve ASIO4ALL unique physical pair handling.

Do not merge stale sibling integration branches wholesale: main already has Harmony, Compressor, Vocal Throw, Player, custom caption, updater. Harmony #509 contains an isolated 3-file forward-port (8ms device-rate bypass + stale Music-guide reset) and is safer than copying #503/#506/#504/#508 histories. Vocal Throw M15 #507 has a broad old-base 99-file diff; forward-port only intentionally reviewed FX-specific deltas, never bulk-merge it over the current pipeline.

CI truth: PR #511 current ui-smoke / p1-windows fast gates passed, while full Chromium and Windows MSVC/CTest jobs were skipped. This is not installer/hardware qualification.

Required next vertical slice before merge: native no-device cold start -> genuinely editable logical ChannelId session -> Save/Reopen .smix -> zero-input safe Player/FX/WIRE -> reconnect same ASIO verified outputs without state loss; inspect ACK/readback versus actual hardware PCM separately. Add offline no-device UI/native tests and exact-SHA Windows full build/CTest once, then physical ASIO test; do not publish new alpha until proven. Release alpha.8 remains a failed user acceptance, despite provenance.

Copy link
Copy Markdown
Owner Author

Cross-thread forward-port note: PR #512 now selectively contains the same-driver ASIO recovery and pristine SOURCE NONE reattach from this draft, based on latest main, with an authenticated native GUI handshake. It deliberately excludes this draft's CSS boot hide overlay because it blocks device-independent mixer editability. Please do NOT merge #511 as a separate overlapping whole-branch integration while #512 is qualified. #512 is itself draft; true no-device editable logical session + physical ASIO acceptance remain open.

masarray added a commit that referenced this pull request Nov 10, 2026
Forward-port production deltas from #512/#511, #500, and #498 without reverting the newer logical mixer or branded Harmonice. Fence generic ASIO recovery by registered driver and original pins, preserve saved capture patches, keep the native GUI readiness handshake independent of hardware, and verify unique USB-file relinks and sanitized native footer status.

Copy link
Copy Markdown
Owner Author

Repository housekeeping (2026-11-10): Closing as superseded, not merged. Generic same-driver ASIO recovery and native bridge-handshake changes were selectively carried into active reconciliation PR #512. The earlier CSS trick of hiding the entire mixer was intentionally not forwarded because the owner requires an actually editable first-launch workspace. Device-independent logical editing is independently implemented/qualified in active #513; product acceptance remains #490/#412. Archive this earlier partial fix rather than merge two competing startup implementations.

This preserves the historical branch/PR for audit, does not certify audio hardware, and does not authorize a release.

@masarray masarray closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant