Repository navigation
P0 Harmonice — forward-port JUCE 8ms bypass and Music-guide reacquisition onto branded main - #518
Merged
Merged
Conversation
Owner
Author
|
/arsonmix-ci native 32f87a7 |
This was referenced Nov 10, 2026
Closed
masarray
marked this pull request as ready for review
November 10, 2026 08:30
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR
Preserve the already Windows-tested P0 Harmony reliability fixes after Harmonice branding #517 was merged to main at
dc3540af8aafc3a113c37ef7c5a6f2593a1769fd. The original #509 became non-mergeable because its historicalgetName() = ArSon Harmonyoverlaps the published Harmonice name.Exactly 3 files, no audio graph/ASIO code outside Harmony:
ChannelHarmonyProcessor.h: publish JUCE sample rate/maximum block metadata before the nativeFxInstancebypass envelope measures its 8 ms fading; age-out one-shot reset of stale MusicKey detector after 2 s missing guide and respect first fresh source sample.tests/harmony_bypass_reliability_test.cpp: verify 8ms real sample-rate envelope across rates/mix.tests/harmony_music_bank_test.cpp: verify singer remains live while guide is missing; first restored music block cannot publish stale key, and new A-minor key reacquires.getName() = Harmonice, keep immutable IDarmix.builtin.arson-harmony.v1, no schema/session migration or unapproved latency change.PR #512 independently contains byte-identical P0 reliability hunks and separate ASIO/device repairs. Rebase #512 after this PR merges to avoid duplicate patches; do not overwrite audio owner fixes or merge #512 prematurely. This is a scoped reconciled new-main PR, not a new parallel effect engine.
Gate
Previous #509 exact-source full Windows MSVC/CTest 42735079669 passed 80/80 and #517 42761094407 passed 80/80 separately. This new combined SHA requires its own qualification before merge; neither prior result can be silently treated as integrated proof. No real-singer acoustic or physical ASIO FAT claim.