Skip to content

P0 Harmonice — forward-port JUCE 8ms bypass and Music-guide reacquisition onto branded main - #518

Merged
masarray merged 3 commits into
mainfrom
fix/harmonice-p0-after-brand-20261110
Nov 10, 2026
Merged

masarray merged 3 commits into
mainfrom
fix/harmonice-p0-after-brand-20261110

Conversation

@masarray

Copy link
Copy Markdown
Owner

Why this PR

Preserve the already Windows-tested P0 Harmony reliability fixes after Harmonice branding #517 was merged to main at dc3540af8aafc3a113c37ef7c5a6f2593a1769fd. The original #509 became non-mergeable because its historical getName() = ArSon Harmony overlaps the published Harmonice name.

Exactly 3 files, no audio graph/ASIO code outside Harmony:

  • ChannelHarmonyProcessor.h: publish JUCE sample rate/maximum block metadata before the native FxInstance bypass envelope measures its 8 ms fading; age-out one-shot reset of stale MusicKey detector after 2 s missing guide and respect first fresh source sample.
  • tests/harmony_bypass_reliability_test.cpp: verify 8ms real sample-rate envelope across rates/mix.
  • tests/harmony_music_bank_test.cpp: verify singer remains live while guide is missing; first restored music block cannot publish stale key, and new A-minor key reacquires.
  • Keep getName() = Harmonice, keep immutable ID armix.builtin.arson-harmony.v1, no schema/session migration or unapproved latency change.

PR #512 independently contains byte-identical P0 reliability hunks and separate ASIO/device repairs. Rebase #512 after this PR merges to avoid duplicate patches; do not overwrite audio owner fixes or merge #512 prematurely. This is a scoped reconciled new-main PR, not a new parallel effect engine.

Gate

Previous #509 exact-source full Windows MSVC/CTest 42735079669 passed 80/80 and #517 42761094407 passed 80/80 separately. This new combined SHA requires its own qualification before merge; neither prior result can be silently treated as integrated proof. No real-singer acoustic or physical ASIO FAT claim.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 32f87a7

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 32f87a7
Status:⚡️  Build in progress...

View logs

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T08:31:56.101204Z 32f87a7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant