Skip to content

P2.4 Native My Sounds: portable .armix ZIP, full VST3 state and transactional offline recall - #8

Closed
masarray wants to merge 8 commits into
fix/p2-truthful-meter-pan-fx-togglefrom
feature/p2-native-state-presets
Closed

masarray wants to merge 8 commits into
fix/p2-truthful-meter-pan-fx-togglefrom
feature/p2-native-state-presets

Conversation

@masarray

Copy link
Copy Markdown
Owner

ARD phase P2: Durable state storage

Prior prototype stored only browser-side plugin names/knob previews. This milestone implements actual plugin vendor state persistence for Channel 1 with a native ZIP format, while preserving current working JUCE/ASIO/WASAPI engine and verified P2.3 UI.

Implemented

  • MY SOUNDS in native mixer footer and Live FX Rack, native save/list/recall event bridge.
  • .armix ZIP with manifest.json, ordered state/00.bin etc, vendor getStateInformation/setStateInformation, per-plugin SHA256 and strict size/count/path validation.
  • Saves real CH1 fader, pan, mute, master gain/mute, plugin identity/order/bypass. No accidental output device routing changes.
  • Pre-stages new plugin instances + full state before changing active chain; aborts on missing/corrupt plugins, keeps old chain; no use-after-free in audio callback.
  • Muted-only save/recall gate to avoid hidden audio interruptions; manual unmute is required.
  • CI JavaScript UI tests + static archive contract and native Windows build.

Explicit ARD limits

Current state serialization and VST3 preparation run on non-RT UI thread while muted. This is an off-air native preset milestone, not yet a seamless live graph-swap, full 12-channel mixer snapshot, session autosave, plugin crash sandbox or streaming router. Do not merge until real Windows hardware confirms ArSonKuPik plugin binary settings round-trip after restarting EXE.

See docs/P2_NATIVE_PRESETS.md.

Copy link
Copy Markdown
Owner Author

P2.4 candidate build — CI GREEN with real ZIP round-trip

Final commit: c43e84d1ca5c777ad75dfe93e604d68c6c6308e1
Successful Windows CI: https://github.com/masarray/arsonmix/actions/runs/40157519119
EXE artifact: https://github.com/masarray/arsonmix/actions/runs/40157519119/artifacts/12585542214

Windows MSVC Release, UI JS syntax and native contract tests, native audio RT control tests, packaging passed. CTest 2/2 PASS: RealtimeControlPrimitives and new NativePresetZipRoundTrip (actual .armix ZIP write/read of binary plugin blob, fader/PAN/mute values, plugin identity and bypass, plus corrupt archive refusal without overwriting validated snapshot).

Hardware trial must still confirm vendor ArSonKuPik getStateInformation and setStateInformation truly round-trip its unique settings after EXE restart. Mute output in SIGNAL CHECK before clicking MY SOUNDS > SAVE SOUND or RECALL; output stays muted after recall. Preset references installed VST3 paths/UID, not redistributable VST3 binaries. Keep PR draft until physical test, then move to immutable prepared graph/hot-swap and multi-input routing milestone.

Copy link
Copy Markdown
Owner Author

Backlog reconciliation — 2026-11-01. Closing as SUPERSEDED/ARCHIVED, not merged. This early P1/P2 branch is a historical stacked baseline (2026-10-24/25) that targets obsolete parent branches and overlapping native/GUI files. Its useful product requirements are now covered by the merged live 10CH/VST code plus PRD/ARD v5 and active M-U1 #266 / GUI #265. It is NOT certified as safely cherry-pickable on current main.

Canonical workflow: PRD v5, ARD v5, dynamic engine issue #192. Any unique test, VST compatibility or safety insight should be deliberately ported to #266, #265, #180 or #15 against current main with fresh proof—never merge this historical stacked head blindly. Original commits remain accessible; branch is not deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant