Skip to content

[DRAFT] ImmerSIB Concert Front Row XL + warm vocal/room cohesion and bounded makeup - #732

Closed
masarray wants to merge 33 commits into
feat/imersip-on-sonku-p92-single-engine-20261116from
feat/immersib-front-row-xl-cohesion-20261116
Closed

masarray wants to merge 33 commits into
feat/imersip-on-sonku-p92-single-engine-20261116from
feat/immersib-front-row-xl-cohesion-20261116

Conversation

@masarray

Copy link
Copy Markdown
Owner

Scope

  • Add typed native ImmerSIB preset ID8 Concert Front Row XL from owner JUCE Custom screenshot: LARGE 28.8m / 147° / 1.0m / Early 180% / Late 60% / Spatial 100% / Align 0° / Yaw 0° / +2.5dB. Screenshot does not expose hidden voicing, so candidate deliberately chooses existing Detail Warm ID4 (unverified vs original saved IMRS state). All six previous presets unchanged.
  • Restrict source-to-room spectral coherence blend (32% early / 12% late) to native P9.8 ImmerSIB voicing 4/5, keeping measured world-speaker HRTF, room tap geometry, reverb engine and original stereo SIDE intact.
  • Bound P9.5 automatic upward-only makeup to 1.10x for warm scenes, still slew-safe, to reduce potential music-wide gain modulation. Keep existing 0.98 linked limiter. Existing mode 0–3 remain on bit-identical old 1.65 limit.
  • Exact screenshot native settings + IMRS roundtrip and 7-scene PCM tests, gated acoustic-source provenance, offline-only limiter/makeup trace.

Approval boundaries

Draft / owner evaluation required.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6a3fe11
Status: ✅  Deploy successful!
Preview URL: https://35787342.arsonmix.pages.dev
Branch Preview URL: https://feat-immersib-front-row-xl-c.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

CI-red root-cause repair checkpoint — 16 Nov 2026

Evidence-backed fixes (no assumed audio defect):

  1. Windows native ImmerSIB test consumed the first editor's ACK, then immediately expected a second while the editor still held a pending request. Isolated ID8 in a fresh native processor/editor and verified real callback ACK + IMRS state (commit de814a7).
  2. AUTO PR0 vendor-editor source check inspected only the first 700 characters and falsely failed before the close/reopen branch. Replaced with scoped current-owner lifecycle assertions (a92e9d3).
  3. P9 room admission referenced a renderMode field absent in pre-P8.3 Settings. Both parent/child now guard it, retaining P9 Early 0-180% and earlier 0-100%. Host logical FX owner now uses a strongly typed ChannelId comparison.
  4. Photo-only JUCE GUI removed synthetic imersipP92ConcertBoxes but stale native tests still referenced it. Child now uses actual full-scene snapshots at min/max UI values, preserving bounds and DPI checks (f55c083). No deprecated sprite overlay resurrected.

Latest photo-only six-scene GUI and matte JUCE panel were preserved in the child through ae75ba3; new ID8 Concert Front Row XL reuses Live Concert art. No change to P9.7 immutable Venue PCM.

Latest child Fast P9 PCM source run 43890184448: SUCCESS. Spatial authority: SUCCESS. Windows native JUCE/portable: running on exact-head at time of this note; do not claim Windows approval until complete. Product remains DRAFT and still requires matched-loudness owner headphone FAT.

Copy link
Copy Markdown
Owner Author

ImmerSIB owner-directed focused source + reflected high-air milestone — 2026-11-16

Current acoustic candidate (branch HEAD ac1a9e3, prior to GUI-forward-port):

  • Typed P9.8 product range 1.1–2.5m in native UI, validator, presets, and IMRS migration. Old 1.0m -> 1.1m and 4–10m -> 2.5m; scene voicing, ER, late, gain and catalog ID preserved. Private P9.7 Venue 10m golden remains core-only and bit-exact.
  • Presets: Live 2.0m, Royal 2.2m, Arena 2.5m, Front Row 1.3m, Symphonic 1.9m, Velvet 1.8m, owner Front Row XL 1.1m.
  • Only warm voicings 4/5: selective post-KEMAR FIRST-IMAGE early-reflection SIDE high-air >5.2kHz (linear gains .18 and .14). No direct HF boost, late feedback change, fake vocal stem, delay, extra FIR/HRTF or new controls. The gain array was expanded to 12 to actually activate the new curve.

Native PCM proof in run 43899604429 on 44.1/48k: early lateral 7400Hz Detail +20.4%/+21.0%, Impact +16.2%/+16.7%, lateral 1500Hz only +2.35%/+2.40%. All seven preset PCM finite/stereo, old P9.7 Venue hash MATCH, test fixture ID8 limiter reduction 0% (NOT a guarantee for actual mastered concert files), old IMRS data roundtrip tests pending full JUCE Windows.

Parent GUI PR #722 has since changed the JUCE power glyph and moved it to the bottom beside gain, eliminated the redundant CLOSE button, and expanded native GUI FAT. Do not roll that back. A composite parent-based merge tree preserving its latest GUI, plus current acoustic source/test/provenance, has been prepared (pending old Windows FAT).

Approval boundary: Windows portable FAT + headphone loudness-matched owner A/B on the actual concert remain required. No main merge or release; keep Draft.

Copy link
Copy Markdown
Owner Author

Owner nearfield + reflected high-air milestone — qualification at exact merge commit

Audited commit: c32345f9f638dfb837c60ec84405a5ef315631ac on draft PR #732. Stacked PR #722 GUI updates through parent 7be1f3603ab6d8e7cfff0c2a3aab88166ec42e4a preserved: photo-only venue GUI, lower JUCE power icon, master-gain arrangement and no redundant CLOSE. Later parent-only image normalization work merges cleanly (per latest GitHub mergeability check); never overwrite concurrent art.

Changes: P9.8 product Source Distance 1.1–2.5m, one shared native admission/UI/preset/IMRS migration boundary (legacy 1m ->1.1m and >2.5m ->2.5m); 7 factory presets refocused at 1.3–2.5m including owner Concert Front Row XL1.1m. P9.8 voicings4/5 selectively increase interaural early-reflection high-air, not direct treble, late feedback, or invented vocal stems. P9.7 10m Venue private golden remains bit exact.

Measured native 44.1/48k: first-image lateral 7.4kHz Detail Warm +20.4/+21.0% energy, Impact Warm +16.2/+16.7%; 1.5kHz lateral change +2.35/+2.40%. Test-only id8 limiter gain reduction 0%; does NOT prove no limiter pumping on mastered live music.

CI: Windows FAT + native tests run 43901326214 SUCCESS; job 133418715637 Windows JUCE/GUI and portable SUCCESS, focused PCM SUCCESS. All eleven associated checks completed successfully or intentionally skipped (P8.3 scoped research). Windows x64 portable artifact 14241079727, four-scale native JUCE DPI capture artifact 14242011681.

Still Draft / not user-auditioned: No verified Dua Lipa recording headphone A/B at matched loudness; subjective warmth, natural width, harshness, pumping and source-vocal separation remain owner acceptance gates. Never auto-merge or publish a production release based only on electrical PCM tests.

Copy link
Copy Markdown
Owner Author

2026-11-17 — Owner feedback: Front Row grandeur + named preset returning to Custom — FIXED IN DRAFT

Exact qualified HEAD: 6c4363541452e269da7adddae4d63a49f00f3ff6, stacked onto current PR #722 859f2960cf6a25cdec16c8038904d8dd05a9c2ff. Parent photography, host-readback BYPASSED overlay, dimming and FX Power state remain intact. No auto-merge.

Root cause / fix

Live Concert factory uses outputTrim=1.8f (about +5.10545dB) but JUCE shows a 0.1dB rounded +5.1. Previously sync(factory); submit(readControls()) submitted quantized values, and strict factory recognition after native ACK labeled the untouched preset Custom. Selecting a preset now submits exact factory Settings, using an independent message-thread uiScene_ for subsequent controls. A genuine edit updates only that parameter, preserves all untouched factory values, and explicitly switches to Custom. The existing SPSC/native PCM ACK and IMRS binary format are unchanged. Native Windows test selects all seven factory presets, processes the actual callback + timer, checks names remain named, then modifies STAGE and verifies Custom persists after ACK while exact factory gain remains 1.8.

Owner-directed concert balance

Keep Live Concert untouched. Front Row XL #8 listening candidate now Large 28.8m, 134° / 1.5m / ER170% / Late94% / Mix100% / Gain+4.4dB, Warm Detail 4. Previous 147°/1.1m/ER180%/Late60%/+2.5dB remains documented as historical listening provenance, not redefined as P9.7 golden. This raises late hall envelopment and balances stage-front focus, not only the gain or direct treble.

44.1k native deterministic fixture: old Front Row total power 308.40 -> new 651.60; SIDE energy 110.33 -> 419.56; new peak .454. 48k: power 303.92 -> 629.48; SIDE 121.30 -> 425.53; peak .463. These are electrical test signals, not subjective or LUFS estimates; matched-volume real headphone A/B with owner remains mandatory. The accepted P9.7 10m Venue PCM hashes remain exact.

Qualification

CI run 43959740614: SUCCESS on focused PCM, Windows native JUCE editor/preset/ACK regressions, DPI 100/125/150/200 screenshots, production-shaped native Windows build and portable packaging, spatial ownership, Chromium UI smoke and other independent SonKu checks. P8.3 exploratory job intentionally skipped (not a failure).

State: DRAFT, research/audio-listening candidate, not owner-auditioned/released.

Copy link
Copy Markdown
Owner Author

Cross-thread audit — ImmerSIB P9.9 Vocal Room (17 Nov 2026)

The user requested selective port of listening-approved 8D-SonKu P9.9 vocal enhancement to ImmerSIB, while preserving vocal naturalness, no pump, scene identity and independent SonKu product behavior. This feature has already been implemented concurrently at current PR #732 head 6a3fe115008329ccc456e15f1448c66ac8b471e8; an additional reimplementation would be duplicative and unsafe.

Audited exact source:

  • SonKuImmerSIBVocalRoom.h (blob 0aee9e1154f6052db02a8e8dfdb696ef4462aa10) wraps the approved P9.9 MusicalVocalDepth donor d8542d7aa333d689eea9637fc9f5f122c468277a, with bounded 42%/34% warm profile gains and 35ms strength slew.
  • SonKuSpatialCore.h (blob adb44388544cf2378a282afb14cc4c4a48f2a149) isolates feature behind SONKU_IMMERSIB_P99_VOCAL_ROOM_RESEARCH and an explicit per-instance opt-in. It captures the P9.8 source delta before P9.9 changes, preserving existing 32%/12% room co-feeds without double counting. The new 330Hz addition passes through the existing early-six-wall and late reverb engines. It does not build a parallel HRTF, add latency, create a stem bus or alter room OFF/MIX0 paths.
  • ImerSipP92Processor opts in only for branded ImmerSIB; CMakeLists.txt keeps the candidate OFF in default builds and turns it ON only in focused Windows candidate CI.
  • Fast 44.1/48k native gate run 43969289435 PASS: Live 330Hz +7.08/+7.26%, Front Row +5.82/+5.78%, Concert Front Row XL +12.31/+12.54% vs P9.8 off, ~86Hz bass and 7.6kHz high held near baseline, neutral/Venue/ROOM-OFF/MIX0 unchanged bit-for-bit. These are single-frequency synthetic PCM measures, not a subjective vocal isolation/loudness claim.
  • Actual Windows native JUCE editor/state and four-scale DPI captures PASS; full production-shaped Windows build/portable packaging was still in progress at the audit instant. Do not mark released/qualified before the exact-head job finishes.

Product acceptance gate: match loudness and compare the same mastered concert with 8D-SonKu P9.9, ImmerSIB P9.8 and this P9.9 candidate; listen for chest fullness, consonant clarity, vocal-to-room fusion, cymbal harshness and music-wide pumping. Keep PR Draft, no main merge, no global workflow changes.

Copy link
Copy Markdown
Owner Author

ImmerSIB Warm Vocal Room P9.9 selective port — exact candidate 6a3fe11

Donor: listening-approved SonKu P9.9 SonKuP99MusicalVocalDepth.h exact blob d8542d7aa333d689eea9637fc9f5f122c468277a from #733. No full SonKu research stack merged.

Architecture: new SonKuImmerSIBVocalRoom.h is a bounded, 35ms-slewed adapter: 42% Detail Warm (scene4), 34% Impact Warm (scene5) of donor Signature music-vocal/330Hz Q1.4 room treatment. Only explicitly opted-in ImerSipP92Processor instances, room-present + MIX>0; all native PCM remains in one KEMAR/6-wall/late graph. P9.8's original early/late 32%/12% coherence takes the PRE-P9.9 source snapshot to avoid double counting. No new dry center, HRTF, output bus, UI ID, saved IMRS state, heap/FFT, additional lookahead, or dynamic whole-mix makeup. Normal CMake option OFF; branch's focused Windows CI explicitly turns it ON. The donor header itself is byte-identical to the accepted main blob.

Measured full native engine, 44.1/48k: Live Concert 330Hz tonal power +7.08/+7.26%, Arena Thunder +5.82/+5.78%, Front Row XL +12.31/+12.54%. 86Hz body/bass ~0.998–1.000 ratio; 7.6kHz ratio ~0.988–0.998 (no blanket sibilance boost). Whole-music power near neutral because changes are frequency selective; no claim of true stem separation. ROOM OFF sentinel spacePreset=0, MIX0, neutral Venue and P9.7 old golden hashes are identical after opt-in; P9.7 SonKu is untouched. Test uses actual full KEMAR/room PCM, not only standalone EQ.

Root-cause repairs before this checkpoint: corrected a test's mistaken ROOM OFF definition (preset 0, not only Early/Late sliders=0); corrected native JUCE sample parity reference to opt-in the SAME core before comparison; reconciled current #722 BYPASSED charcoal overlay/Glyph with the exact P9.8 audio source, factory 7-scene catalog, .1–2.5m product boundary and authority SHA. Only four intended GUI and visual-test files differ from pre-reconciliation acoustic candidate.

Verified CI as of comment: exact-head 43969289435 Fast PCM/source SUCCESS, spatial authority SUCCESS, actual Windows native JUCE+real ACK/state/sample-parity CTest SUCCESS, native 100/125/150/200 DPI captures SUCCESS, Chromium smoke SUCCESS. Windows full ARMixConsole executable build and portable stage still in progress as of this note. Do not claim portable build succeeded until it does.

Remaining user acceptance: matched-volume Dua Lipa live-concert headphone A/B of P9.8 baseline vs candidate, especially center warm resonance, no piercing 2–4k, coherent room return, steady bass and no audible limiter pumping. Green PCM cannot certify listening quality. PR remains DRAFT; no autonomous merge or release.

Copy link
Copy Markdown
Owner Author

Final exact-head Windows qualification — 17 Nov 2026

HEAD: 6a3fe115008329ccc456e15f1448c66ac8b471e8 (PR #732 Draft, parent #722 cbcef96a89b040628a5670137ec1e66b8f433618, mergeable).

Windows source+JUCE+portable run 43969289435: SUCCESS both jobs.

  • Fast Linux 44.1/48k PCM, exact P9.7 Venue hash, warm P9.9 vocal/room opt-in A/B, ROOM OFF/MIX0 and non-opted identity: PASS.
  • Native JUCE editor/ACK/state and sample parity with identically opted-in core: PASS; 100/125/150/200 DPI screenshots: PASS.
  • Full x64 ARMixConsole build: PASS; portable verification and artifact upload: PASS.
  • Other exact-head workflows: 10 SUCCESS, 0 FAILURE, 1 intentionally SKIPPED (P8.3 standalone physical-speaker research).
  • Windows portable candidate artifact 14276144639 (30,861,079 bytes).
  • Four-scale real JUCE capture artifact 14277029094.

Release boundary unchanged: private option ON only in this CI, production default OFF, PR DRAFT, no main merge/release without user matched-volume headphone approval on actual live-concert program. Audio metrics are synthetic and do not prove natural vocal quality, no sibilance/pumping or individual vocal stem separation.

masarray added a commit that referenced this pull request Nov 17, 2026
…dows release hardening (#734)

Preserve approved SonKu P9.9 main, selectively integrate #722/#732/#731, maintain one PCM graph and IMRS sessions; native and public-OFF Windows profiles, MIT notices and installer FAT proven.

Copy link
Copy Markdown
Owner Author

Milestone A — ARCHIVED / CLOSED UNMERGED (no code merge or branch deletion). The approved ImmerSIB engine/concert-scene scope was selectively forward-ported via merged #734 and publicly shipped in alpha.26; the old screenshot-derived 1m draft is NOT the authoritative public tuning.

Immutable original head: 6a3fe115008329ccc456e15f1448c66ac8b471e8. Original source branch: feat/immersib-front-row-xl-cohesion-20261116; original PR target: feat/imersip-on-sonku-p92-single-engine-20261116. Full 47-PR source-head inventory: docs/governance/MILESTONE_A_PR_BRANCH_RECONCILIATION_20261117.md on chore/milestone-a-pr-history-20261117 (planned for main). Closing this review surface is not proof of importing every experimental commit and is not permission to retune released SonKu or ImmerSIB. All branch refs, checkpoints and original code are preserved. Reopening requires a new, precisely scoped owner-approved reason.

@masarray masarray closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant