Skip to content

[RC] Integrate ImmerSIB Engine P9.9 + premium JUCE GUI on approved main (flagged) - #734

Merged
masarray merged 12 commits into
mainfrom
integrate/immersib-engine-gui-release-candidate-20261117
Nov 17, 2026
Merged

masarray merged 12 commits into
mainfrom
integrate/immersib-engine-gui-release-candidate-20261117

Conversation

@masarray

@masarray masarray commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

ImmerSIB integrated RC — main-based, no history replay

Release state: DRAFT / field candidate. Do not publish as a public product yet.

Provenance and non-regression

User-facing result

  • Seven scenes: Live Concert, Royal Concert Hall, Arena Thunder, Front Row Power, Symphonic Palace, Velvet Cinema, Concert Front Row XL.
  • Six approved 2200×922 photo assets; compact real JUCE editor, 100/125/150/200% Windows DPI captures.
  • Exact unrounded factory preset through audio ACK; genuine knob edit demotes to Custom. Native FX slot/rack/global bypass with physical-PCM readback, Win32-owned floating editor/reopen; additionally show FX UNAVAILABLE if a previously valid processor lease retires.
  • Warm vocal body + instrument mid/high masking relief + bass impact, P9.9 vocal/room coupling, bounded makeup, with P9.7 Venue/golden and 8D-SonKu P9.9 checkpoint guarded by native PCM tests. These are engineered candidates, not a subjective sound-quality approval.

Qualification / release gates

  1. Exact head 7c14372a03e35a5e4194c3e54b3e1625f095f53c: source contract, 44.1/48k PCM and golden, Chromium smoke, Win32 native reopen, native FX user presets, player and AUTO PR0 passed.

  2. Pending exact-head Windows qualification: focused native JUCE + packaged portable + subsequent RC-OFF public build. The previous 5c7455d4 RC ON portable succeeded, but its new RC-OFF CMake cache check produced a Windows CRLF false negative; strict logical-line parsing is fixed at 7c14372a. Must finish SUCCESS before this RC is treated as field-ready.

  3. Pending physical Windows user FAT: load the exact-head portable RC; insert each ImmerSIB preset, use actual ASIO/playback; re-open floating editor; check individual slot OFF/ON, rack OFF/ON, global FX A/B and preference restoration; save .smix, restart/reconnect and restore.

  4. Pending owner headphones approval: loudness-matched Live Concert vs Front Row XL vs approved SonKu P9.9 on mastered music; confirm lead vocal natural/full (not thin or harsh), kick/sub-bass impact, instrument/treble width, externalization, audible early-room >100% and no pumping/clipping.

  5. Distance policy unresolved: current 1.1–2.5m to avoid farfield voice collapse; prior user target 1–4m. Legacy IMRS up to 10m silently clamps to 2.5m on migration in this candidate. Owner must approve compatibility policy or a separate non-destructive migration before public release.

  6. Critical release-flag boundary: ARMIX_IMMERSIB_RELEASE_CANDIDATE=OFF by default. The current .github/workflows/alpha-preview-publish.yml builds with default flags and will omit ImmerSIB, even after merge. A reviewed, explicitly approved production-flag promotion is mandatory after physical/listening acceptance; public release notes and downloadable installer must match the shipped executable.

  7. On acceptance only: review release control/owner comment gate, one pinned main SHA, full Windows installer upgrade/uninstall and checksum verification, one published alpha prerelease with direct landing-page download. Do not manually dispatch overlapping workflows or auto-merge.

  8. Public distribution notices and source rights review: the isolated field-candidate ZIP includes THIRD_PARTY_8D_SONKU_HRTF.md alongside the portable bundle, but the current public package_native_windows.ps1 copies only the root README.md into its strict-allowlist dist/, not the full KEMAR/MIT attribution. Before actual public installer publication, embed/verify the required legal notices in the installer and portable ZIP, and document distribution rights/provenance for all six venue photographs. The 1994 MIT KEMAR terms require author credit; do not infer image licensing from PNG validity checks. The repo is AGPL-3.0-only and JUCE 8 is AGPLv3/commercial dual licensed; public binary licensing and corresponding-source obligations need review.

Rollback: Disable only the ImmerSIB candidate flag or revert this integration; do not roll back the already approved SonKu P9.9. Detailed field gate: docs/IMMERSIB_MAIN_RC_RELEASE_GATE_20261117.md.

Do not mark Ready, merge, tag, dispatch a public release or claim user listening approval from CI alone.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: fd50af6
Status: ✅  Deploy successful!
Preview URL: https://4c0b1ed7.arsonmix.pages.dev
Branch Preview URL: https://integrate-immersib-engine-gu.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

Cross-thread reconciliation audit — 17 Nov 2026 · exact HEAD 8c05f6cb4d30bde2318114c67bc90bb1972ea536

This PR consolidates #722 (JUCE GUI / host three-gate power), #732 (ImmerSIB P9.8/P9.9 Warm Vocal Room, nearfield, Front Row XL), #731 (native editor HWND ownership/reopen), preserving approved SonKu P9.9 from main at 7b0c2fc1. All changes are selectively forward-ported, NOT 400+ experiment commits.

Gap closure vs initial integration

  • Restored nearfield SonKuSourcePlacement3D.h source geometry (minimum 1.0 m; product rail 1.1–2.5 m) and kept immutable lineage source blob SHA; never adjusted PCM golden numbers to force green.
  • Exact factory settings survive audio ACK without rounding to visible dB rails; slot/rack/global bypass is read from accepted PCM and shown across JUCE editor and WebView at same snapshot revision.
  • Reconciled approved-native bridge scalar globalFxBypassed signature, preventing expensive UI DOM reconstruction and stale per-slot power displays; added regression A/B for global bypass preserving per-slot preferences.
  • Included missing real native 44.1/48k factory scene audition fixture; initially omitted from selective transfer, now restored.
  • Imported Win32-owned popup tests/workflow from fix(native FX): mixer-owned floating editors and reliable FX Rack reopen #731 and fixed a serious prior test weakness: NDEBUG under Release removed assert() checks, including side-effect window registration. Asserts are now forcibly enabled in isolated Release FAT.

Gates

On exact 8c05f6cb: AUTO PR0 fast contracts, UI smoke (Chromium), native accepted preset store (Windows), player contracts, real Win32 HWND owned popup (Windows with asserts), ImmerSIB native fast PCM/authority/scene tests all PASS. Focused JUCE Windows insert/ACK/DPI, full ARMixConsole build and verified portable ZIP remain IN PROGRESS, not yet qualified.

The non-JUCE native PCM gate verifies 44.1/48 kHz, 1.1–2.5m, Early Room 180%, P9.7 Venue golden, stereo anti-phase, 330 Hz enhancement vs disabled opt-in and neutral / room-off bypass invariance. Synthetic-tone metrics are not listening approval.

Production and release safety

ARMIX_IMMERSIB_RELEASE_CANDIDATE defaults OFF. Branded ImmerSIB is compiled in only with explicit RC flag ON, whereas approved 8D-SonKu P9.9 remains ON in normal main production builds; SonKu per-instance P9.9 opt-in is not silently transferred. No release dispatched. Merge is not authorized unless exact-head JUCE native/production-shaped Windows FAT succeeds; public release remains gated by owner's headphone A/B acceptance and controlled release workflow.

Source PRs #722/#732/#731 remain traceable as evidence. Do not overwrite this curated integration with their divergent heads.

…DK define; preserve complete host bypass test state

Copy link
Copy Markdown
Owner Author

Independent cross-thread integration audit — 2026-11-17 (exact head d8f66772580f1ec657eb6593686ab2bfecb1bcda)

Result: INTEGRATION CODE + WINDOWS BUILD PASS; PRODUCT LISTENING / PUBLIC RELEASE NOT APPROVED.

Source reconciliation checked against #722 (715b21b8), #732 (6a3fe115), #731 (61d64cd7) and approved SonKu P9.9 main (7b0c2fc1). PR #734 is a six-commit main-based selective port (not 400+ experiment commits); all 43 changed paths inspected at manifest level. The single SonKuSpatialProcessor -> SonKuSpatialCore PCM owner is retained, with ImmerSIB opt-in P9.8 detail/impact + P9.9 vocal-room adapter, separate from approved SonKu P9.9. Stable catalog ID armix.builtin.imersip.v1 and IMRS v6/v7 restore remain present.

Evidence pinned to this head:

Remaining acceptance / no-regression gates:

  1. Owner headphone A/B at matched perceived loudness on concert material: Live Concert vs Front Row XL vs existing approved SonKu P9.9, vocals/chest warmth vs harshness, bass punch without pumping, treble/instrument details vs masking, perceived depth and stereo/anti-phase.
  2. Physical PC FAT: Power slot/rack/global with remembered preferences; close/reopen and focus; save/reopen .smix / IMRS v6/v7; ASIO and fallback device change; 100–200% DPI layout.
  3. Product range policy: integrated candidate currently caps distance at 1.1–2.5m (all factory venues inside this), while earlier user direction discussed 1–4m. This is a conscious nearfield limitation in donor [DRAFT] ImmerSIB Concert Front Row XL + warm vocal/room cohesion and bounded makeup #732, not proof that 2.5–4m has been covered. Obtain owner acceptance before changing this on the main release candidate.
  4. Maintain ARMIX_IMMERSIB_RELEASE_CANDIDATE=OFF in default public builds until signed off. Do not merge [DRAFT — ImmerSIB P9.7 Venue + P9.8 Detail/Impact] Single native SonKu engine, concert GUI #722/[DRAFT] ImmerSIB Concert Front Row XL + warm vocal/room cohesion and bounded makeup #732/fix(native FX): mixer-owned floating editors and reliable FX Rack reopen #731 directly over this curated head, do not merge this PR or dispatch public release based on green CI alone, and avoid duplicate costly workflow dispatches.

No source edit or release/merge is requested by this audit comment. Exact-head Windows evidence is preserved for owner evaluation.

Copy link
Copy Markdown
Owner Author

Second independent reconciliation audit — 2026-11-17 · PR #734 HEAD d8f66772580f1ec657eb6593686ab2bfecb1bcda

Verdict: selective integration and exact-head Windows CI/build are confirmed; additional cross-product admission hardening is required before main merge. No production merge/release authorized by this review.

Confirmed reconciliation and evidence

Concrete code-isolation gap: SonKu admits ImmerSIB-only controls

  • engine/builtin_fx/sonku/SonKuP98SceneVoicing.h extends global SceneVoicing::valid to IDs 4/5; SonKuSpatialCore::valid globally admits mode9 distance from 1.0m and Early Room up to 1.8. These altered global validation contracts compile even when ARMIX_IMMERSIB_RELEASE_CANDIDATE=OFF with approved SonKu P9.9.
  • SonKuSpatialCore.h immersiveWarm is keyed by mode9/room/sceneVoicing 4/5 without checking product opt-in, and applies P9.8 32%/12% room feeds and the 1.10x makeup ceiling. p98Voicing_.source likewise processes IDs 4/5 without ImmerSIB identity. Only the additional P9.9 vocal-room adapter is guarded by immersibP99Enabled_.
  • src/SonKuNativeBridgeContract.h decodes a generic integer sceneVoicing, and SonKuSpatialProcessor::queueSettings and SONK state restore use globally widened sonku::valid. Thus a non-ImmerSIB 8D-SonKu instance could accept ImmerSIB voicing 4/5 through control/serialized state even if its normal GUI does not expose these options. Existing approved default PCM tests only prove untouched normal presets, not rejection of these cross-product controls.

Required fix: enforce product-specific admission at both native queue and SONK restore / JS control decode; reject ImmerSIB-only ID4/5 and extended distance/ER ranges for regular SonKu; allow them only for the actual ImmerSIB processor with its explicit opt-in. Add exact-head negative tests (SONK normal native queue, old/new session restore, WebView bridge, and RC OFF/ON profiles). Do not change approved SonKu PCM/HRIR, Venue golden, preset 0..3, or the catalog/session ABI.

Remaining requirements

  • The RC currently allows 1.1–2.5m instead of prior user-requested 1–4m; the shift came from [DRAFT] ImmerSIB Concert Front Row XL + warm vocal/room cohesion and bounded makeup #732 and must be explicitly accepted or implemented with room-geometry-validated bounds (Studio 7.2m cannot necessarily support 4m).
  • Front Row XL donor [DRAFT] ImmerSIB Concert Front Row XL + warm vocal/room cohesion and bounded makeup #732 deliberately revoiced the historical screenshot 147°/1.0m/ER180%/Late60%/+2.5dB into 134°/1.5m/ER170%/Late94%/+4.4dB. This is code-integrated but remains unapproved as an ear-matched replacement.
  • Real-PC GUI/audio FAT (slot/rack/global bypass and lease invalidation/reopen, ASIO device change, .smix/IMRS cold restore, DPI) + headphone loudness-matched vocal/bass/treble/depth audition are still pending. Normal RC-OFF full application build and all-skipped Chromium visual scopes should be separately qualified or explicitly justified.
  • UX follow-up: when host power lease is invalid, editor disables Power but leaves venue scene fully bright (the optional bypass state resets to null), which may misleadingly look active. Consider a precise FX UNAVAILABLE overlay, distinct from an actual accepted bypass.

No history merge, production merge, force-push, duplicated CI dispatch, or public release triggered by this audit.

Copy link
Copy Markdown
Owner Author

P0 cross-product admission hardening — 17 Nov 2026 · exact 15ec57da680ac58ce1ce2cf343d5a69716c5e126

One atomic commit on existing draft PR #734: 15ec57da (7 files), parent d8f6677. This fixes the independently audited safety gap without rewriting/replaying #722/#732/#731 or touching operator-approved SonKu P9.9 acoustic code.

Fix and proof

  • Added sonku/SonKuProductAdmission.h as the single non-RT 8D-SonKu product-policy function. Original SonKu per-product valid rails remain distance ≥1.6m, ER≤100%, typed scene IDs 0..3. SonKuSpatialCore::valid intentionally remains broad enough for the ImmerSIB-specific shared-core profile.
  • SonKuSpatialProcessor::admitQueuedScene defaults to the regular SonKu gate; the existing ImmerSIB override still uses validImerSipP92Scene to admit its specific valid 1.1–2.5m/ER180%/IDs4–5 controls. Base SONK state restoration now calls the same virtual product admission before setting core or accepted scene. The regular SonKu WebView decode uses the same gate; no path silently accepts an ImmerSIB scene from JSON, queued update or SONK v12 restore.
  • Added RC-ON real JUCE 44.1/48k positive/negative native test cases (ordinary SonKu PCM ACK, valid session roundtrip; reject foreign ID4, nearfield 1.1m, ER170%, tampered SONK wire) and RC-OFF JUCE state test (reject 1.1m in WebView, queue, and v2 binary restore). Added source contract assertion for the single-policy routing.
  • Updated the documentation-only authority ledger: active integration PR 734 with donor provenance 722/732/731, SonKu SonKu P9.9 approved listening — selective main integration, preserve Venue & sibling products #733, no auto-merge, releaseCandidateIntegratedOnMain=false (truth: main remains 7b0c2fc1). No FX ID, IMRS/SONK byte layout, queued ACK semantics, realtime processing or UI knob geometry changed.

Explicit acoustic preservation

Pinned git blob parity unchanged vs d8f6677: SonKuSpatialCore.h f9fdcdec93, SonKuP98SceneVoicing.h 5ec8d135d5, SonKuImmerSIBVocalRoom.h 0aee9e1154, ImerSipP92Scene.h 15256e2775, ImerSipP92Editor.h 2894097fcc, and ImerSipP92VisualSkin.h 19bf93cee7. SonKu approved default, ImmerSIB venue and vocal/body voicing are intentionally untouched; no new second DSP or hot-path locks.

Qualification status at post time

  • On new head, P9.1/P9.2 source/golden/anti-phase/audio tests + source contract SUCCESS; AUTO PR0, native editor Win32 reopen, Chromium smoke, user preset tests SUCCESS. Real JUCE RC-on Windows app build/package job still IN PROGRESS at comment creation; inspect the exact new head before claiming acceptance. Prior d8f6677 portable artifact is not an artifact for this new head.
  • Further gates remain: full Windows x64 package/checks on 15ec57da, normal default RC-OFF console build, physical sound device/ASIO window+power+saved-state FAT, and operator headphone loudness-matched audition. The old 1–4m request vs now-implemented 1.1–2.5m (and legacy session clamp) is explicitly not revoiced or migrated here until an informed compatibility/listening decision; never mutate historic saved intent silently.

KEEP DRAFT; do not merge/release/auto-merge without exact-head CI, main-compat and human headphone signoff. No manual workflow dispatch; GitHub's path-triggered single commit already started the required runs.

Copy link
Copy Markdown
Owner Author

Release-progress checkpoint — 17 Nov 2026 — exact PR #734 HEAD 5c7455d44c00c3898deaf99a7d57515b7d7a841f

Goal: qualify all reconciled ImmerSIB advances for an eventual public Windows alpha without dropping any native FX or user-approved SonKu P9.9 progress.

Work actually committed

  • 15ec57da: unified per-product control-plane admission, rejecting ImmerSIB-private voicing 4/5, nearfield (below 1.6m), >100% Early Room from ordinary 8D-SonKu via JSON, native realtime queued edit, and SONK restore; tests added. Original ImmerSIB still permits its scene range/IMRS, no shared DSP fork.
  • f2172d97: native JUCE GUI now displays FX UNAVAILABLE on retired host lease after an accepted live connection (instead of falsely looking powered), with actual framebuffer test; focused Windows FAT now uploads candidate first and reconfigures the same builder into public-default SonKu P9.9 with ImmerSIB OFF, compiles console and checks SonKu native state (no second runner).
  • 5c7455d4: corrected source contract fixture path discovered by fail-fast source CI. No DSP, preset, HRIR, IMRS, library or venue asset changes in these commits.

Git blob parity against 15ec57da confirmed: SonKuSpatialCore.h=f9fdcdec93, SonKuP98SceneVoicing.h=5ec8d135d5, SonKuImmerSIBVocalRoom.h=0aee9e1154, ImerSipP92Scene.h=15256e2775, ImerSipP92Processor.h=bb57cdd189, NativeFxWin32Owner.h=acd4bd2a35.

Current exact-head evidence

  • PR #734 native Windows FAT run 43996381208: source/Golden PCM SUCCESS, real JUCE editor/ACK and screenshot upload SUCCESS, full console build/package/public-RC-OFF recompilation IN PROGRESS at this review. The failed prior f2172d97 fast run was a wrong test file reference, fixed in 5c7455d4 and source gate now passes. Do not cite an older RC ZIP as exact-head qualification.
  • Win32 editor/reopen, Chromium smoke, native preset, AUTO PR0 and player jobs on the exact head are SUCCESS.

Explicit public release blockers — preserve fail-closed

  1. Full Windows RC ON and same-head default RC OFF build must end SUCCESS, signed off from actual job logs and artifact SHA.
  2. Actual Windows audio device and headphone A/B: 7 ImmerSIB presets, FX slot/rack/global power after device reconnect, saved .smix IMRS cold restore; vocal naturalness, LF impact and lateral image relative to accepted SonKu P9.9 at matched loudness. No guessed user acceptance.
  3. Product migration policy: old 1.0m/4–10m IMRS values currently clamp into 1.1–2.5m range; source requested 1–4m. Review before changing user session semantics.
  4. Public publisher configuration is default RC OFF, so simply merging [RC] Integrate ImmerSIB Engine P9.9 + premium JUCE GUI on approved main (flagged) #734 then calling alpha-preview publish would omit ImmerSIB. Do NOT pretend a default alpha contains it. A separate reviewed production enablement, explicit release notes, and verified executable identity are required after listening approval.
  5. Distribution: isolated field candidate includes THIRD_PARTY_8D_SONKU_HRTF.md outside dist/; public strict dist/ package/installer currently omits full KEMAR/MIT attribution. Embed/verify required notices in actual public installer and portable, and confirm provenance/redistribution rights for six scene photographs and AGPL/JUCE8 compliance.
  6. Owner-only release control issue Release controller: owner-only exact-SHA comments, tri-OS roadmap, landing-only downloads #450 includes latest release alpha.23; no new release comment, release tag, paid workflow dispatcher or duplicate release job was created in this work. Future publication must use the repository's exact-SHA owner-only, de-duplicated controller once all gates pass.

PR kept DRAFT. No merge, no public release and no feature-flag inversion. This comment is handoff evidence, not a request to start an unapproved release.

@masarray
masarray marked this pull request as ready for review November 17, 2026 03:05
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T03:06:06.979285Z fd50af6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant