Repository navigation
SonKu P9.9 approved listening — selective main integration, preserve Venue & sibling products - #733
Conversation
…r without global workflow changes
Deploying arsonmix with
|
| Latest commit: |
cdee12c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56bf70bd.arsonmix.pages.dev |
| Branch Preview URL: | https://integrate-sonku-p99-approved.arsonmix.pages.dev |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdee12c6f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| stagedModeEdit_=next; | ||
| modeTransitionPending_.store(true,std::memory_order_release); | ||
| modePhase_=ModePhase::FadingOut; | ||
| return; // ACK only after the actual audio-side mode switch |
There was a problem hiding this comment.
Complete mode edits while the SonKu insert is bypassed
When a published SonKu insert or its rack is fully bypassed, changing head yaw or migrating a saved legacy session to the latest engine enters FadingOut, but only processBlock() advances that fade and publishes completion. In the inspected native host, LiveChannelFxGraph.h:164–181 calls consumeRealtimeEdits() while bypassed and then skips processBlock(), so the transaction stalls, subsequent edits cannot drain, and Show capture remains non-quiescent. servicePendingNativeSonKu() rejects the request after three seconds, yet re-enabling the insert subsequently applies that rejected edit. Handle fully bypassed transitions explicitly so completion does not depend on a callback path the host intentionally skips, and rejected requests cannot later change PCM state.
AGENTS.md reference: AGENTS.md:L156-L156
Useful? React with 👍 / 👎.
Listening-approved SonKu P9.9 → main (selective port; no global workflows)
Operator acceptance: 2026-11-17: "HASIL UJI DENGAR SUDAH BAGUS BISA REKONSILIASI KE MAIN". Preserve that exact acoustic character. P9.9 donor:
61c304e7432955260ff783ff09610cf4200cfd65; immutable listening checkpointcheckpoint/sonku-p99-listening-approved-20261117. Venue P9.7 remains frozen atfda0eef669e0a59575c489e149662c1bf878c998.Scope and risk control
This is ONE additive commit onto main
37985f02caecd93b22f853183888d81e18dc6736, NOT a merge of the 354-commit SonKu research stack (#725–#730). The narrow port contains onlyengine/builtin_fx/sonku/**,SonKuSpatialProcessor.h, SonKu native bridge insrc/Main.cppplussrc/SonKuNativeBridgeContract.h, SonKu GUI/CSS, SonKu tests/scripts/docs/tools, and a SonKu-only CMake configuration. No Harmonice, ImmerSIB #722/#732, native FX window-owner #731, Guitar FX, session/graph/driver implementation or other feature paths are imported.ZERO new or modified
.github/workflows/**files. No required global checks, Harmonic(e) gates, CI watchers, additional workflows, or force pushes.Runtime integration (approved, not merely a dormant source checkout)
CMakeLists.txtretains all historical optional research flags with default OFF; a singleARMIX_SONKU_APPROVED_P99_MAIN=ONsets only ARMixConsole target definitions for the P9.9 audio runtime already auditioned and native-tested on donor PR #730. No other test target or plugin product receives the P9.9 macros automatically. It may be set OFF to restore the old main SonKu compile profile without reverting unrelated work. P9.9 additionally requires per-instance SonKu opt-in; sibling brands sharing the core cannot inherit this preset/voicing accidentally.Approved
ORBIT STAGE · DEFAULT: 12s clockwise, 127° virtual spread, 2.7m, +5.1dB display, Large 28.8m room, ER 100%, late 77%, center-vocal body/reflection. Existing saved .smix remain authoritative; the Venue 10m profile is not rewritten.Proof and merge stop conditions
Donor P1 native JUCE Windows run 43904727228 SUCCESS 13/13 real native CTests; real Windows GUI portable artifact #14245082679, full KEMAR+room PCM Venue bit-exact and cross-product 24/24 PCM identical when P9.9 compiled but product instance not opted in; Chromium desktop/narrow run 43904727209 green.
This main-line port must additionally pass integration branch CI, especially the actual main-target JUCE GUI build and current app contracts. Do not merge on donor-only CI. If any main tests fail, resolve the actual root cause without disabling global gates. PR is initially DRAFT and will only be made ready / merged when the exact main-base candidate is proven safe.
Note: cross-branch PR #731 and #732 remain independently unmerged; future branch merges must review their shared headers and window ownership rather than overwrite the approved SonKu DSP.