You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
8D-SonKu M4: native SPACE room size/distance/ambience, realtime FDN and FX GUI ACK - #647
M4 — Native SonKu SPACE: room-aware musical ambience wired to real GUI and PCM
Stack: this PR targets #643 (M3 distance/large-space), itself stacked above #629 (approved Square/V3 FDN) and #606 (native editor / latest mixer merge). Do not merge directly into main until ancestors are reconciled. Public installer remains gated; preserve approved Square checkpoint 3a74b0273c7a.
Functionality
Compact integrated FX editor ROOM controls: OFF / SQUARE (7.2m) / CHAMBER (14.4m) / LARGE (28.8m), distance up to geometry-valid maximum, AMBIENCE 0–100%. Same existing /preview/ CSS owner.
Typed settings in native SonKu processor: spacePreset, sourceDistanceMeters, roomAmount, ambience. Route through existing exact lease/epoch/revision-fenced nativeSonKuSet -> SPSC -> JUCE PCM callback -> applied completion -> native snapshot schema v2 -> GUI ACK/readback. No WebAudio, no second engine or optimistic 'DSP APPLIED'.
Fixed 8-line FDN coefficient bank prepared at host prepare for 0.78 / 1.28 / 2.05 seconds, bounded damping; sample-smoothed changes, no exp/FFT/locks/heap in callback.
Re-enable of ER/FDN uses bounded validity horizons instead of clearing ~64/128KiB rings inside live callback. Existing approved Square HRTF / early-reflection geometry stays unchanged.
New SonKu SONK state version 2 (46 bytes); old 30-byte v1 restores as room OFF, corrupt state rejected. Conservative tail reporting 2.6s for possible late reverb.
Tests and controls
C++ native-core active scene signal / finite PCM / buffer partition parity, invalid room/distance, runtime scene edits.
C++ prepared FDN preset switching and stale tail suppression.
Actual Chromium assembled FX editor test: typed 2→5m distance, clamp back to Square, OFF bypass with exact ACK/readback, both desktop and narrow viewport.
Source contract confirms real native Main.cpp snapshot and state serialization.
See docs/SONKU_M4_NATIVE_SPACE_RELEASE_CANDIDATE_20261113.md.
Not production proof
Require exact-head scoped CI, then one reconciled exact-SHA Windows FAT/ASIO package, multi-instance/restart/save-open verification and headphone musicality acceptance before marking ready/merging/releasing.
Room acoustic model is first-order 2D walls and musical decay (not measured BRIR or personalized HRTF). No claims of perceptually true giant hall yet.
The acoustic/native stack is now reconciled into PR #649, an integrated draft based on current main. Its two-parent merge carries this PR's history and the latest #606 native/GUI/updater/WIRE parent simultaneously. Please do not merge this older stacked PR independently into main, or queue redundant Windows builds: the canonical combined qualification now belongs to #649, after which old drafts can be closed as superseded.
Preserved: approved Square Orbit checkpoint 3a74b0273c7a7e13d5d2614183d19995eb12ad57, 8-line FDN, fixed ring/no-RT-clear behavior, source-distance + room models, typed native SPACE controls, schema v2 session restore, real Chromium ACK/readback and musical A/B WAV. All remain pending actual Windows/ASIO and listener release gates.
MILESTONE A — archival closure WITHOUT MERGING. This older P0/P6/M4 SonKu native-space/room/stereo experimental PR is now historical research. The actual owner-listening-approved P9.9 production integration is merged #733; this earlier research chain is not a product release or safe merge source. Source branch: feat/8d-sonku-m4-native-space-gui-20261113 at exact original SHA 29e671bf1e0cf49a302dd842a058fcfd0070991f, original base feat/8d-sonku-v4-distance-spaces-20261113. Ledger: docs/governance/MILESTONE_A_PR_BRANCH_RECONCILIATION_20261117.md on chore/milestone-a-pr-history-20261117. All original code/refs/checkpoints are preserved. No branch deletion, code merge, GUI/PCM change, or release mutation. A new scoped task may reopen it after validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M4 — Native SonKu SPACE: room-aware musical ambience wired to real GUI and PCM
Stack: this PR targets #643 (M3 distance/large-space), itself stacked above #629 (approved Square/V3 FDN) and #606 (native editor / latest mixer merge). Do not merge directly into main until ancestors are reconciled. Public installer remains gated; preserve approved Square checkpoint
3a74b0273c7a.Functionality
spacePreset,sourceDistanceMeters,roomAmount,ambience. Route through existing exact lease/epoch/revision-fencednativeSonKuSet-> SPSC -> JUCE PCM callback -> applied completion -> native snapshot schema v2 -> GUI ACK/readback. No WebAudio, no second engine or optimistic 'DSP APPLIED'.Tests and controls
docs/SONKU_M4_NATIVE_SPACE_RELEASE_CANDIDATE_20261113.md.Not production proof