Skip to content

M2.5 P0 — reconcile active PR owners and enforce no duplicate GUI/bridge/PCM in existing CI - #401

Closed
masarray wants to merge 1 commit into
mainfrom
coordination/m2-5-one-owner-reconciliation-20261105
Closed

masarray wants to merge 1 commit into
mainfrom
coordination/m2-5-one-owner-reconciliation-20261105

Conversation

@masarray

@masarray masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner

M2.5 — repository/architecture reconciliation (implementation, not an alternative engine)

Authoritative ledger: #399
Base: main@c1a11afd145380a944c9844937ccb6a97b5e0557 (M2 #394 already merged)

Changes

  • Bind one active owner per production subsystem in AGENTS.md and docs/workstreams/M2_5_RECONCILIATION.md.
  • scripts/check_workstream_ownership.mjs queries ACTUAL OPEN PRs and changed files, detects overlap by production domains even when different files are modified inside the same audio engine. It rejects newly introduced alternate web/console-native.* GUI and retains exact-junction review warnings.
  • New PR P0 coordination: enforce single-owner PRs and detect parallel edits before heavy CI #400 onwards: CI failure on competing runtime owner; old PRs <=399 are ADVISORY so ongoing engine/GUI consolidation is not deadlocked. Fail-closed if GitHub metadata cannot be checked.
  • Wire the cheap check into the EXISTING Windows and Chromium workflows. No new workflow/runner, no unneeded background automation. Eight deterministic unit tests and Chromium test execution.
  • No changes to GUI layout, native asset source, audio callback, PCM graph, release gate Milestone A integration gate: enforce ONLY /preview/ and genuine native ChannelId PCM admission #398, nor vendor VST3.

Explicit disposition

Merge gates: deterministic M2.5 unit tests, exact-head Chromium and Windows checks; preserve all current approved GUI and native M2 tests. This PR is a coordination/control-plane change, NOT real PCM / hardware FAT / production release.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T20:06:56.530086Z 60534ae PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60534ae957

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +19 to +20
['release-admission', /^scripts\/(?:check_console_puzzle|check_approved_native_gui_release)\.mjs$/],
['hardware-fat', /^scripts\/(?:collect_hardware_fat_windows\.ps1|console_v6_fat_gate\.mjs)$/],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Trigger the guard for release-admission and FAT changes

A new PR that changes only scripts/check_console_puzzle.mjs, scripts/check_approved_native_gui_release.mjs, scripts/collect_hardware_fat_windows.ps1, or scripts/console_v6_fat_gate.mjs never reaches this guard: none matches the pull_request.paths filters in either ui-smoke.yml or p1-windows.yml, the only workflows invoking it. Consequently, these declared protected domains can overlap an open owner without any ownership check running, contrary to the enforcement required by AGENTS.md. Add the protected script paths to an existing workflow's PR filters.

AGENTS.md reference: AGENTS.md:L36-L36

Useful? React with 👍 / 👎.

Comment on lines +35 to +39
for(const f of files) {
const label=region(f.filename);
if(label) {
if(!mine.has(label))mine.set(label,[]);
mine.get(label).push(f.filename);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include the current PR's original paths when checking renames

When the current PR renames a protected file outside its recognized region, mine ignores the original path and the ownership collision disappears. For example, PR #401 renaming web/approved-native-bridge.js to archive/old-bridge.js returns hard: [] even with PR #396 modifying the original bridge. This allows a competing PR to move the active owner's implementation despite the ownership invariant in AGENTS.md. Process previous_filename for the current PR as well as for other PRs, and add a test with the rename on the current side.

AGENTS.md reference: AGENTS.md:L36-L36

Useful? React with 👍 / 👎.

masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

M2.5 reconciliation / explicit duplication resolution: PR #400 and issue #397 already implement this same control-plane role with more complete owner metadata, PR template and 11 deterministic tests. #401 was created concurrently before #400 was visible to this worker. To obey ONE owner / no duplicate workflow we are closing #401 unmerged and retaining all code/history for audit. Unique useful improvements from #401 are being handed to #400: detect collisions across an entire engine or bridge runtime domain even when filenames differ; defer strict enforcement until PR #400 onward so existing #396/#398 are not unexpectedly blocked; reject added alternative console-native GUI. No GUI/audio code from #401 is required. See #397 and #399 for detailed ledger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant