Repository navigation
Conversation
…g PRs in existing CI
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60534ae957
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ['release-admission', /^scripts\/(?:check_console_puzzle|check_approved_native_gui_release)\.mjs$/], | ||
| ['hardware-fat', /^scripts\/(?:collect_hardware_fat_windows\.ps1|console_v6_fat_gate\.mjs)$/], |
There was a problem hiding this comment.
Trigger the guard for release-admission and FAT changes
A new PR that changes only scripts/check_console_puzzle.mjs, scripts/check_approved_native_gui_release.mjs, scripts/collect_hardware_fat_windows.ps1, or scripts/console_v6_fat_gate.mjs never reaches this guard: none matches the pull_request.paths filters in either ui-smoke.yml or p1-windows.yml, the only workflows invoking it. Consequently, these declared protected domains can overlap an open owner without any ownership check running, contrary to the enforcement required by AGENTS.md. Add the protected script paths to an existing workflow's PR filters.
AGENTS.md reference: AGENTS.md:L36-L36
Useful? React with 👍 / 👎.
| for(const f of files) { | ||
| const label=region(f.filename); | ||
| if(label) { | ||
| if(!mine.has(label))mine.set(label,[]); | ||
| mine.get(label).push(f.filename); |
There was a problem hiding this comment.
Include the current PR's original paths when checking renames
When the current PR renames a protected file outside its recognized region, mine ignores the original path and the ownership collision disappears. For example, PR #401 renaming web/approved-native-bridge.js to archive/old-bridge.js returns hard: [] even with PR #396 modifying the original bridge. This allows a competing PR to move the active owner's implementation despite the ownership invariant in AGENTS.md. Process previous_filename for the current PR as well as for other PRs, and add a test with the rename on the current side.
AGENTS.md reference: AGENTS.md:L36-L36
Useful? React with 👍 / 👎.
|
M2.5 reconciliation / explicit duplication resolution: PR #400 and issue #397 already implement this same control-plane role with more complete owner metadata, PR template and 11 deterministic tests. #401 was created concurrently before #400 was visible to this worker. To obey ONE owner / no duplicate workflow we are closing #401 unmerged and retaining all code/history for audit. Unique useful improvements from #401 are being handed to #400: detect collisions across an entire engine or bridge runtime domain even when filenames differ; defer strict enforcement until PR #400 onward so existing #396/#398 are not unexpectedly blocked; reject added alternative console-native GUI. No GUI/audio code from #401 is required. See #397 and #399 for detailed ledger. |
…ject alternate GUI, grandfather existing PRs
M2.5 — repository/architecture reconciliation (implementation, not an alternative engine)
Authoritative ledger: #399
Base:
main@c1a11afd145380a944c9844937ccb6a97b5e0557(M2 #394 already merged)Changes
AGENTS.mdanddocs/workstreams/M2_5_RECONCILIATION.md.scripts/check_workstream_ownership.mjsqueries ACTUAL OPEN PRs and changed files, detects overlap by production domains even when different files are modified inside the same audio engine. It rejects newly introduced alternateweb/console-native.*GUI and retains exact-junction review warnings.Explicit disposition
Merge gates: deterministic M2.5 unit tests, exact-head Chromium and Windows checks; preserve all current approved GUI and native M2 tests. This PR is a coordination/control-plane change, NOT real PCM / hardware FAT / production release.