Repository navigation
Conversation
… without hidden patch/start/arm wizard
…rce selection and remove implicit CH1/2 start
…tup to existing custom I/O panel
… verified routing epoch
…asured meters on actual M4 PCM
…native UI is approved preview bundle
…native UI is approved preview bundle
…r IN without redesign
…elf-manages native safe monitor transition
…hanging approved mixer skin
…pact Audio I/O styling
…nitoring with advanced JUCE recovery only
…after device changes
… real M4 mixer readback
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fe434b828
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| p.phase="monitor";p.revision=Number(d.revision); | ||
| backend.emitEvent("arMixAction",{action:"monitor",value:true, | ||
| expectedEpoch:p.epoch,expectedRevision:p.revision}); |
There was a problem hiding this comment.
Preserve explicit monitoring consent when changing an input
When MAIN monitoring is off, selecting a physical IN now reaches monitorAfterSource() after the source ACK and unconditionally sends monitor: true, even though p.wasMonitoring is false. Consequently, patching an input also makes it audible, including after the operator deliberately turned monitoring off. Retain the muted state unless monitoring was already enabled before the transaction, and require an explicit Monitor action for initial arming. This violates the explicit no-silent-auto-arm requirement in AGENTS.md.
AGENTS.md reference: AGENTS.md:L20-L22
Useful? React with 👍 / 👎.
| const b=ioElement("button","tool ar-native-io-open","Audio I/O"); | ||
| b.id="arNativeIoOpen";b.addEventListener("click",openNativeAudioIO); | ||
| before.insertAdjacentElement("afterend",b); | ||
| ioMonitorButton=ioElement("button","tool ar-native-monitor","Monitor off"); | ||
| ioMonitorButton.id="arNativeMonitor"; |
There was a problem hiding this comment.
Keep native hardware controls within the approved GUI
In the Windows WebView, this inserts new Audio I/O and Monitor buttons into the command bar, alongside the newly constructed native-only settings dialog and stylesheet. The public /preview/ assembly receives none of these additions, so the shipped native GUI now differs in appearance and interaction from the approved reference. AGENTS.md explicitly limits this adapter to data/event authority changes and requires the same generated GUI in both environments; hardware setup needs to be integrated through an approved shared surface rather than introducing a native-only visual variant.
AGENTS.md reference: AGENTS.md:L34-L34
Useful? React with 👍 / 👎.
…ve-specific input options injected only at Windows bundle build
…mutating approved public Pages
…ransport startup in minimal DOM
…ctor, not public GUI source
…re/playback feedback loop
…eclaration including opening brace
…same immutable M4 compiler
…mmutable, and stale-epoch safe
…r, and M4 fader transport
…, refresh readback, distinguish patched from unknown
…N MUTE as explicit monitor control, remove added command-bar buttons
Refs #412 — this PR implements the approved native First Sound workflow. Keep #412 open until physical hardware FAT has been independently verified; CI does not certify actual sound.
Root cause
The shipped Windows app uses
site/preview-v2 + web/approved-native-bridge.jsviascripts/build_approved_native_gui.py. The earlierweb/mixer-io.js/web/monitor.jscontrollers belong to a legacy standalone renderer and are NOT the shipped approved WebView! Our previous UI-engine efforts were repeatedly wired to the wrong surface. This PR deliberately restores these legacy files unchanged and edits the actual native bundle.Adobe Audition / FL Studio operator workflow
AudioDeviceManager.INdropdown in existing approved mixer offers actual enabled JUCE pins, including mono or stereo, based on actual callback/physical mask. No fabricated CABLE/IN1 demo list in native host; no CH1-first rule.routingSourceSwitchon exactly the chosen strip; same-format changes use 64-sample native crossfade. Structural changes while monitored perform safe mute, native route ACK/readback and resume MAIN monitoring internally. No Patch CH1 / Arm / Start wizard. Driver/hotplug stale status fails closed.setDryRoutingLabParameterwhile M4 is PCM owner—even if universal ChannelId/FX graph admission is not yet ready. Main controls are sent to native master setters. No JS audio engine.Tests and stop ship
2026-11-08 reconciliation: ARCHIVED, NOT MERGED
Superseded pre-#418 standalone first-sound integration. Current main is the source of truth for per-channel IN, device setup and ACK/realtime PCM, and #412 remains the product acceptance tracker.
Current authority: main, #418. Historical branch retained; hardware FAT not inferred.