Repository navigation
Smart Inno Setup: graceful in-place ArSonMix update, safe user data, automatic launch - #443
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c03f3d210c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ; one new executable only after a successful interactive install/update. | ||
| ; Silent enterprise/FAT installs deliberately do not launch desktop audio. | ||
| [Run] | ||
| Filename: "{app}\\ArSonMix.exe"; WorkingDir: "{app}"; Flags: nowait runasoriginaluser skipifsilent |
There was a problem hiding this comment.
Use a single path separator in the installer launch entry
This entry contains two literal backslashes after {app}, whereas the new launch contract expects one. Running node --test tests/windows_installer_contract_test.mjs fails the “successful interactive install or update launches exactly one new mixer” test at line 41 (0 !== 1). That test is required by both the fast Linux contracts and Windows validation in .github/workflows/p1-windows.yml, so this commit blocks those checks before installer qualification. Use the same single-backslash path spelling as the other Inno entries.
Useful? React with 👍 / 👎.
|
/arsonmix-ci fat 1782151 |
… only WinForms FormClosing
…state-save marker
…state-save marker
…state-save marker
… before PE upgrade
…able pre-exit save
|
/arsonmix-ci fat 76a8b06 |
2026-11-08 Smart Installer native handshake qualification checkpointInno Implemented in this PR on exact head
This checkpoint describes implemented behavior, not a release announcement. |
…istribution nomenclature
|
/arsonmix-ci fat 0a48518 |
Cross-thread reconciled release checkpoint — 2026-11-08Source of truth: Installer #443: in-place same-AppId Inno update, safe signal-based native quit, retained user Studio/.smix, a single post-setup interactive launch, no forced kill, exact-SHA provenance; Device #445: retains channel graph/WIRE/FX and device-independent session after verified Audio I/O Apply; keeps MAIN muted. Critical P1 Codex review issue silently falling back from physical MAIN pins 3/4 to 1/2 has been fixed on the current head: missing pins / changed ASIO inventory -> Both branches edit Merge gate: finish full CI for both heads, then reconcile both branches into |
…SonMix GUI gracefully by HWND/PID
…efore replacement
…epted a graceful close
…e for regression test
…ail-before-replace
… blocked-process safe refusal
… locked-EXE fail-closed
…sreading comments
…lly exercises legacy and blocked apps
…Windows end-session requests
… fail-closed preflight
….ps1; strict preflight is the only shutdown authority
…1; strict preflight is the only shutdown authority
…verride preflight on legacy GUI
P0 field failure: Inno DeleteFile failed code 5 on installed ArSonMix.exe (8 Nov 2026)User screenshot: Current dedicated installer branch
Previous test #42421873294 verified the first two paths but the negative test was not deterministic with a cancellable WinForms window; current #42421982731 uses a truly nonresponsive no-window executable as a hard-lock fixture. Do not mark installer release complete until all three cases pass on current exact head. Coordination: #445 head |
|
/arsonmix-ci fat 2fa18fe |
P0 code-5 installer upgrade fix — verified Windows acceptanceExact PR head: Inno Windows smoke #42421982731 PASS with three independent executable-level cases:
Root fix: Restart Manager and the old conditional-only handshake were insufficient. One strict pre-copy lifecycle now sends native event if available, otherwise matches legacy process by exact installed path and requests safe GUI close, waits for process exit, checks exclusive writable EXE handle; Packaging: exact-SHA Windows MSVC, native CTest and full Inno FAT run #42422158099 is running. Do not advertise a final installable artifact until that run publishes it. Prior installer artifacts are immutable and still lack the new preflight logic. Cross-thread #445: the latest device-change and retained WIRE/FX/MAIN routing work is separate, overlapping only in |
Problem
The existing official Inno Setup RC had
CloseApplications=noand no[Run]: an already-running mixer could block replacement, and successful installation did not launch ArSonMix.Fix
AppId/folder and upgrade in place without uninstalling Studio data or overriding.smixuser state.PrepareToInstallsignals the native per-session shutdown event for compatible builds; JUCE executes normal session save/quit and Inno waits for the running mutex to release. For legacy versions without this event, an embedded temporary-only PowerShell helper finds ONLY the exact installedArSonMix.exeprocess path, requests normal GUIWM_CLOSE(main HWND or PID-filtered top-level HWND), and waits for all matched processes to exit. It then requires an exclusive writable Win32 handle to the original EXE. No force kill or arbitrary process-name shutdown; a hung/locked EXE stops before[Files]without modifying the installed program or private Studio data.CloseApplications=nodeliberately disables the competing Windows Restart Manager shutdown;RestartApplications=noprevents duplicate relaunch.[Run]launches the installed GUI once after successful interactive install/update using original (non-elevated) user.skipifsilentprevents Session 0 audio activation during enterprise installs / CI.project(ARMixConsole VERSION ...)rather than stale0.1.0-rc.1hardcode. Distribute builds as ArSonMix Windows Preview, notUNQUALIFIED; preserve separate exact-source-SHA integrity verification and distinct owner physical listening evidence (not a fabricated all-hardware certificate).INSTALLER_HANDSHAKE_SAVEDgraceful shutdown, source SHA-256 EXE restored, user files retained, followed by real uninstall preserving Studio. Never ships the test fixture.CI
PR quick Windows-native contract gate first. Then one owner-authorized exact-commit
/arsonmix-ci fat HEAD_SHAmilestone (Windows compiler + Inno real installer/update/uninstall), no redundant Windows jobs on every PR commit. This is software/installer FAT, not physical ASIO certification.Product behavior
A normal user double-clicks the installer, the in-use mixer is requested to save and close normally, new version is placed in the same location, and the new mixer opens once automatically. If Windows cannot close the old mixer safely, setup must stop rather than silently discard live edits.
Cross-thread reconciliation
PR #445 restores retained mixer channels/WIRE/FX on verified device Apply; its safety regression requires
NEEDS_REMAPinstead of silently migrating MAIN physical 3/4 to 1/2. #443 installer changesConsoleAppshutdown; #445 device changesConsoleWindowand binding policy. Both must be integrated without reverting either, followed by exact-head Windows native + Inno qualification. See the latest cross-thread checkpoint in PR comments.Exact Windows failure regression
Isolated Windows Inno run #42421982731 PASS: (1) handshake-enabled running mixer saves/quits and updates, (2) legacy old GUI without handshake receives
WM_CLOSE_SAVEDand updates in place, (3) unresponsive EXE without a responsive window remains running; Setup exits 7 before file replacement, preserving installed EXE SHA and Studio user sentinel. Exact-source Windows MSVC + Inno FAT in progress. Real user reportedDeleteFile failed; code 5on%LOCALAPPDATA%\\Programs\\ArSonMix\\ArSonMix.exe; existing released installer did not own the legacy-close path.