Skip to content

FactoryFX 4: optimized EQ/Comp/Verb/KuPik intake, atomic bundle and verified fast startup - #446

Merged
masarray merged 16 commits into
mainfrom
feat/factoryfx-four-vst3-atomic-intake-20261108
Nov 7, 2026
Merged

masarray merged 16 commits into
mainfrom
feat/factoryfx-four-vst3-atomic-intake-20261108

Conversation

@masarray

@masarray masarray commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Product contract — mixer first, FactoryFX bonus optional

ArSonMix is always a fully functional native mixer with its existing built-in Parametric EQ, without any external VST3. First-party ArSonEQ, ArSonComp, ArSonVerb and ArSonKuPik are optional included bonuses. An unavailable/invalid bonus must never block the core mixer, native FX, user VST3 import, Windows installation or future ArSonMix releases.

Implemented on this PR

  • Four upstream Windows-x64 VST3 candidate sources observed (ArSonKuPik VST from vst-enhancer, not Chrome extension); prerelease metadata allowed only for candidate discovery, not automatic approval.
  • Immutable approved release lock and strict actual VST3 provenance, legal review, entitlement and JUCE host UID checks remain binding. No guessed FUID/UID, no license bypass.
  • Transactional FactoryFX staging: --best-effort keeps every independently downloadable, hash-verified, approved plugin; skips only the broken bonus and records FACTORYFX_STAGE_REPORT.json. A clean no-extra mixer package is also valid. Explicit --require factory|four|six remains strict and incompatible with --best-effort.
  • Independent post-package archive verification validates the actual selected subset against the approved lock, including per-file hashes and no extra FactoryFX files. Stage reports are verified and included in the Windows distribution.
  • Native JUCE worker may quarantine one broken optional Factory VST3 while preserving other independently validated FX. Strict registry mode retains all-or-nothing manifest gate for quality/release tests. Verified plugin metadata cache is only read after hash validation, and is never authoritative.
  • Existing built-in EQ, PCM graph, ASIO callback, user Vault, canonical /preview/ GUI and native Show are unchanged.

Evidence / boundaries

  • Fast PR checks at c7612669fe5f3328915e4457d9fbf3ea62582dde: Node 139/139 and Python FactoryFX 16/16 PASS from run 42425752191. Includes optional skip, zero-available, rollback and tampered-stage-report cases.
  • Previous native exact-head milestone on earlier c2dfeb3 FAIL due verifiedFactory referenced outside its persistence scope. The undefined reference is fixed at current head; a fresh exact-head native milestone was requested to verify MSVC and CTest. Do NOT borrow previous binary qualification.
  • config/factoryfx-approved-releases.json is still empty. None of the four upstream binaries is legally and native-host-qualified for the official ArSonMix Factory lock in this PR; NO SHIPPED VST3 bonus is claimed yet. Native built-in EQ remains part of the executable. Real ASIO FAT remains PENDING.
  • Separate Windows host + entitlement qualification can promote each individually approved VST3 into the lock without delaying other ArSonMix development.

Cross-thread

Based on merged main; supersedes old Comp-only #225 watcher work. Does not overwrite installer #443, device #445, native routing or approved /preview/ appearance. Reconcile latest main before merge; no dual host, static DSP fork, plugin-license patch or unqualified production claims.

masarray commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native c2dfeb3

masarray commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native c761266

@masarray
masarray marked this pull request as ready for review November 7, 2026 23:44
@masarray
masarray merged commit 1b0f899 into main Nov 7, 2026
5 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T23:46:02.967855Z c761266 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7612669fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/PluginCatalog.h
Comment on lines +454 to +455
verifiedFactory.add (entry.toVar());
continue;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Serialize the verified FactoryFX cache before writing the catalog

When approved FactoryFX plugins are installed, save() fills verifiedFactory but never attaches it to the JSON object written to plugin-catalog.json. The new scanner reads the verifiedFactory property from that file, so subsequent launches always miss the cache and repeat findAllTypesForFile for every bundled plugin. Persist the array under the property the reader expects so the startup optimization actually takes effect.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant