Repository navigation
FactoryFX 4: optimized EQ/Comp/Verb/KuPik intake, atomic bundle and verified fast startup - #446
Conversation
…including pre-releases
…ked production release gate
…c failure and production contract
…production manifest
…inal binaries off realtime thread
|
/arsonmix-ci native c2dfeb3 |
…core mixer on missing assets
…che private to persistence
|
/arsonmix-ci native c761266 |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7612669fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| verifiedFactory.add (entry.toVar()); | ||
| continue; |
There was a problem hiding this comment.
Serialize the verified FactoryFX cache before writing the catalog
When approved FactoryFX plugins are installed, save() fills verifiedFactory but never attaches it to the JSON object written to plugin-catalog.json. The new scanner reads the verifiedFactory property from that file, so subsequent launches always miss the cache and repeat findAllTypesForFile for every bundled plugin. Persist the array under the property the reader expects so the startup optimization actually takes effect.
Useful? React with 👍 / 👎.
Product contract — mixer first, FactoryFX bonus optional
ArSonMix is always a fully functional native mixer with its existing built-in Parametric EQ, without any external VST3. First-party ArSonEQ, ArSonComp, ArSonVerb and ArSonKuPik are optional included bonuses. An unavailable/invalid bonus must never block the core mixer, native FX, user VST3 import, Windows installation or future ArSonMix releases.
Implemented on this PR
--best-effortkeeps every independently downloadable, hash-verified, approved plugin; skips only the broken bonus and recordsFACTORYFX_STAGE_REPORT.json. A clean no-extra mixer package is also valid. Explicit--require factory|four|sixremains strict and incompatible with--best-effort./preview/GUI and native Show are unchanged.Evidence / boundaries
c7612669fe5f3328915e4457d9fbf3ea62582dde: Node 139/139 and Python FactoryFX 16/16 PASS from run 42425752191. Includes optional skip, zero-available, rollback and tampered-stage-report cases.c2dfeb3FAIL dueverifiedFactoryreferenced outside its persistence scope. The undefined reference is fixed at current head; a fresh exact-head native milestone was requested to verify MSVC and CTest. Do NOT borrow previous binary qualification.config/factoryfx-approved-releases.jsonis still empty. None of the four upstream binaries is legally and native-host-qualified for the official ArSonMix Factory lock in this PR; NO SHIPPED VST3 bonus is claimed yet. Native built-in EQ remains part of the executable. Real ASIO FAT remains PENDING.Cross-thread
Based on merged main; supersedes old Comp-only #225 watcher work. Does not overwrite installer #443, device #445, native routing or approved /preview/ appearance. Reconcile latest main before merge; no dual host, static DSP fork, plugin-license patch or unqualified production claims.