Skip to content

FactoryFX: integrate ArSonComp as fourth release-watched VST3 with native-safe packaging gates - #225

Closed
masarray wants to merge 8 commits into
mainfrom
feat/factoryfx-arsoncomp-fourth-sibling-20261031
Closed

masarray wants to merge 8 commits into
mainfrom
feat/factoryfx-arsoncomp-fourth-sibling-20261031

Conversation

@masarray

Copy link
Copy Markdown
Owner

FactoryFX #4: ArSonComp now part of the cross-repo release intake

Source verified: masarray/arson-comp feat/zero-latency-compressor@80a41f52 (draft PR #1), original C++17 compressor DSP, JUCE 8 VST3/Standalone, automated Windows/Linux run 41156358804 SUCCESS. Current public main@57ad06ba has no production source and there is no GitHub Release. Do not treat the engineering CI artifact as an approved factory binary.

This extends merged factory release intake PR #210, without changing the native mixer engine or GUI:

  • The Linux lightweight scheduled/manual upstream watcher now covers four actual sibling suppliers: ArSonEQ, ArSonComp, ArSonVerb, ArSonKuPik Enhancer. Release detection opens a metadata-review PR; no binary downloads or expensive JUCE builds.
  • The verified Windows VST3 ZIP unpacker handles ArSonComp's actual Plugin/ArSonComp.vst3 layout as well as canonical VST3/ArSonComp.vst3. It isolates complete x64 VST3 contents while never copying the adjacent Standalone EXE or unrelated assets. Locked source repo, SHA256 ZIP, per-file hashes, approved redistribution/legal notice, exact VST3 class ID/JUCE host UID and real host qualification remain required.
  • Offline integration tests now cover real Comp CI archive layout, standalone exclusion, duplicate/conflicting roots, four-source watcher ordering, Comp release candidate discovery and existing fail-closed tests.
  • PRD, AGENTS and cross-thread FactoryFX handoff reconcile Comp as implemented source but unshipped public Factory VST3; six-plugin product target unchanged (Harmony and Color later).

Not claimed: Comp is not automatically loadable from this PR; actual Windows-x64-VST3 GitHub Release, legal/source provenance, native host UID/CID/sidechain/Show/FAT must be approved in config/factoryfx-approved-releases.json before its binary is included. Current reviewed lock stays empty, no fake FACTORY installed cards. #15 zero-FX physical hardware gate remains open.

CI: only the normal existing Windows native test/packaging workflow (plus fast offline FactoryFX tests) is needed, no duplicate workflow. Preserve ongoing Audio I/O PRs #222/#224 untouched.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T02:47:07.137375Z 12ed338 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Reconciliation: old CI-green PR could NOT merge into newer main (GitHub 405 conflict). Replacement PR #229 now selectively carries all seven distinct ArSonComp fourth-sibling FactoryFX watcher/stager/tests/docs files directly on main@44376031, adds canonical PR disposition ledger and PREPENDS the latest AGENTS rather than overwriting #224/#227 native directions. This PR stays draft and MUST NOT be force-squashed or independently merged; close as superseded once the replacement PR's exact integrated CI/merge is confirmed. Original branch and PR remain recoverable evidence. Four sibling source repositories are real, reviewed FactoryFX binary approval lock still EMPTY.

masarray commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

ArSonComp upstream release status correction (2026-11-01)

The PR description's original assertion that ArSonComp has no public release is now historical. ArSonComp v0.2.0 Stable is published with Windows Inno Setup, Linux and macOS installers; the verified binary source is 0a039ef6d340e26aa01a62df3670f74da1f03a12 and stable promotion CI #41286912535 passed.

This changes discovery eligibility, not FactoryFX approval. The published Windows .exe is an installer, not the required attested VST3-only ZIP. Do not mark ArSonComp Factory FX as loadable until the Windows-only asset/manifest, real VST3 class ID + JUCE UID, legal notices, host FAT and immutable factory registry entry all pass. ArSonMix epic #185 handoff.

masarray commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

Superseded by merged PR #446 (main 1b0f899c7fcf5fd62dbebeab3ccb9115b5929bb5), which integrates the four-product EQ/Comp/Verb/KuPik watcher, Comp ZIP support, strict qualification, optional per-module bundle staging, and runtime corruption isolation on current mixer main. Closing this stale pre-integration Comp-only patch avoids replaying old code. Future real binaries require individual verified promotion; none is implicitly approved.

@masarray masarray closed this Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant