Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/factoryfx-release-watch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
commit-message: 'chore(factoryfx): record latest upstream release candidates'
branch: bot/factoryfx-release-candidates
delete-branch: true
title: 'FactoryFX: review new EQ/Verb/Enhancer releases (metadata only)'
title: 'FactoryFX: review new EQ/Comp/Verb/Enhancer releases (metadata only)'
body: |
Upstream release discovery only. NO plugin is qualified, downloaded,
licensed, shipped or enabled by this PR.
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
> **M1 LIVE AUX POST FADER (2026-10-31):** [Native implementation & FAT contract](docs/M1_LIVE_AUX_SEND_FADER_20261031.md). Ordinary gain on an EXISTING native CH→AUX POST edge is a realtime atomic target with callback-only <=64-sample smoothing. Control write via `routingAuxSendGain` is fenced by actual device epoch, published routing revision, existing edge, 0..1 value and native ACK. It does NOT MUTE outputs, recompile topology, detach, instantiate plugins or change MAIN fader. New send/return enable, PRE/PAN and physical I/O remain structural DRAFT→MUTE→APPLY→native ACK. No fake dynamic CH11, Master FX or hardware crackle certification. Preserve source and standalone mixer-io JS parity, L2/RAIL3, DYN1B, OUTPUT1, factory lock and P0 hardware #15.
> **ARSONCOMP FOURTH FACTORYFX SIBLING — VERIFIED 2026-10-31:** ArSonComp source is real at `masarray/arson-comp` PR #1 feature commit `80a41f52` (CI #41156358804 SUCCESS); default `main` only holds README/LICENSE and NO GitHub Release yet. Original compressor DSP + VST3/Standalone exist, but no public FactoryFX binary has qualified. Keep Comp among the first **four** bundled Factory products EQ/Comp/Verb/KuPik; never rebuild DSP in ArSonMix. The low-cost release watcher now checks `masarray/arson-comp`; staging accepts actual Comp CI `Plugin/ArSonComp.vst3` layout in addition to `VST3/<bundle>`, strictly excluding Standalone executables. Preserve immutable approval lock, full Windows artifact SHA, true JUCE VST3 UID/class ID, AGPL/JUCE/legal notices, host/Show/sidechain/FAT gates, and one native realtime graph. Read [FactoryFX handoff](docs/FACTORYFX_RELEASE_INTAKE_20261031.md) for evidence and outstanding release work; empty approved lock means NOT shipped.\n\n> **M1 LIVE AUX POST FADER (2026-10-31):** [Native implementation & FAT contract](docs/M1_LIVE_AUX_SEND_FADER_20261031.md). Ordinary gain on an EXISTING native CH→AUX POST edge is a realtime atomic target with callback-only <=64-sample smoothing. Control write via `routingAuxSendGain` is fenced by actual device epoch, published routing revision, existing edge, 0..1 value and native ACK. It does NOT MUTE outputs, recompile topology, detach, instantiate plugins or change MAIN fader. New send/return enable, PRE/PAN and physical I/O remain structural DRAFT→MUTE→APPLY→native ACK. No fake dynamic CH11, Master FX or hardware crackle certification. Preserve source and standalone mixer-io JS parity, L2/RAIL3, DYN1B, OUTPUT1, factory lock and P0 hardware #15.

> **SINGLE SOURCE OF PRODUCT TRUTH / ALL ARSONMIX THREADS — 2026-10-31:** Read [cross-thread operator/engine/release reset](docs/PRODUCT_TRUTH_CROSS_THREAD_20261031.md) **FIRST**. Core promise: one realtime digital MIXER (not DAW/OBS-only), operator SOURCE→FX→SEND→BUS→OUTPUT workflow, continuous live parameters distinct from guarded structural changes, only native ACK makes a draft LIVE. PATCH2 and MS5 share ONE route controller; no forced global MUTE/APPLY for realtime send gain once safely implemented. Current delivered sound still 10CH+4AUX; DYN1B is offline; physical 0FX #15 unresolved; FactoryFX approval lock EMPTY. Read status table and M0/M1/M2 acceptance gates there; older dated AGENTS paragraphs are historical if conflicting. Preserve one JUCE graph, L2/RAIL3, MS3B/OUTPUT1, VST/editor/Show and actual hardware IDs.

Expand Down
7 changes: 7 additions & 0 deletions config/factoryfx-upstream-candidates.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@
"publishedAt": null,
"windowsVst3Asset": null
},
{
"productId": "arson-comp",
"distributionRepo": "masarray/arson-comp",
"releaseTag": null,
"publishedAt": null,
"windowsVst3Asset": null
},
{
"productId": "arson-verb",
"distributionRepo": "masarray/arsonverb",
Expand Down
34 changes: 33 additions & 1 deletion docs/FACTORYFX_RELEASE_INTAKE_20261031.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Owners: issue #185, canonical ADR `ADR_FACTORY_FX_BUNDLE_20261030.md` and PRD `P

## Product behavior, without another DSP host
ArSonMix is a LIVE Windows ASIO/WASAPI VST3 mixer, not an audio editor.
Keep `ArSonEQ`, `ArSonVerb` and `ArSonKuPik Enhancer` as separately
Keep `ArSonEQ`, `ArSonComp`, `ArSonVerb` and `ArSonKuPik Enhancer` as separately
built/signed-or-attested VST3 packages from their own repositories. FXF2
does not fork algorithms, copy JUCE9 into JUCE8, create a parallel audio
callback, add Web Audio effects or replace L2 / all-channel FX Rack.
Expand Down Expand Up @@ -104,3 +104,35 @@ factory entry as actually installed with working DSP. Application
portable/install parity, CH1–N multi-insert/bypass, Save/Recall, plugin
latency/PDC, real ASIO/WASAPI audio, CPU and cold GUI tests must pass.
Do not mark upstream candidate PR merged as a factory release shipped.

## 2026-10-31 ArSonComp fourth sibling reconciliation (supersedes older Comp readiness snapshot)
- Public source repository: `masarray/arson-comp`. As verified on 2026-10-31,
`main@57ad06ba` still has README/LICENSE only. Real DSP and JUCE VST3
code is on PR #1 `feat/zero-latency-compressor@80a41f52`, CI Windows/Linux
`41156358804` SUCCESS. It is an engineering artifact, NOT a public release;
no GitHub Releases exist yet. Do not attempt to build Comp from `main`.
- The sibling targets Windows x64 JUCE8 VST3 + standalone, manufacturer
`ArSn`, plugin `ArCp`, product `ArSonComp`, version `0.1.0`.
Current CI uploads a complete `Plugin/ArSonComp.vst3` with a separate
`Standalone/ArSonComp.exe`. The *official approved public* release must
provide an exact SHA-qualified `...Windows-x64-VST3.zip`, stable actual
VST3 CID, exact ArSonMix JUCE host UID, appropriate AGPL/JUCE notices and
an unambiguous code/release build provenance. The packager now supports
both `Plugin/<bundle>` (ArSonComp CI layout) and `VST3/<bundle>` but
extracts ONLY `<bundle>.vst3`, never a Standalone EXE. Wrong roots,
duplicate VST3 resources and unreviewed binaries fail closed.
- Automatic upstream watcher includes the FOUR sibling distributions
(`arson-eq`, `arson-comp`, `arsonverb`, `vst-enhancer`). A new Comp
release appears as *review candidate*, not automatically activated.
`config/factoryfx-approved-releases.json` remains EMPTY until every
selected item passes source/release SHA, licence and runtime host gates.
- Release acceptance for Comp: true mono/stereo, actual VST3 host
discovery, 2+ instances, zero added plugin samples (NOT zero roundtrip
device latency), external sidechain where supported, parameter ID/state
migration, native bypass and mute-safe graph transaction. Run 44.1/48/96
kHz / actual buffer sizes, Save/Recall Show, real Windows audio/hardware,
CPU, idle GUI lifecycle and pluginval or a second Windows host.
- All four Factory FX products must ultimately be bundled with ArSonMix
official portable ZIP/installer after qualification; the existing
Factory/My Plugins picker and native FX graph must be reused. No
hard-coded VST source branch checkout or unreviewed binary in the app.
14 changes: 13 additions & 1 deletion docs/PRD_FACTORY_FX_20261030.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,16 @@ FXF3 = atomic updates, Show migration, licensing robustness, measured low-spec G
The source code milestones MS1/G5A are merged but **not proof that Factory FX is packed**. Actual release proof requires exact source artifact SHA256, whole VST3 resources, host tests, legal approval, Windows ZIP and real hardware FAT. #15 crackle remains independent release blocker.

## 2026-10-31 executable release-intake addition
The binding release-intake/Windows package implementation is in [FactoryFX cross-repo release handoff](FACTORYFX_RELEASE_INTAKE_20261031.md). All new ArSonEQ/ArSonVerb/ArSonKuPik public releases are monitored by low-cost metadata PR; they become factory modules **only after** owner-approved licence/entitlement and SHA-pinned host qualification. This updates deployment mechanics, **not** the original six-plugin goal or any claim of bundled binaries. A release candidate is not an installed FactoryFX module.
The binding release-intake/Windows package implementation is in [FactoryFX cross-repo release handoff](FACTORYFX_RELEASE_INTAKE_20261031.md). All new ArSonEQ/ArSonComp/ArSonVerb/ArSonKuPik public releases are monitored by low-cost metadata PR; they become factory modules **only after** owner-approved licence/entitlement and SHA-pinned host qualification. This updates deployment mechanics, **not** the original six-plugin goal or any claim of bundled binaries. A release candidate is not an installed FactoryFX module.

## 2026-10-31 verified ArSonComp availability correction
The earlier audit line saying COMP has no verified sibling repository is
**superseded**. `masarray/arson-comp` contains implemented engine,
VST3/standalone, editor, automation, presets and tests on the
`feat/zero-latency-compressor` feature branch (PR #1). Windows/Linux
CI passed at `80a41f52`; no public GitHub Release or qualified ArSonMix
binary exists at this audit. The watcher and stage verifier therefore add
Comp as the FOURTH source without mislabeling the plugin installed.
The owner-approved six-plugin factory target and remaining release gates
are unchanged. Zero *plugin-added* sample delay is not zero total
host/device I/O latency.
4 changes: 2 additions & 2 deletions scripts/factoryfx_release_bundle.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def zip_members(z, bundle):
seen = set()
total = 0
for info in z.infolist():
# Ignore zip folder markers and unrelated top-level build metadata.
# Ignore zip folder markers and unrelated top-level build metadata.\n # Owned JUCE Windows packages use VST3/<bundle> or Plugin/<bundle>.
if info.is_dir():
continue
pp = PurePosixPath(info.filename)
Expand All @@ -121,7 +121,7 @@ def zip_members(z, bundle):
# Standalone EXEs and foreign plugins must never enter the factory.
continue
i = positions[0]
if i > 1 or (i == 1 and parts[0] not in ("VST3", "vst3")):
if i > 1 or (i == 1 and parts[0] not in ("VST3", "vst3", "Plugin")):
fail("unexpected VST3 archive root")
sub = parts[i + 1:]
if not sub:
Expand Down
1 change: 1 addition & 0 deletions scripts/factoryfx_upstream_watch.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

PRODUCTS = [
("arson-eq", "masarray/arson-eq"),
("arson-comp", "masarray/arson-comp"),
("arson-verb", "masarray/arsonverb"),
("arsonkupik-enhancer", "masarray/vst-enhancer"),
]
Expand Down
59 changes: 57 additions & 2 deletions scripts/tests/test_factoryfx_release_bundle.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,43 @@ def test_archive_rejects_traversal_duplicate_and_missing_module(self):
with zipfile.ZipFile(p) as z, self.assertRaises(ValueError):
bundle.zip_members(z, "ArSonEQ.vst3")

def test_arsoncomp_ci_layout_is_factory_vst3_only(self):
"""Real sibling CI uses Plugin/ArSonComp.vst3, not VST3/; no Standalone."""
(self.notices / "arson-comp.txt").write_text(
"Reviewed Comp redistribution fixture only", encoding="utf-8")
comp_zip = self.root / "comp.zip"
with zipfile.ZipFile(comp_zip, "w") as z:
z.writestr("Plugin/ArSonComp.vst3/Contents/x86_64-win/ArSonComp.vst3",
b"fake-comp-module")
z.writestr("Plugin/ArSonComp.vst3/Contents/Resources/moduleinfo.json",
b'{"name":"ArSonComp"}')
z.writestr("Standalone/ArSonComp.exe", b"this-must-never-ship")
comp = dict(self.approved, productId="arson-comp",
sourceRepo="masarray/arson-comp",
assetName="ArSonComp-Windows-x64-VST3.zip",
artifactSha256=hashlib.sha256(comp_zip.read_bytes()).hexdigest())
self.save_lock(comp)
with patch.object(bundle, "download_release",
side_effect=lambda _p, target: shutil.copyfile(comp_zip, target)):
bundle.stage(bundle.read_lock(self.lock), self.output, self.notices)
bundle.verify(bundle.read_lock(self.lock), self.output, self.notices)
root = self.output / "FactoryFX"
manifest = json.loads((root / "factoryfx-manifest.json").read_text())
self.assertEqual(manifest["plugins"][0]["productId"], "arson-comp")
self.assertEqual(manifest["plugins"][0]["category"], "COMP")
self.assertTrue((root / "ArSonComp/ArSonComp.vst3/Contents/x86_64-win/ArSonComp.vst3").is_file())
self.assertFalse((root / "Standalone").exists())
self.assertFalse(list(root.rglob("*.exe")))

def test_arsoncomp_rejects_mixed_duplicate_bundle_roots(self):
zip_path = self.root / "duplicate-comp.zip"
with zipfile.ZipFile(zip_path, "w") as z:
for root in ("Plugin", "VST3"):
z.writestr(f"{root}/ArSonComp.vst3/Contents/x86_64-win/ArSonComp.vst3",
b"duplicate module")
with zipfile.ZipFile(zip_path) as z, self.assertRaises(ValueError):
bundle.zip_members(z, "ArSonComp.vst3")

def test_extra_factory_file_is_rejected(self):
with patch.object(bundle, "download_release",
side_effect=lambda _p, target: shutil.copyfile(self.archive, target)):
Expand All @@ -116,9 +153,27 @@ def fake(repo):
assets=[{"name": "ArSonKuPik-v0.5.26-Windows-x64-VST3.zip"}])
return None
snapshot = watch.snapshot(fake)
self.assertEqual(len(snapshot["observed"]), 3)
self.assertEqual(len(snapshot["observed"]), 4)
self.assertEqual([x["productId"] for x in snapshot["observed"]],
["arson-eq", "arson-comp", "arson-verb", "arsonkupik-enhancer"])
self.assertIsNone(snapshot["observed"][0]["releaseTag"])
self.assertEqual(snapshot["observed"][2]["releaseTag"], "v0.5.26")
self.assertIsNone(snapshot["observed"][1]["releaseTag"])
self.assertEqual(snapshot["observed"][3]["releaseTag"], "v0.5.26")

def test_comp_published_release_is_detected_but_never_approved(self):
def fake(repo):
if repo == "masarray/arson-comp":
return dict(tag_name="v0.1.0", published_at="2026-10-31T00:00:00Z",
assets=[{"name": "ArSonComp-v0.1.0-Windows-x64-VST3.zip"},
{"name": "ArSonComp-v0.1.0-Windows-Standalone.zip"}])
return None
snapshot = watch.snapshot(fake)
row = snapshot["observed"][1]
self.assertEqual(row["productId"], "arson-comp")
self.assertEqual(row["windowsVst3Asset"], "ArSonComp-v0.1.0-Windows-x64-VST3.zip")
self.assertEqual(row["releaseTag"], "v0.1.0")
self.assertNotIn("approved", json.dumps(row))



if __name__ == "__main__":
Expand Down
Loading