You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
P0 Smart Inno Setup: graceful in-place upgrade, protect Studio and launch mixer - #444
Audit of main: CloseApplications=no, RestartApplications=no, no [Run]; an update with ArSonMix running may fail to replace the EXE, and the application never launches after interactive setup.
Implementation
Enable Windows Restart Manager (CloseApplications=yes) to request graceful shutdown of an existing ArSonMix process and release executable/plugin locks before file replacement. Never force-kill an audio session; JUCE ConsoleWindow shutdown saves the accepted .smix session and mutes output.
Avoid double launch: RestartApplications=no; one [Run] postinstall, checked by default on Finish, executes the newly installed ArSonMix under the original non-elevated user. Silent install / CI skips launch so there is no accidental hardware monitor activation.
Preserve the existing AppId / per-user install location and previous install settings, no uninstall-delete of Studio user data, and no portable marker.
Windows FAT installer script now performs clean install -> same-path upgrade -> SHA/provenance/data retention -> uninstall and validates private Studio remains present. Native contract covers graceful mixer close behavior.
No changes to native DSP, device output policy, Pages, or public GitHub Release.
Quality and limitations
Fast Node contract on every PR update. Full Inno 6 Windows compile + actual install/upgrade/uninstall requires an opt-in exact-SHA hardware-FAT workflow with package_fat=true (regular PR CI deliberately does not build ZIP/installer). Test physical running-session shutdown + ASIO reopen separately. Windows Restart Manager may show the native close-application UI if another process refuses closure; we intentionally do not kill it and lose unsaved audio edits.
Acceptance
Interactive install/upgrade works without manual uninstall, preserves %APPDATA%\\AR-MIX-Studio and .smix, offers the default launch at Finish. Silent scripted installations never start audio, and no duplicate obsolete instance is relaunched.
Reconciliation: superseded by existing PR #443 (fix/inno-smart-upgrade-graceful-launch-20261108). #443 already contains everything implemented here plus authoritative CMake installer version, compact single-launch wizard and a dedicated Windows Restart Manager running-process FAT. Do not merge this thinner parallel implementation into main or create another Inno authority. Fast native CI on #444 passed, but its exact-SHA Windows FAT is still running; it does not substitute for #443's failed real graceful-close marker gate. All future installer work remains on #443 and must fail closed until the running-process close/save signal is verifiably observed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0 Inno Setup — smart in-place update / first-run UX
Audit of
main:CloseApplications=no,RestartApplications=no, no[Run]; an update with ArSonMix running may fail to replace the EXE, and the application never launches after interactive setup.Implementation
CloseApplications=yes) to request graceful shutdown of an existing ArSonMix process and release executable/plugin locks before file replacement. Never force-kill an audio session; JUCEConsoleWindowshutdown saves the accepted.smixsession and mutes output.RestartApplications=no; one[Run]postinstall, checked by default on Finish, executes the newly installed ArSonMix under the original non-elevated user. Silent install / CI skips launch so there is no accidental hardware monitor activation.AppId/ per-user install location and previous install settings, no uninstall-delete of Studio user data, and no portable marker.Quality and limitations
Fast Node contract on every PR update. Full Inno 6 Windows compile + actual install/upgrade/uninstall requires an opt-in exact-SHA hardware-FAT workflow with
package_fat=true(regular PR CI deliberately does not build ZIP/installer). Test physical running-session shutdown + ASIO reopen separately. Windows Restart Manager may show the native close-application UI if another process refuses closure; we intentionally do not kill it and lose unsaved audio edits.Acceptance
Interactive install/upgrade works without manual uninstall, preserves
%APPDATA%\\AR-MIX-Studioand.smix, offers the default launch at Finish. Silent scripted installations never start audio, and no duplicate obsolete instance is relaunched.