Skip to content

P0 Smart Inno Setup: graceful in-place upgrade, protect Studio and launch mixer - #444

Closed
masarray wants to merge 3 commits into
mainfrom
fix/smart-inno-update-install-launch-20261108
Closed

masarray wants to merge 3 commits into
mainfrom
fix/smart-inno-update-install-launch-20261108

Conversation

@masarray

@masarray masarray commented Nov 7, 2026

Copy link
Copy Markdown
Owner

P0 Inno Setup — smart in-place update / first-run UX

Audit of main: CloseApplications=no, RestartApplications=no, no [Run]; an update with ArSonMix running may fail to replace the EXE, and the application never launches after interactive setup.

Implementation

  • Enable Windows Restart Manager (CloseApplications=yes) to request graceful shutdown of an existing ArSonMix process and release executable/plugin locks before file replacement. Never force-kill an audio session; JUCE ConsoleWindow shutdown saves the accepted .smix session and mutes output.
  • Avoid double launch: RestartApplications=no; one [Run] postinstall, checked by default on Finish, executes the newly installed ArSonMix under the original non-elevated user. Silent install / CI skips launch so there is no accidental hardware monitor activation.
  • Preserve the existing AppId / per-user install location and previous install settings, no uninstall-delete of Studio user data, and no portable marker.
  • Windows FAT installer script now performs clean install -> same-path upgrade -> SHA/provenance/data retention -> uninstall and validates private Studio remains present. Native contract covers graceful mixer close behavior.
  • No changes to native DSP, device output policy, Pages, or public GitHub Release.

Quality and limitations

Fast Node contract on every PR update. Full Inno 6 Windows compile + actual install/upgrade/uninstall requires an opt-in exact-SHA hardware-FAT workflow with package_fat=true (regular PR CI deliberately does not build ZIP/installer). Test physical running-session shutdown + ASIO reopen separately. Windows Restart Manager may show the native close-application UI if another process refuses closure; we intentionally do not kill it and lose unsaved audio edits.

Acceptance

Interactive install/upgrade works without manual uninstall, preserves %APPDATA%\\AR-MIX-Studio and .smix, offers the default launch at Finish. Silent scripted installations never start audio, and no duplicate obsolete instance is relaunched.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T20:38:07.981173Z 796b7e3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

masarray commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 796b7e3

masarray commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

Reconciliation: superseded by existing PR #443 (fix/inno-smart-upgrade-graceful-launch-20261108). #443 already contains everything implemented here plus authoritative CMake installer version, compact single-launch wizard and a dedicated Windows Restart Manager running-process FAT. Do not merge this thinner parallel implementation into main or create another Inno authority. Fast native CI on #444 passed, but its exact-SHA Windows FAT is still running; it does not substitute for #443's failed real graceful-close marker gate. All future installer work remains on #443 and must fail closed until the running-process close/save signal is verifiably observed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant