Repository navigation
Restore mixer audio and controls after device changes, and enable Add Audio Track - #445
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
/arsonmix-ci fat a909531 |
|
/arsonmix-ci ui a909531 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a909531f36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| outputs.monitorL=outputs.monitorR=-1; | ||
| outputs.monitorEnabled=false; | ||
| } | ||
| if(!outputs.valid())outputs={count,0,1,-1,-1,false}; |
There was a problem hiding this comment.
Require explicit MAIN remapping when selected output pins disappear
When Apply disables the currently assigned MAIN pins on the same device, this fallback silently assigns MAIN to the first two remaining outputs. For example, a session using physical outputs 3/4 with mask f becomes routed to physical outputs 1/2 after applying mask 3. Previously, the exact-binding check rejected that changed mapping; the new verifiedDeviceApply path accepts and publishes it through finishAudioSetupAndRecoverMixer(true). MAIN remains muted initially, but subsequently enabling monitoring sends audio to connectors the operator never selected as MAIN. Return NEEDS_REMAP when the saved MAIN pair cannot be preserved, and require an explicit physical-output selection instead of substituting another pair. This also violates the explicit prohibition on silent output rerouting in AGENTS.md.
AGENTS.md reference: AGENTS.md:L67-L68
Useful? React with 👍 / 👎.
… rerouting after Audio I/O Apply
…ng more than one stereo pair
Cross-thread reconciliation — audio device Apply vs smart Inno Setup (8 Nov 2026)This native-device PR is the device-session/control recovery authority; separate #443 is the Inno setup/update + Preview-branded artifact authority. Both touch Critical #445 Codex P1 review finding (silent MAIN jack migration) addressed on current head
Do not merge without new exact-head native CTest. #443 installer head |
|
/arsonmix-ci native cddf25b |
|
/arsonmix-ci fat 8af626a |
|
/arsonmix-ci ui 8af626a |
Cross-thread P0 Inno upgrade failure and device-work preservation (8 Nov 2026)Actual Windows user error: Windows real install/upgrade smoke PASS: native-handshake fixture; legacy no-handshake GUI + Reconciliation: PR #443 only changes |
|
/arsonmix-ci fat 656c7a5 |
Integration handoff: smart installer PR #443 now merged into mainMain merge: Your device/session PR #445 remains independently open at head No merging of #445 was attempted here; coordinate its own latest tests/approval in the device thread. |
|
/arsonmix-ci ui c56831a |
|
/arsonmix-ci fat 4c55c80 |
|
/arsonmix-ci ui 4c55c80 |
Mixer
Checkpoint and verification
The Inno upgrade from Smart Inno Setup: graceful in-place ArSonMix update, safe user data, automatic launch #443 is now in main and included in this PR history.
The combined checkpoint
656c7a5605038d9e39bf1a7b40453ff35eb3ed85passed Windows CI and dedicated Inno upgrade smoke. Its Preview installer precedes Add Audio Track. https://github.com/masarray/arsonmix/actions/runs/42423808235Add Audio Track passes the local native callback test from silent startup through input patch and PCM output, and all 296 Windows-lane Node contracts. Exact-head Windows MSVC and CTest (61/61), Chromium, and the validated Inno Preview installer passed. Physical audio FAT remains pending.
Latest Windows Inno Preview installer for
4c55c801bd2b52036c2255080118602292ffa46f: https://github.com/masarray/arsonmix/actions/runs/42425570062/artifacts/13596125118Exact-head browser qualification: https://github.com/masarray/arsonmix/actions/runs/42425587420