Repository navigation
Restore native mixer right-click: Delete Track and verified dearVR Orbit - #449
Conversation
…terface into approved WebView GUI
|
/arsonmix-ci native e127f75 |
|
/arsonmix-ci native c67d6cb |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c67d6cb0c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| nativeAccepted_.graph.roster=std::move(roster); | ||
| nativeAccepted_.graph.request=std::move(request); | ||
| nativeAccepted_.fxOwners=std::move(owner); | ||
| nativeAccepted_.pcmRevision=published.revision; |
There was a problem hiding this comment.
Keep mixer sessions serializable after deleting an original input
Deleting any of the original ten input channels removes it from the roster but leaves its ID in nativeAccepted_.graph.ids.inputs. captureNativeMixerSession() copies that unchanged mapping into draft.legacyIds, while NativeMixerSessionDocument.h:424 requires every legacy input ID to resolve to an existing input. Consequently, NativeMixerSessionStore::commit() rejects the edited mixer with “Mixer session graph cannot be serialized safely,” breaking subsequent saves and autosaves. Reconcile the legacy-ID mapping and persistence validation when removing an original input, or reject that deletion until persistence supports it.
Useful? React with 👍 / 👎.
| if(orbit_.active()&&nativeOrbitChannelId_==idText&& | ||
| nativeOrbitInstanceId_==insertId)stopOrbit(); |
There was a problem hiding this comment.
Rebind the running Orbit target after moving its FX instance
If a running dearVR Orbit instance is moved to another channel through MOVE_INSERT, retainsFxEditor() retains its lease and the timer continues automating it, but nativeOrbitChannelId_ remains the source channel. Inspecting Orbit at the destination therefore reports active: false, disabling Stop, and a destination Stop request also fails this channel-ID check. Rebind the running Orbit channel and slot from its retained instance lease after rack edits so the moved instance remains controllable.
AGENTS.md reference: AGENTS.md:L152-L152
Useful? React with 👍 / 👎.
Scope
Restore app-owned context menu in the approved native /preview/ WebView2 (not the deprecated web/index UI): right-click header → guarded Delete Track; right-click installed native dearVR PRO 2 FX → Orbit. Chromium browser menu suppressed only inside authenticated native host; public Pages HTML stays byte-identical.
Native correctness
Tests