Skip to content

Restore native mixer right-click: Delete Track and verified dearVR Orbit - #449

Merged
masarray merged 11 commits into
mainfrom
fix/native-track-context-orbit-20261108
Nov 8, 2026
Merged

masarray merged 11 commits into
mainfrom
fix/native-track-context-orbit-20261108

Conversation

@masarray

@masarray masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Scope

Restore app-owned context menu in the approved native /preview/ WebView2 (not the deprecated web/index UI): right-click header → guarded Delete Track; right-click installed native dearVR PRO 2 FX → Orbit. Chromium browser menu suppressed only inside authenticated native host; public Pages HTML stays byte-identical.

Native correctness

  • Exact ChannelId and admitted epoch/graph/roster revision required.
  • Delete Track is one control-thread prepared PCM publish, including source patch, incoming/outgoing WIRE cleanup, native VST3 lease cleanup; unrelated channel IDs/FX/MUTE/WIRE unaffected.
  • No fake JS remove; deletion is surfaced after matching ACK and subsequent accepted readback.
  • Orbit on real dearVR instance lease (not old legacy global slot); clean timer stop on plugin/channel removal, device change or Show rebind; no JS audio/control timer.
  • Add Audio Track from merged Restore mixer audio and controls after device changes, and enable Add Audio Track #445 left intact.

Tests

  • Added roster/PCM standalone regression.
  • Added GUI bundling and native M2 contracts; native UI separate script staged by canonical build.
  • Windows ASIO/WebView2 + dearVR VST3 interactive FAT remains necessary before treating as release-ready.

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native e127f75

masarray commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native c67d6cb

@masarray
masarray marked this pull request as ready for review November 8, 2026 01:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T01:38:26.907223Z c67d6cb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c67d6cb0c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/LiveDryRoutingLab.h
Comment on lines +1742 to +1745
nativeAccepted_.graph.roster=std::move(roster);
nativeAccepted_.graph.request=std::move(request);
nativeAccepted_.fxOwners=std::move(owner);
nativeAccepted_.pcmRevision=published.revision;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep mixer sessions serializable after deleting an original input

Deleting any of the original ten input channels removes it from the roster but leaves its ID in nativeAccepted_.graph.ids.inputs. captureNativeMixerSession() copies that unchanged mapping into draft.legacyIds, while NativeMixerSessionDocument.h:424 requires every legacy input ID to resolve to an existing input. Consequently, NativeMixerSessionStore::commit() rejects the edited mixer with “Mixer session graph cannot be serialized safely,” breaking subsequent saves and autosaves. Reconcile the legacy-ID mapping and persistence validation when removing an original input, or reject that deletion until persistence supports it.

Useful? React with 👍 / 👎.

Comment thread src/Main.cpp
Comment on lines +3038 to +3039
if(orbit_.active()&&nativeOrbitChannelId_==idText&&
nativeOrbitInstanceId_==insertId)stopOrbit();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Rebind the running Orbit target after moving its FX instance

If a running dearVR Orbit instance is moved to another channel through MOVE_INSERT, retainsFxEditor() retains its lease and the timer continues automating it, but nativeOrbitChannelId_ remains the source channel. Inspecting Orbit at the destination therefore reports active: false, disabling Stop, and a destination Stop request also fails this channel-ID check. Rebind the running Orbit channel and slot from its retained instance lease after rack edits so the moved instance remains controllable.

AGENTS.md reference: AGENTS.md:L152-L152

Useful? React with 👍 / 👎.

@masarray
masarray merged commit 30d7fa7 into main Nov 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant