Repository navigation
Restore native mixer right-click: Delete Track and verified dearVR Orbit #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
de67a33
Implement atomic native input-track deletion with safe wire and FX le…
masarray 7f897fa
Wire native right-click Delete Track and target-aware dearVR Orbit in…
masarray 441228c
Bind dearVR Orbit to acknowledged native ChannelId VST3 lease and ret…
masarray 58c34c3
Add deletion PCM roster regression and native GUI context/Orbit contr…
masarray 3bb1686
Keep native Orbit channel array alive through identity check
masarray b61f6e6
Parse native WebView context-menu JavaScript in fast CI contracts
masarray 5104d4a
Support dearVR Orbit on both authoritative M4 and ChannelId FX instances
masarray 649b4f3
Resolve Orbit against exact verified M4 lane lease or native ChannelI…
masarray e127f75
Update Orbit dispatch test for dual verified M4 and ChannelId routing
masarray 159f656
Guard Orbit context and dialog against replacement at the same FX slot
masarray c67d6cb
Fix MSVC Windows SDK near/far macro collisions in native Orbit setpoints
masarray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting any of the original ten input channels removes it from the roster but leaves its ID in
nativeAccepted_.graph.ids.inputs.captureNativeMixerSession()copies that unchanged mapping intodraft.legacyIds, whileNativeMixerSessionDocument.h:424requires every legacy input ID to resolve to an existing input. Consequently,NativeMixerSessionStore::commit()rejects the edited mixer with “Mixer session graph cannot be serialized safely,” breaking subsequent saves and autosaves. Reconcile the legacy-ID mapping and persistence validation when removing an original input, or reject that deletion until persistence supports it.Useful? React with 👍 / 👎.