Repository navigation
P0 Native DAW: 10-channel physical IN, real M4 controls, compact Audio I/O (approved Windows GUI) - #416
P0 Native DAW: 10-channel physical IN, real M4 controls, compact Audio I/O (approved Windows GUI)#416masarray wants to merge 18 commits into
Conversation
…real per-channel JUCE source switching
…one live DAW hardware workflow
…/O workflow and no CH1-only menu
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad58d208ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // One hardware setup authority: the existing custom Audio I/O WebView | ||
| // (web/mixer-io.js). Never mount a second CH1-only Patch/Arm/Start menu: | ||
| // all ten mixer IN fields now use the same native route controller. |
There was a problem hiding this comment.
Wire hardware controls into the approved bundle before removing them
In the approved native Windows GUI, this removes the working device/patch/arm/mute controls without installing their replacement. I checked scripts/build_pages.py and scripts/build_approved_native_gui.py: the bundle uses site/preview-v2/index.html plus the approved bridge/contract, not web/mixer-io.js or web/monitor.js. Repository-wide searches also show that the approved HTML lacks the #mixer, .workbench, and .strip[data-strip] elements required by the new controller. Consequently, the native IN selectors still reach consumeField, which rejects them in G0, while users lose the existing hardware setup and output controls. Connect the replacement to the actual approved bundle before deleting the working path.
AGENTS.md reference: AGENTS.md:L16-L18
Useful? React with 👍 / 👎.
… DAW input-source runtime
…icate CH1 menu assertions
… use real M4 native PCM readback before ChannelId cutover
…to native M4 readback
…back without demo authority
…ors to native 10CH source router and MAIN monitoring
…elId graph admission
…g JUCE device APPLY/readback instead of generic setup wizard
…preview/ adapter now owns native per-strip routing
…hipped I/O modification
…han unshipped standalone module
…4 callback peaks, never demo data
…ping Windows bridge
…hannel M4 native callback ready
…ointer gesture fence
Addresses P0 workflow in #412.
Root cause confirmed (important correction)
The Windows EXE is NOT running the legacy standalone
web/mixer-io.jsorweb/monitor.js.scripts/build_approved_native_gui.pypackages the approvedsite/preview-v2/index.htmland injectsweb/approved-native-bridge.js. Thus earlier DAW routing work in the standalone modules was invisible to hardware users. This PR reverted the dead standalone change and wires the actual shipped WebView2 adapter instead.User-visible milestone — one DAW mixer
INdropdown on each of 10 channels is populated with the driver-reported physical enabled ports (mono/stereo), preserving explicit per-channel routing and the ten existing native channel lanes. Native identity maps via.strip[data-id], NOT the obsolete standalonedata-strip.routingSourceSwitchcarries epoch/revision and channel number, with authoritative source ACK and accepted route readback. Same-mode edits use existing native crossfade; topology changes while monitoring are muted internally then source-patched and monitor-restored only after positive ACKs. No second audio callback, JS DSP, fake PCM or duplicate graph.I · ON/OFFmonitoring control instead of visible Start/Arm steps.faderDb/pan/mute/soloand MAIN gain/mute setters. Connect approved controls to existingarMixParameterand reproject only genuinearMixStatus.dryRoutingLab.channelControlsand MAIN readback, even before full ChannelId admission. Preserve full native ChannelId projection when truly admitted.Safety and acceptance
web/mixer-io.jsis not authoritative in Windows; new tests specifically enforce the shipped bridge and no return to CH1-only menu.2026-11-08 reconciliation: ARCHIVED, NOT MERGED
Superseded pre-#418 alternative IN selector and Audio I/O proposal. Main now carries a newer single approved GUI and native hardware-source path. Do not restore old M4 controls or a second setup workflow; unresolved acceptance stays in #412.
Current approved authority: main, merged native integration #418. Existing branch history remains available; this closure is not evidence of physical audio FAT.