Skip to content

P0 Native DAW: 10-channel physical IN, real M4 controls, compact Audio I/O (approved Windows GUI) - #416

Closed
masarray wants to merge 18 commits into
mainfrom
integration/p0-daw-workflow-channel-input-20261105
Closed

masarray wants to merge 18 commits into
mainfrom
integration/p0-daw-workflow-channel-input-20261105

Conversation

@masarray

@masarray masarray commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Addresses P0 workflow in #412.

Root cause confirmed (important correction)

The Windows EXE is NOT running the legacy standalone web/mixer-io.js or web/monitor.js. scripts/build_approved_native_gui.py packages the approved site/preview-v2/index.html and injects web/approved-native-bridge.js. Thus earlier DAW routing work in the standalone modules was invisible to hardware users. This PR reverted the dead standalone change and wires the actual shipped WebView2 adapter instead.

User-visible milestone — one DAW mixer

  • Existing approved IN dropdown on each of 10 channels is populated with the driver-reported physical enabled ports (mono/stereo), preserving explicit per-channel routing and the ten existing native channel lanes. Native identity maps via .strip[data-id], NOT the obsolete standalone data-strip.
  • Select any physical source in any channel: native routingSourceSwitch carries epoch/revision and channel number, with authoritative source ACK and accepted route readback. Same-mode edits use existing native crossfade; topology changes while monitoring are muted internally then source-patched and monitor-restored only after positive ACKs. No second audio callback, JS DSP, fake PCM or duplicate graph.
  • Removes CH1-only More > Audio Setup / Patch CH1 / Arm output / Mute output wizard. Adds clear Audio I/O button in approved mixer, using the existing JUCE device inventory/Apply/rollback/ACK protocol. It distinguishes VB-Cable virtual output from audible speakers, leaves native JUCE generic setup available only under Advanced driver panel. Adds clear MAIN I · ON/OFF monitoring control instead of visible Start/Arm steps.
  • G0's already installed ten-channel M4 renderer has actual epoch-guarded native faderDb/pan/mute/solo and MAIN gain/mute setters. Connect approved controls to existing arMixParameter and reproject only genuine arMixStatus.dryRoutingLab.channelControls and MAIN readback, even before full ChannelId admission. Preserve full native ChannelId projection when truly admitted.
  • Source code, 10-channel native engine, vendor VST3, CSS/design skin, JUCE audio callback and buffer path are unchanged. The existing /preview/ GUI skin remains the single authorized renderer.

Safety and acceptance

  • Default output muted; no silently chosen source or unverified endpoint. Device switch and structural source edits enforce internal safe mute/ACK/epoch checks. Monitor button is deliberate; panic mute remains.
  • Per strip any selected active hardware pin → native ACK/readback → MAIN, real fader/pan/mute/solo with no separate Patch/Start wizard. Invalid/stale/unavailable hardware rejects and restores accepted readback.
  • Exact HEAD Windows JUCE/MSVC compile + native CTest, JS/UI regression, generated approved /preview/ bundle gate. Hardware audibility / 0FX crackle FAT P0 — Crackling with 0 VST3: diagnose WASAPI clock/input/output buffering before engine expansion #15 PENDING until physical test; CI alone not proof.
  • Standalone web/mixer-io.js is not authoritative in Windows; new tests specifically enforce the shipped bridge and no return to CH1-only menu.

2026-11-08 reconciliation: ARCHIVED, NOT MERGED

Superseded pre-#418 alternative IN selector and Audio I/O proposal. Main now carries a newer single approved GUI and native hardware-source path. Do not restore old M4 controls or a second setup workflow; unresolved acceptance stays in #412.

Current approved authority: main, merged native integration #418. Existing branch history remains available; this closure is not evidence of physical audio FAT.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T06:50:50.805803Z ad58d20 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad58d208ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +148 to +150
// One hardware setup authority: the existing custom Audio I/O WebView
// (web/mixer-io.js). Never mount a second CH1-only Patch/Arm/Start menu:
// all ten mixer IN fields now use the same native route controller.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Wire hardware controls into the approved bundle before removing them

In the approved native Windows GUI, this removes the working device/patch/arm/mute controls without installing their replacement. I checked scripts/build_pages.py and scripts/build_approved_native_gui.py: the bundle uses site/preview-v2/index.html plus the approved bridge/contract, not web/mixer-io.js or web/monitor.js. Repository-wide searches also show that the approved HTML lacks the #mixer, .workbench, and .strip[data-strip] elements required by the new controller. Consequently, the native IN selectors still reach consumeField, which rejects them in G0, while users lose the existing hardware setup and output controls. Connect the replacement to the actual approved bundle before deleting the working path.

AGENTS.md reference: AGENTS.md:L16-L18

Useful? React with 👍 / 👎.

@masarray masarray changed the title P0 DAW workflow: route any mixer IN directly to verified hardware, remove CH1-only Patch/Arm UI P0 Native DAW: 10-channel physical IN, real M4 controls, compact Audio I/O (approved Windows GUI) Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant