Skip to content

Publish current approved ArSonMix GUI to /preview/ without promoting P0 native engine - #440

Merged
masarray merged 19 commits into
mainfrom
fix/publish-current-preview-gui-20261107
Nov 7, 2026
Merged

masarray merged 19 commits into
mainfrom
fix/publish-current-preview-gui-20261107

Conversation

@masarray

@masarray masarray commented Nov 7, 2026

Copy link
Copy Markdown
Owner

Root cause

GitHub Pages publishes only main; merged native/gui PR #438 -> #418 cannot affect public /preview/ while #418 remains P0 draft.

GUI-only reconciliation

Transplant only latest reviewed Pages composition inputs from #418: body-fixed zero-reflow Channel Editor, handle-free FX row drag, FX rack power state, operator controls/PEQ demo, CSS owner, canonical wire model, Pages assembler and exact-publication checks. No C++/JUCE engine or native routing revision is promoted. Keep ONE public /preview/; source V28 HTML remains immutable. Native source authority stays in #418.

Quality gates

  • Fast main UI contract verifies source owner and newly added operator composition test.
  • On main push, full real Chromium validates five viewport editor zero reflow, handle-free FX drag, and rack bypass before the protected workflow_run Pages publisher deploys exact qualified main SHA.
  • PR quick CI before merge; physical ASIO remains separate Fix cold WIRE admission and native VST3 picker/editor with prepared graph PDC #418 acceptance; public site is demo with live_audio: false.

Issue addressed: latest merged GUI changes were not visible at GitHub Pages because main/scripts/build_pages.py had no operator/FX composer.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T12:46:03.167629Z 9b2b522 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit f304a6a into main Nov 7, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b2b52253f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/approved_operator_ux_smoke.py Outdated
Comment on lines +73 to +74
self.assertIn("openChannelIdentity,closeChannelIdentity",build)
self.assertIn("?.applyIdentity?.())return;",build)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove assertions that require unpromoted native changes

The new fast UI test requires native implementation changes that this GUI-only commit deliberately does not include. Running python -m unittest discover -s tests -p approved_operator_ux_smoke.py -v fails at this assertion because scripts/build_approved_native_gui.py does not contain openChannelIdentity,closeChannelIdentity. Since .github/workflows/ui-smoke.yml now runs this suite unconditionally in quick, relevant PR and main checks fail, and the dependent Chromium qualification cannot run. Scope these assertions to code included in this change rather than requiring the separate native integration.

Useful? React with 👍 / 👎.

Comment on lines +13 to +15
html=html[:start]+'''function paintMainWireFragment(strip,edge,isMain){
strip?.querySelectorAll('.wire-main-fragment').forEach(layer=>layer.remove());
}'''+html[end:]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve MAIN fragments when the selected WIRE is expanded

When an operator expands WIRE for a channel connected to MAIN, this replacement removes every fragment instead of painting the selected channel's accepted edge and its MAIN endpoint. Repository-wide search finds no replacement renderer: syncMainWireFragments() still delegates to this function. This also contradicts the existing assertions in tests/pages_wire_first_canonical_main_smoke.py, which the full UI workflow still runs. Retain the focused expanded-state rendering and suppress fragments only in the collapsed or unfocused states required by AGENTS.md.

AGENTS.md reference: AGENTS.md:L134-L134

Useful? React with 👍 / 👎.

Comment on lines +357 to +358
}else if(!native()){
mode="DEMO";bands=(demos.get(track.id+":"+slot)||fresh()).map(b=>({...b}));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Key preview EQ settings by insert identity rather than slot

In the public browser preview, edit a Parametric EQ, close its editor, and move that insert to another slot or channel using the new rack gestures. Reopening it reads settings from the destination's track.id + ':' + slot, so the edited curve resets or becomes another EQ's settings. The move helpers transfer fx, slotBypass, and fxInsertIds but never transfer this separate demos map; removing and reinserting an EQ also resurrects the old slot's settings. Store the preview parameters under the stable insert identity so they follow the effect rather than its former position.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant