Skip to content

Unblock latest /preview/ deployment: preserve context-aware CSS ownership guard - #441

Merged
masarray merged 2 commits into
mainfrom
fix/public-pages-css-ownership-gate-20261107
Nov 7, 2026
Merged

masarray merged 2 commits into
mainfrom
fix/public-pages-css-ownership-gate-20261107

Conversation

@masarray

@masarray masarray commented Nov 7, 2026

Copy link
Copy Markdown
Owner

Follow-up to merged GUI-only #440. Exact main Chromium failed in scripts/check_preview_css_ownership.py because its old raw counter flags mixer-fx-rack.css after intentional approved FX drag composition. Bring the already-tested context-aware CSS declaration checker and nonregression tests from integrated #418. Keeps upper-bound overlap gates; does not waive CSS safety. Should restore Chromium -> Pages workflow_run deployment path. No native C++ promotion.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T12:50:58.336010Z 0163836 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit 2daa2f1 into main Nov 7, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01638369d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +81 to +82
return {name: same_context_repeat_count(source_path(name).read_text(encoding="utf-8"))
for name in names}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Recalculate repetition caps for the context-aware counter

Switching counters without recalculating sameFileRepeatedDeclarationCaps gives existing stylesheets headroom for new unconditional duplicates, weakening the non-regression gate this script enforces. For example, mixer-console-foundation.css now counts 0 repetitions against its unchanged cap of 4; appending another :root{color-scheme:dark;} makes verify() pass and report newSameOwnerStacking: 0, whereas the previous counter correctly rejected the increase from 4 to 5. Recalculate the per-file caps using the context-aware parser so distinguishing responsive contexts does not also permit new same-context stacking.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant