Repository navigation
Conversation
… via existing click-free fade
…isions without touching individual bypass
…elId native FX graph
…elId native FX graph
…elId native FX graph
…al native rack gate
… engine authority
…ative ACK/readback
…ative ACK/readback
…ative ACK/readback
…riting saved bypass
…e rack/insert state
…e rack/insert state
…s stored individual settings
…ation in Chromium
…euse and native append, rejects stale revision
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…ave power spinner hanging
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9f2f08e66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| row.rackBypassed=b.rackBypassed?b.rackBypassed: | ||
| std::make_shared<std::atomic<bool>>(false); // CONTROL allocation |
There was a problem hiding this comment.
Preserve rack bypass across native graph re-admission
When an original channel/AUX rack is bypassed and the operator performs a structural channel repatch with outputs disarmed, LiveAudioEngine::repatchDryRoutingLabChannel() calls admitChannelIdFromAcceptedM4(), which rebuilds the bank through UnifiedLegacyProductionAdmission::compileAndCommit(). That path obtains every assignment from captureLegacy(), which never populates rackBypassed, so this fallback initializes every rack to ON. Native rack commands update only the accepted bank, leaving no corresponding bypass state in the M4 graph to recover. Consequently, an unrelated routing edit silently re-enables previously bypassed effects when output resumes. Preserve the accepted rack gates through this re-admission path as well as through reuseRevision() and appendOwned().
AGENTS.md reference: AGENTS.md:L37-L37
Useful? React with 👍 / 👎.
… reconcile #419 Publish a single control-thread mixerSession choosing admitted ChannelId or verified M4, route 10CH controls through only its PCM authority, correlate per-parameter M4 ACK to subsequent independent producer readback, preserve physical MAIN gain/mute with native ChannelId, fail closed unsafe JS FX rack fan-out pending #421 atomic native gate. Transfer #419 mobile GUI source exact blobs from main; no DSP callbacks or alternate preview.
…418 Retain single production JUCE PCM engine and approved GUI. This unattached staging commit adds native rack overrides, real ChannelId lease readback, M4 callback bypass and host CSS semantics. Follow-up integration commit wires the existing #418 operator protocol and single mixerSession before publishing branch.
…ernel golden coverage Reconcile #418 native-only bridge with selected #421 per-rack atomic engine gate. Both M4 compatibility and ChannelId use exact accepted producer readback for rack ON/OFF without destroying individual slot states. Project legacy M4 scalars, physical source and wire only from mixerSession; add negative ACK/epoch gating, C++ mixerSession test, multi-channel native sample golden tests. Preserve one JUCE callback, public /preview/ visual design, and unmerged P1 #422. Physical FAT and complete gesture-to-PCM certification remain outstanding.
FX Rack master header power: parent bypass, preserve individual state
Requested operator semantics: when FX rack HEADER power is OFF, every occupied FX slot is effectively OFF and displays its power button OFF. HEADER ON restores the EXACT stored previous state for each insert (an individually OFF plugin stays OFF). Header is NOT a destructive mass toggle of the individual flags.
Architecture
fxOn(rack) +slotBypass[i](remembered individual); effective ON =fxOn && !slotBypass[i]. FX slot row and ARIA power now follow this effective state, not the stored individual flag.LiveChannelFxGraphand nativeDynamicChannelFxLeaseBank; the audio callback passes the OR of rack/master bypass and individual insert bypass into existing 8-ms wet/dry bypass envelope. No RT allocations, blocking, VST re-instantiation or direct editing of individual bypass preferences.bypassedflag; the GUI recomputes effective power and restores its display when header is re-enabled.Qualification
tests/approved_fx_rack_master_power_smoke.pyon actual built /preview/ at 390/1366/1680: add second FX, slot 1 OFF, slot 2 ON, header OFF → both power buttons OFF and all effective false; header ON → first stays OFF, second ON; plugin IDs and CH2 unchanged.Do not merge on failing CI; do not claim all rack state migrated into stable release without exact Windows qualification.
2026-11-08 reconciliation: ARCHIVED, NOT MERGED
FX header master bypass, independent per-slot remembered state and native rack bypass are present in current main with an approved GUI composer and native lease gate. This branch's old UI/engine change set is superseded by the integrated #418 lineage; do not replay duplicate ownership.
Current approved authority: main, merged native integration #418. Existing branch history remains available; this closure is not evidence of physical audio FAT.