Repository navigation
FX rack master power: bypass all effectively and restore each insert's last state (GUI + native engine) #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
14f57ea
engine(FX): additive rack bypass gate combines with per-insert bypass…
masarray f51c65c
engine(FX): retain native ChannelId master rack gate across graph rev…
masarray eb7e475
engine(FX): master rack bypass authoritative on prepared M4 and Chann…
masarray 6f03c3b
engine(FX): master rack bypass authoritative on prepared M4 and Chann…
masarray d9ccc6d
engine(FX): master rack bypass authoritative on prepared M4 and Chann…
masarray 2542a73
engine(FX): identify actual external CH1 lease before applying origin…
masarray 383a148
native(FX): ACK-fenced ChannelId rack/insert power requests with real…
masarray d9f5ca2
bridge(FX): show effective rack+slot state only after authoritative n…
masarray 116af0a
bridge(FX): show effective rack+slot state only after authoritative n…
masarray c3b8121
bridge(FX): show effective rack+slot state only after authoritative n…
masarray e852830
gui(FX): master OFF forces all insert power visuals OFF without overw…
masarray 3eba5cb
build(FX): same single assembler powers Pages and native from separat…
masarray 9116d80
build(FX): same single assembler powers Pages and native from separat…
masarray 7f98d63
engine(FX): preserve rack master gate when appending a new native VST…
masarray e171298
test(FX): prove header OFF shows all insert powers OFF and ON restore…
masarray 6c25c80
ci(FX): gate rack master/individual effective ON/OFF and state restor…
masarray e9f2f08
test(engine): rack power restores individual bypass, survives graph r…
masarray a66e4d5
native(FX): return explicit rejected ACK during Show/backup, never le…
masarray d2c990f
test(FX): assert native CH1 bypass envelope combines rack gate OR sto…
masarray b3d1570
test(FX): use approved channel bank when verifying isolation on mobil…
masarray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| """Approved single-GUI FX rack power semantics, injected at the ONE Pages build. | ||
|
|
||
| The historical V28 source HTML is immutable. Apply exactly TWO audited | ||
| semantic substitutions to its JavaScript when assembling both public /preview/ | ||
| and native JUCE WebView2. No additional stylesheet, second state store, or | ||
| private fork of the mixer. t.fxOn is rack authority, slotBypass[] is the | ||
| preserved per-insert preference. Effective = fxOn && !slotBypass[i]. | ||
| """ | ||
| def apply_authoritative_fx_power(html: str) -> str: | ||
| substitutions = [ | ||
| ( | ||
| "name==='None'?'is-empty':t.slotBypass[i]?'is-bypassed':'is-active'", | ||
| "name==='None'?'is-empty':(!t.fxOn||t.slotBypass[i])?'is-bypassed':'is-active'", | ||
| ), | ||
| ( | ||
| 'aria-pressed="\'+Boolean(!t.slotBypass[i])+\'">', | ||
| 'aria-pressed="\'+Boolean(t.fxOn&&!t.slotBypass[i])+\'">', | ||
| ), | ||
| ( | ||
| "title=\"'+(t.slotBypass[i]?'Enable':'Bypass')+' only insert", | ||
| "title=\"'+(!t.fxOn?'Rack bypassed, saved '+(t.slotBypass[i]?'OFF':'ON'):t.slotBypass[i]?'Enable':'Bypass')+' only insert", | ||
| ), | ||
| ( | ||
| "aria-label=\"'+(t.slotBypass[i]?'Enable':'Bypass')+' only FX insert", | ||
| "aria-label=\"'+(!t.fxOn?'Rack bypassed, saved '+(t.slotBypass[i]?'OFF':'ON'):t.slotBypass[i]?'Enable':'Bypass')+' only FX insert", | ||
| ), | ||
| ] | ||
| for before, after in substitutions: | ||
| if html.count(before) != 1: | ||
| raise ValueError("FX master semantics anchor missing or ambiguous: " + before[:90]) | ||
| html=html.replace(before,after,1) | ||
| return html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an original channel/AUX rack is bypassed and the operator performs a structural channel repatch with outputs disarmed,
LiveAudioEngine::repatchDryRoutingLabChannel()callsadmitChannelIdFromAcceptedM4(), which rebuilds the bank throughUnifiedLegacyProductionAdmission::compileAndCommit(). That path obtains every assignment fromcaptureLegacy(), which never populatesrackBypassed, so this fallback initializes every rack to ON. Native rack commands update only the accepted bank, leaving no corresponding bypass state in the M4 graph to recover. Consequently, an unrelated routing edit silently re-enables previously bypassed effects when output resumes. Preserve the accepted rack gates through this re-admission path as well as throughreuseRevision()andappendOwned().AGENTS.md reference: AGENTS.md:L37-L37
Useful? React with 👍 / 👎.