Skip to content

Parametric EQ UI/DSP prototype — BLOCKED: integrate into latest P0 mixer #418 - #423

Closed
masarray wants to merge 50 commits into
mainfrom
feat/native-builtin-fx-channel-eq-20261106
Closed

masarray wants to merge 50 commits into
mainfrom
feat/native-builtin-fx-channel-eq-20261106

Conversation

@masarray

@masarray masarray commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

BLOCKING ENGINE–GUI RECONCILIATION (2026-11-06): NOT A WORKING DAW RELEASE. The user reports that the candidate app/engine does not operate. Current P0 source authority is #418 at 16fe8c42d365f76ef24d143a5040bc8aee812ef7; #423 is still independently branched from main@ac85039a, so its Windows ZIP must not be promoted as a working integrated product. Its built-in EQ rack row is injected before the ordinary rows loop (scripts/compose_builtin_eq.py), and DSP is a fixed pre-VST3 EQ bank, NOT an ordinary slot in the ordered VST3 insert model. On CH01 the approved browser demo can show two Parametric EQ-looking rows (preexisting reference insert plus native built-in row): this is evidence of UX/model mismatch, not a finished FX plugin. Reconcile into #418 source-owned audio graph with a SINGLE slot identity, ordered per-insert effect/bypass/reorder, native ACK/readback and physical ASIO listening proof. Do not bypass native ownership or fake live PCM.

Actual Chromium UI screenshots (not audio evidence): Full mixer/editor from exact UI test SHA b6666aff on three viewport sizes. Label remains UI DEMO / NO AUDIO. Full Chromium PASSED, but does not qualify native DAW control.

Parametric EQ as a normal FX Rack insert — same approved mixer (experimental)

Candidate exact HEAD: caf0c4239827d908e2efd9fe607d30400e5c75b9 · DRAFT / NOT MERGED / NOT RELEASED. This is an iterative fix to the existing #423, not a second mixer or an external ArSonEQ VST3 fork.

Operator UX corrected following the owner's Windows feedback

  1. In the existing channel FX Rack, click + Add FX. In that same fast FX picker choose BUILT-IN FX → Parametric EQ (search also supports PEQ/Channel EQ; keyboard Enter and mouse use the same insert operation).
  2. Choosing the effect adds Parametric EQ to the channel rack; it must NOT automatically pop a plugin editor or create another mixer window. The FX counter reflects the installed built-in effect plus vendor inserts.
  3. The Parametric EQ rack row opens its editor when the operator clicks the effect name. The editor is modeless, can be moved by dragging its TITLE BAR (graph/control gestures stay independent), and supports band selection, pointer-frequency drag, frequency/gain/Q, power, and close/reopen.
  4. In native JUCE, an insert pending audio thread ACK/readback is explicitly shown APPLYING, not optimistically activated. The picker-only install path now initializes native mode before any editor opens; accepted native snapshots update rack state. A stale/failed gate leaves no fake effective FX.
  5. This applies to the ONE canonical assembled /preview/ GUI, shared between Pages browser preview and JUCE WebView2. Immutable historical HTML seed preserved. Source owner: scripts/compose_builtin_eq.py + site/preview-v2/assets/mixer-builtin-eq.js; FX appearance stays in the existing rack CSS owner.

Audio DSP and Show unchanged in this UX correction

  • Existing native 8-band parametric EQ PCM path (HPF/shelves/4 bell/LPF), in-place pre-VST3 on accepted 10 CH + 4 AUX mapping, retains single realtime callback, bounded control/ACK queues, 5ms transitions and Show V5 accepted parameter save/recall.
  • The FX master bypass and individual VST slot bypass semantics remain separate. No new DSP callback, polling engine, WebAudio, fake live audio, or unnecessary PCM-path edits.
  • The native plugin is a BUILT-IN FX catalog entry, not a scanned VST3 DLL and not an external ArSonEQ build.

Evidence (revision-specific, do not borrow previous ZIP)

Remaining gates


2026-11-08 reconciliation: ARCHIVED, NOT MERGED

Experimental PEQ prototype remains unsafe to merge wholesale: the PR itself documents duplicate FX rows and a fixed pre-VST DSP bank rather than the ordered authoritative inserts. Current main has native PEQ UI composition and built-in EQ DSP components, so this historical multi-surface branch is retired. Any genuinely missing ordered-insert/FX capability belongs in a new scoped change against current main, tracked under #192 and the FX roadmap #185; its branch history is preserved.

Current approved authority: main, merged native integration #418. Existing branch history remains available; this closure is not evidence of physical audio FAT.

@masarray masarray changed the title Built-in FX foundation: lightweight 8-filter native Channel EQ + standalone RT tests Built-in Channel EQ: 8-stage native PCM + approved GUI ACK/readback integration trial Nov 6, 2026

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

P0 Built-in Channel EQ — implementation / test checkpoint (2026-11-06)

Latest candidate: 2559353f4ef0ed247b73390d7a9f339fa177dcf9 (this existing Draft PR, not main).

Implemented in this PR

  • Approved /preview/ picker has a separate BUILT-IN FX → Channel EQ choice and VST3 PLUGINS grouping. One pre-VST3 EQ row per original native channel, with editor, slot power/bypass and remove.
  • Native band/gate edits flow through stable ChannelId + device epoch + graph revision into the single audio callback; bounded SPSC, control-side coefficient generation, DSP ACK and subsequent accepted readback. No duplicate VST3 host, ArSonEQ dependency, WebAudio or lookahead.
  • 5ms bypass transition, reset-on-remove, native state requery after accepted graph changes, no optimistic UI state.
  • Isolated experimental Windows x64 FAT ZIP upload enabled in p1-windows.yml for this branch only, not stable promotion.
  • Native Show v4 lacks built-in EQ schema. SAVE/RECALL now fail closed while any EQ is installed/transition pending instead of silently discarding EQ state.

Evidence

  • Standalone built-in DSP CTest Windows & Ubuntu: PASS (latest candidate 2559353).
  • JavaScript syntax and built-in EQ mocked editor/ACK/graph-revision integration in UI smoke: PASS.
  • Full Windows executable/CTest, Chromium visual suite and ZIP artifact: IN PROGRESS, not certified or physically tested. Workflow: https://github.com/masarray/arsonmix/actions/runs/42178826610
  • Hardware ASIO listening/latency/stability FAT: PENDING.

Explicit blockers before Ready/Merge

  1. Transactional native Show persistence and recall of 8-band state per ChannelId; do not re-enable Show saves by bypassing the guard.
  2. Integrate FX rack header bypass ALL / restore per-slot states with concurrent PR FX rack master power: bypass all effectively and restore each insert's last state (GUI + native engine) #421/P1 DAW mixer: native WIRE/FX rack master bypass + safe optional STREAM output #422, including this EQ gate (not only VST3 and not UI-only).
  3. Reconcile physical workflow changes with Draft Fix cold WIRE admission and native VST3 picker/editor with prepared graph PDC #418. No unreviewed main merge.
  4. Verify Windows ZIP from latest HEAD and real audio hardware.

Please preserve the existing single callback and per-ChannelId ownership. This is an experimental trial, not a completed production release.

@masarray
masarray marked this pull request as ready for review November 6, 2026 08:02

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui d52460d

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 3ef0a96

…tore historical V10 proof; opt-in Firefox perf

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 75ea76a

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 62d77ba

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui a6d225a

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat a6d225a

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat e943259

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

EQ milestone reconciliation — e943259 (2026-11-06)

  • Merged current main Smart CI and agent instructions as a two-parent merge commit into this existing PR, preserving built-in EQ, FX rack bypass, and Show V5 changes. PR is now mergeable, 0 commits behind main.
  • Fresh head's fast checks: Native Built-in FX DSP, Fast UI, and Fast Native all PASS.
  • Previous head a6d225ac... completed an exact-SHA full Chromium qualification (60 successful steps), but a FAT ZIP from that SHA is not final for the new merged head.
  • Exact-SHA FAT dispatch requested for e943259c112864ed5e55cbbb3ee1175546716bc7: https://github.com/masarray/arsonmix/actions/runs/42209310679 . Do not release or advertise a ZIP from an earlier SHA as this milestone.
  • Preserve Draft pending final Windows CTest + ZIP provenance and hardware FAT (actual ASIO, audio routing, VST3, multi-channel EQ, Show recall). Green CI is not physical hardware proof.
  • Do not spin additional milestone runners for an unchanged SHA. Use the owner-authenticated /arsonmix-ci <lane> <SHA> dispatcher and one SHA per qualification.

Next gate: confirm Windows exact-SHA CTest and artifact metadata, then only promote after native audio hardware FAT evidence.

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 3de55de

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui caf0c42

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat caf0c42

@masarray masarray changed the title Built-in Channel EQ: native PCM + Show V5 save/recall (experimental qualification) Parametric EQ native FX Rack insert + interactive modeless editor (draft Windows qualification) Nov 6, 2026
@masarray masarray changed the title Parametric EQ native FX Rack insert + interactive modeless editor (draft Windows qualification) Parametric EQ native FX Rack insert + draggable editor (draft hardware FAT pending) Nov 6, 2026

masarray commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui b6666af

@masarray masarray changed the title Parametric EQ native FX Rack insert + draggable editor (draft hardware FAT pending) Parametric EQ UI/DSP prototype — BLOCKED: integrate into latest P0 mixer #418 Nov 6, 2026
@masarray masarray closed this Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant