Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
c623769
feat(builtin-fx): standalone ultra-light native channel EQ with RT-sa…
masarray Nov 6, 2026
1d4c385
fix(builtin-eq): precompute coefficients off audio callback; apply bo…
masarray Nov 6, 2026
5531018
feat(builtin-eq): real PCM hook in single render graph, RT-safe 14-la…
masarray Nov 6, 2026
38873c2
fix(builtin-eq): preserve one EQ bank across M4 and accepted ChannelI…
masarray Nov 6, 2026
fd45be7
test(builtin-eq): native ChannelId PCM owner regression + stale revis…
masarray Nov 6, 2026
821dcab
feat(builtin-eq): admitted ChannelId intent and applied PCM ACK with …
masarray Nov 6, 2026
aafe683
feat(builtin-eq): compact accepted-state editor inside canonical ArSo…
masarray Nov 6, 2026
05f2449
fix(builtin-eq): browser contract syntax, native bridge identity and …
masarray Nov 6, 2026
e84719d
fix(builtin-eq): respect canonical FX CSS owner and deterministic GUI…
masarray Nov 6, 2026
bbea765
fix(builtin-eq): compose EQ into one approved Pages/JUCE GUI without …
masarray Nov 6, 2026
23ebe0f
fix(builtin-eq): deterministic single-GUI assembler quoting and syntax
masarray Nov 6, 2026
90cc49a
fix(builtin-eq): audit one deterministic EQ assembler in Pages and pu…
masarray Nov 6, 2026
77c39f6
test(builtin-eq): validate shared single-GUI composition module inste…
masarray Nov 6, 2026
f416ea5
fix(builtin-eq): sample-accurate GUI response, low-rate readback, lig…
masarray Nov 6, 2026
025c33a
fix(builtin-eq): JUCE device-rate constness and runtime EQ ACK/drag/h…
masarray Nov 6, 2026
f284ea8
test(builtin-eq): model DOM attachment correctly in native editor int…
masarray Nov 6, 2026
03bb6f6
feat(builtin-eq): real FX picker/slot with audio-ACK-backed native in…
masarray Nov 6, 2026
880d8c7
fix(builtin-eq): advance DSP coefficient transitions even while bypassed
masarray Nov 6, 2026
7070fae
test(builtin-eq): preserve preexisting coefficient fade assertions be…
masarray Nov 6, 2026
5da64e2
ci(builtin-eq): package and upload experimental Windows x64 EQ FAT ZI…
masarray Nov 6, 2026
c31ea23
test(builtin-eq): execute live EQ picker/editor and audio-ACK GUI reg…
masarray Nov 6, 2026
2559353
fix(builtin-eq): restore per-channel rack readback after graph revisi…
masarray Nov 6, 2026
cc2b10f
test(builtin-eq): explicitly install EQ in both native PCM fixtures a…
masarray Nov 6, 2026
849d083
feat(builtin-eq): transactional Show V5 8-band save/recall with fresh…
masarray Nov 6, 2026
7748f0e
test(builtin-eq): verify persisted Show V5 preserves 8-band EQ, bypas…
masarray Nov 6, 2026
ef464fb
test(builtin-eq): reject missing or truncated native Show V5 CH/AUX E…
masarray Nov 6, 2026
74f319a
merge(main): smart runner policy + Show V5 EQ milestones; no duplicat…
masarray Nov 6, 2026
0aa1802
test(show-v5): align approved GUI and routed Show integration contrac…
masarray Nov 6, 2026
0fa8482
fix(show-v5): correct remaining restoredV4 fixture reference after V5…
masarray Nov 6, 2026
49039c3
fix(eq): publish restored Show V5 DSP bank and await real audio ACK; …
masarray Nov 6, 2026
d0034cc
feat(eq): integrate FX rack header master bypass into real VST3 and C…
masarray Nov 6, 2026
20d6db2
ci(eq): accept owner-authorized immutable-SHA ChatGPT UI and FAT qual…
masarray Nov 6, 2026
3a4923a
fix(ci): retain reviewed-PR Windows guard while supporting exact-SHA …
masarray Nov 6, 2026
515d519
test(gui): validate V6 interactions on the single approved /preview/ …
masarray Nov 6, 2026
8bb868e
fix(eq): settle pending audio edits safely when graph/epoch identity …
masarray Nov 6, 2026
9450a55
test(gui): verify locked WIRE/PNG CSS in approved Stage D single runt…
masarray Nov 6, 2026
cdcae77
test(gui): qualify V10 historical restore against maintained Stage D …
masarray Nov 6, 2026
d52460d
ci(gui): gate pinned V10-V28 migration history separately from curren…
masarray Nov 6, 2026
58b9e5d
test(gui): validate approved PNG/WIRE assets through single Stage D r…
masarray Nov 6, 2026
3ef0a96
test(gui): qualify contextual, fader and dBFS controls on one compile…
masarray Nov 6, 2026
75ea76a
test(gui): retain full visual acceptance on assembled preview and res…
masarray Nov 6, 2026
62d77ba
test(gui): verify Stage D WIRE owner marker rather than nonexistent f…
masarray Nov 6, 2026
a6d225a
test(wire): share current single-preview CSS provenance across V43-V4…
masarray Nov 6, 2026
e943259
merge(ci): reconcile canonical Smart CI main instructions into EQ mil…
masarray Nov 6, 2026
b3c78e0
Restore DAW UX: Parametric EQ picker inserts rack; click opens movabl…
masarray Nov 6, 2026
841ff28
Update built-in EQ contract to enforce rack-only editor launch and ke…
masarray Nov 6, 2026
beee281
Assert native EQ provisional status until readback and clamp-aware mo…
masarray Nov 6, 2026
3de55de
Fix headless native Parametric EQ insertion: preserve accepted ACK/re…
masarray Nov 6, 2026
caf0c42
Correct browser reopen test to reselect edited P2 band before verifyi…
masarray Nov 6, 2026
b6666af
Capture real Chromium Parametric EQ editor and mixer screenshots for …
masarray Nov 6, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/native-builtin-fx.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: Native Built-in FX DSP
on:
pull_request:
paths:
- 'site/preview-v2/assets/mixer-builtin-eq.*'
- 'tests/builtin_eq_gui_contract_test.mjs'
- 'engine/builtin_fx/**'
- 'tests/builtin_channel_eq_test.cpp'
- '.github/workflows/native-builtin-fx.yml'
workflow_dispatch:
permissions:
contents: read
concurrency:
group: native-builtinfx-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
jobs:
standalone-dsp:
# Fast Linux DSP; canonical Windows MSVC only on full milestone review.
runs-on: ubuntu-latest
timeout-minutes: 8
steps:
- uses: actions/checkout@v4
- name: Console EQ GUI syntax and ownership contract
run: |
node --check site/preview-v2/assets/mixer-builtin-eq.js
node tests/builtin_eq_gui_contract_test.mjs
- name: Configure no-JUCE native built-in FX
run: cmake -S engine/builtin_fx -B build-builtin-fx -DCMAKE_BUILD_TYPE=Release
- name: Compile native DSP test
run: cmake --build build-builtin-fx --config Release --parallel 2
- name: Verify native DSP + zero heap test
run: ctest --test-dir build-builtin-fx -C Release --output-on-failure
2 changes: 1 addition & 1 deletion .github/workflows/p1-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ jobs:
needs: quick
# Draft commits never reserve expensive Windows runners. Non-draft PR
# synchronizations re-test latest HEAD. Main push and manual always run.
if: ${{ github.event_name != 'pull_request' }}
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
runs-on: windows-2022
timeout-minutes: 50
steps:
Expand Down
91 changes: 55 additions & 36 deletions .github/workflows/ui-smoke.yml

Large diffs are not rendered by default.

32 changes: 32 additions & 0 deletions engine/builtin_fx/BuiltInFxCatalog.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// SPDX-License-Identifier: AGPL-3.0-only
#pragma once
#include <array>
#include <cstddef>
#include <cstdint>
#include <string_view>

// This is a compile-time catalog of NATIVE effects, not a VST3/FactoryFX manifest.
// Never advertise these as usable in the operator picker until the native PCM
// owner and ACK/snapshot adapter have actually been integrated.
namespace armix::builtin_fx {
inline constexpr std::string_view channelEqId = "armix.builtin.channel-eq.v1";

enum class FilterKind : std::uint8_t { highPass, lowShelf, bell, highShelf, lowPass };
enum class Slope : std::uint8_t { db12 = 12, db24 = 24 };
struct SlotSpec {
std::string_view id;
FilterKind kind;
float defaultHz;
};
inline constexpr std::array<SlotSpec, 8> channelEqSlots{{
{"hpf", FilterKind::highPass, 80.0f},
{"low-shelf", FilterKind::lowShelf, 160.0f},
{"peq-1", FilterKind::bell, 250.0f},
{"peq-2", FilterKind::bell, 500.0f},
{"peq-3", FilterKind::bell, 1500.0f},
{"peq-4", FilterKind::bell, 4500.0f},
{"high-shelf",FilterKind::highShelf, 9500.0f},
{"lpf", FilterKind::lowPass, 18000.0f}
}};
static_assert(channelEqSlots.size() == 8);
} // namespace armix::builtin_fx
24 changes: 24 additions & 0 deletions engine/builtin_fx/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Optional JUCE-independent developer/CI gate for the built-in DSP module.
# cmake -S engine/builtin_fx -B build/builtin_fx
# cmake --build build/builtin_fx --config Release
# ctest --test-dir build/builtin_fx -C Release --output-on-failure
cmake_minimum_required(VERSION 3.22)
project(ArSonMixBuiltInFX LANGUAGES CXX)
enable_testing()
add_executable(ArSonMixBuiltInEQTests ../../tests/builtin_channel_eq_test.cpp)
target_compile_features(ArSonMixBuiltInEQTests PRIVATE cxx_std_20)
if(MSVC)
target_compile_options(ArSonMixBuiltInEQTests PRIVATE /W4)
else()
target_compile_options(ArSonMixBuiltInEQTests PRIVATE -Wall -Wextra -Wpedantic)
endif()
add_test(NAME BuiltInChannelEqIndependentRealtimeDSP COMMAND ArSonMixBuiltInEQTests)

add_executable(ArSonMixBuiltInEQBankTests ../../tests/builtin_channel_eq_bank_test.cpp)
target_compile_features(ArSonMixBuiltInEQBankTests PRIVATE cxx_std_20)
if(MSVC)
target_compile_options(ArSonMixBuiltInEQBankTests PRIVATE /W4)
else()
target_compile_options(ArSonMixBuiltInEQBankTests PRIVATE -Wall -Wextra -Wpedantic)
endif()
add_test(NAME BuiltInChannelEqFourteenChannelAudioOwnerAndAck COMMAND ArSonMixBuiltInEQBankTests)
Loading
Loading