Repository navigation
Conversation
…dback and visual QA
…cap and guard revision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built-in ArSonMix Console EQ — isolated native DSP + GUI candidate
Branch
feat/console-built-in-eq-isolated-20261106(base: existing ArSonEQ PR #1 development branch). NOT MERGED and not a change to ArSonMix mixer or/preview/.Implemented: no parallel mixer/host
Source/DSP/ConsoleChannelEQ.h: reusable C++17, nine stable slots (HPF / low shelf / 5 peaking bell / high shelf / LPF), 12/24/48 dB/oct cuts, band bypass, fail-closed controls; existing native minimum-phasearson::eq::Engine(no second DSP engine). Zero additional block/sample buffering (not zero ASIO roundtrip).tests/eq_console_tests.cppand CMake CTest: cutoff/center response, mono/stereo, bypass fade, sample-0 impulse, no process-path heap allocation for 32/64/128/512 frames and 44.1/48/96k.ConsoleUI/index.html,style.css,app.js: self-contained compact operator EQ editor; log-frequency graph, nine small band pads, gain/Q/frequency/slope, drag and wheel, per-band power and atomic FLAT intent. No React/CDN/WebAudio/FFT, no driver/IO/ASIO activation./preview/atmain@591444d: 29px silver title, anodized metal equipment header, blue-black FX glass, cyan accents, small controls, no large cards. No mixer theme/canonical hardware artwork was modified or copied into runtime.ChannelId/ epoch / revision; browser sends boundedeqSetBand/eqResetFlatintents to a future native adapter;ArSonConsoleEQ.ack()does not apply state without matching latersetSnapshot()including native-computed response. Reject stale/mismatched ACKs, cross-channel reuse, invalid parameters, duplicate-revision mutation; pending times out (unknown status, not assumed rolled back). Offline launch disables controls.?designPreview=1mode computes visual fixture only (no audio, no claim of native engine state); every screenshot is clearly watermarked DESIGN PREVIEW · NO AUDIO. Real mode requires native state and native DSP response.CI and visual evidence
b3539b8: Linux CI run, artifactArSonMix-Console-EQ-Design-Candidate(ID 13471708442)./preview/remain exactly as before.Stop-ship / next integration gate
ArSonMix physical mixer still has priority. No
arsonmix/main, input selector, WIRE, FX rack, fader, user VST3 catalog, WebView2 mixer renderer, Scene/Show or audio callback files are touched. Built-in EQ is not yet wired to live ArSonMix PCM. Single-owner mixer integrator must attach one instance per accepted ChannelId to the existing primary callback (never a second callback), publish native parameter/curve snapshots from the right owner, reconcile with existing/preview/source-of-truth, then demonstrate compiled Windows UI, 0FX soak/physical ASIO and active EQ FAT. Do not auto-merge or imply tested hardware sound.