Skip to content

fix(native FX): mixer-owned floating editors and reliable FX Rack reopen - #731

Draft
masarray wants to merge 16 commits into
mainfrom
fix/native-owned-fx-editor-reopen-20261116
Draft

masarray wants to merge 16 commits into
mainfrom
fix/native-owned-fx-editor-reopen-20261116

Conversation

@masarray

Copy link
Copy Markdown
Owner

User-visible failures fixed

  • Native built-in/VST3 editors can fall behind mixer (no HWND owner relationship)
  • Re-clicking the same FX Rack entry can fail to show an existing hidden/editor instance
  • Logical editor currently rejects all clicks, even for its own still-open FX

Implementation (NO DSP changes)

  • Top-level Win32 HWND owner relationship (GWLP_HWNDPARENT), no WS_CHILD, no system-wide TOPMOST
  • Reuse/refocus exact existing physical-lease, legacy, or logical FX editor; recreate only when accepted identity changes
  • Own Audio Setup dialog to mixer, preserve ASIO lease and independent GUI sizing
  • Fixed-size editors no longer advertise resize if the processor refuses it
  • Track borrowed editor pointer only as identity; destroy window before releasing original graph lease

Verification

Do not merge into production main until Windows focused FAT passes and real host behaviour is verified.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 61d64cd
Status: ✅  Deploy successful!
Preview URL: https://1576bf94.arsonmix.pages.dev
Branch Preview URL: https://fix-native-owned-fx-editor-r.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

Windows field FAT still required before merge

Focused Win32 HWND and source-contract CI passed at draft HEAD, but this is NOT a claim of live mixer/application UI qualification.

Real Windows checklist: (1) open EQ, Compressor, Vocal Delay, Harmonice, SonKu, ImmerSIB (where enabled) and third-party VST3 from FX Rack; (2) click mixer then click same FX Rack slot again — exact same editor reappears without resetting DSP; (3) close via OS X and any in-editor CLOSE, click same slot again; (4) choose different FX slot and confirm old editor is destroyed before new editor; (5) minimize/restore mixer and switch to an unrelated application — FX remains above its mixer but not system-wide topmost; (6) Audio Setup remains owned, closes and restores without losing device lease; (7) repeat at Windows DPI 100/125/150/200; (8) no GUI operation changes routing PCM, accepted FX identity, bypass, or session persistence.

This PR is deliberately independent of SonKu experiment PR #722. Do not merge without a real installed-app mouse/keyboard FAT.

masarray added a commit that referenced this pull request Nov 17, 2026
…dows release hardening (#734)

Preserve approved SonKu P9.9 main, selectively integrate #722/#732/#731, maintain one PCM graph and IMRS sessions; native and public-OFF Windows profiles, MIT notices and installer FAT proven.

Copy link
Copy Markdown
Owner Author

INT-1 old editor draft reconciliation: #837
Native FX editor reopen is an important user-test path, but this older draft may overlap current merged G-MV35/37 and active G-MV36/38 (#832/#836). Before any revival, compare current main and newer editor HWND lease + ack/readback; transfer only still-missing, verified C++ lifetime fixes onto a clean scoped PR. Do NOT bulk-merge old bridge/GUI files or create a second editor authority. Document whether the regression is already fixed or exact remaining Windows test; no unqualified release claim.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant