Repository navigation
Conversation
|
GUI-2 exact-head milestone qualification: fast UI 44226315797, fast native Node/Python 44226315864, release contracts 44226315744 all PASS at /arsonmix-ci ui d7366af |
|
/arsonmix-ci ui d7366af |
GUI-2 reconciliation — SUPERSEDED, DO NOT MERGEOn final exact-head verification a parallel GUI-2 PR #773 merged to main at Compared both exact implementations at the file/content level: #773 already owns the canonical FX global/rack/slot power ViewModel with stable mounted instance identity guard and source/bundle tests. In particular #773 also adds strict canonical DOM slot dataset validation. This PR has a few unmerged additional pure helpers, such as M4 catalog projection and rack pending settlement; they are optional future improvements, NOT a reason to duplicate FX Rack ViewModel or alter Win32 editor authority. Keep the proven #773 single owner. There is no new duplicate JS file merged from #772. HASIL: Canonical GUI-2 is already merged via #773; this overlap is closed without merge to preserve one FX Rack path. STATUS: #772 SUPERSEDED / NOT MERGED; GUI-2 canonical #773 MERGED. AMAN DIPAKAI: source in main qualifies, installed Windows EXE/hardware not asserted. TINDAKAN ANDA: none. BERIKUTNYA: work on GUI-3 WIRE/BUS/MAIN presentation from current main, no cross-domain graph/DSP changes. |
Scope: GUI-2 (actual native /preview/, no second FX engine)
Based on merged GUI-1 PR #769 and canonical Device Setup #767. Source audit of open #731 (native Win32 editor HWND ownership), #708 (factory reset), older stacked GUI/FX drafts and concurrent IO-1 finds no reason to alter native C++ or visual assets. This change is limited to FX Rack presentation in the one packaged JUCE/WebView2 GUI; editor ownership remains with existing native code.
Real extraction, not cosmetic wrappers
web/approved-fx-rack-view-model.jsfor accepted ChannelId rack/global/slot bypass presentation (including button labels, latency captions, effective state), stable mounted instance-token compatibility, M4 metadata projection and ACK+later-installed readback settlement.paintNativeFxPowerReadback,paintM4FxInstances,reconcileM4RackReadbackand ChannelId FX-power accepted reconciliation in the original bridge with one projection + DOM adapter.scripts/build_approved_native_gui.py; assert native-only JS bytes and original public /preview/ untouched.Measured initial delta
web/approved-native-bridge.js: 4153 → 4123 lines (-30 net), removes previous inline projection/identity/latency/button decision rules; pure module 92 lines.Qualification before merge
Exact-head fast UI/native/release CI then one deliberate full native-assembled Chromium /preview/ qualification; native Windows/physical listening and editor HWND FAT are explicitly NOT RUN, and #731 remains a separate native owner. Reconcile latest main/PR overlaps before merge; do not bypass branch protection.