Skip to content

refactor(gui): pure FX Rack power/readback and stable instance presentation (GUI-2) - #772

Closed
masarray wants to merge 1 commit into
mainfrom
refactor/gui2-fx-rack-presentation-20261118
Closed

masarray wants to merge 1 commit into
mainfrom
refactor/gui2-fx-rack-presentation-20261118

Conversation

@masarray

Copy link
Copy Markdown
Owner

Scope: GUI-2 (actual native /preview/, no second FX engine)

Based on merged GUI-1 PR #769 and canonical Device Setup #767. Source audit of open #731 (native Win32 editor HWND ownership), #708 (factory reset), older stacked GUI/FX drafts and concurrent IO-1 finds no reason to alter native C++ or visual assets. This change is limited to FX Rack presentation in the one packaged JUCE/WebView2 GUI; editor ownership remains with existing native code.

Real extraction, not cosmetic wrappers

  • Add one pure web/approved-fx-rack-view-model.js for accepted ChannelId rack/global/slot bypass presentation (including button labels, latency captions, effective state), stable mounted instance-token compatibility, M4 metadata projection and ACK+later-installed readback settlement.
  • Replace old inline conditionals and per-slot computations inside paintNativeFxPowerReadback, paintM4FxInstances, reconcileM4RackReadback and ChannelId FX-power accepted reconciliation in the original bridge with one projection + DOM adapter.
  • Preserve eight slots, stable instance IDs, global A/B vs rack/individual bypass, display-only GAIN/SOF and unmounted mobile banks, existing pending maps, one native request dispatch path, real FX HWND lifecycle, and no re-render on accepted scalar update.
  • Bundle exact pure module before bridge in scripts/build_approved_native_gui.py; assert native-only JS bytes and original public /preview/ untouched.
  • Add 4 isolated deterministic Node contract tests (global/rack/slot bypass, stale DOM leases, ACK/readback identity fencing, M4 catalog), extend existing fader/FX fixture injection and native Chromium cold-start assertion.

Measured initial delta

  • web/approved-native-bridge.js: 4153 → 4123 lines (-30 net), removes previous inline projection/identity/latency/button decision rules; pure module 92 lines.
  • Seven files total, no C++ DSP/ASIO/FX processor/Win32 editor, no session/PCM/dispatcher/CSS/HTML/PNG edits.

Qualification before merge

Exact-head fast UI/native/release CI then one deliberate full native-assembled Chromium /preview/ qualification; native Windows/physical listening and editor HWND FAT are explicitly NOT RUN, and #731 remains a separate native owner. Reconcile latest main/PR overlaps before merge; do not bypass branch protection.

Copy link
Copy Markdown
Owner Author

GUI-2 exact-head milestone qualification: fast UI 44226315797, fast native Node/Python 44226315864, release contracts 44226315744 all PASS at d7366af5971ed1ef628a71adb150ebdb4d83794e. Dispatch one full assembled native /preview/ Chromium UI run, no Windows/C++/ASIO build; maintain plugin editor HWND contract from active #731 unchanged.

/arsonmix-ci ui d7366af

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui d7366af

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: d7366af
Status:🚫  Build failed.

View logs

Copy link
Copy Markdown
Owner Author

GUI-2 reconciliation — SUPERSEDED, DO NOT MERGE

On final exact-head verification a parallel GUI-2 PR #773 merged to main at 87a1abe439fd3d5cc205338e2758cba1d9c0cff7, using the SAME web/approved-fx-rack-view-model.js, native bridge, bundle and Node/Chromium contract paths as this PR. This draft #772 has exact head d7366af5971ed1ef628a71adb150ebdb4d83794e and a successful full native assembled Chromium run #44226512316, plus successful fast UI/native/release contracts; green checks on this alternative do not justify replacing merged #773.

Compared both exact implementations at the file/content level: #773 already owns the canonical FX global/rack/slot power ViewModel with stable mounted instance identity guard and source/bundle tests. In particular #773 also adds strict canonical DOM slot dataset validation. This PR has a few unmerged additional pure helpers, such as M4 catalog projection and rack pending settlement; they are optional future improvements, NOT a reason to duplicate FX Rack ViewModel or alter Win32 editor authority. Keep the proven #773 single owner. There is no new duplicate JS file merged from #772.

HASIL: Canonical GUI-2 is already merged via #773; this overlap is closed without merge to preserve one FX Rack path. STATUS: #772 SUPERSEDED / NOT MERGED; GUI-2 canonical #773 MERGED. AMAN DIPAKAI: source in main qualifies, installed Windows EXE/hardware not asserted. TINDAKAN ANDA: none. BERIKUTNYA: work on GUI-3 WIRE/BUS/MAIN presentation from current main, no cross-domain graph/DSP changes.

@masarray masarray closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant