Repository navigation
refactor(gui G-MV31): exact FX editor navigation leases for native, offline and M4 - #826
Conversation
…cal and M4 leases
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying arsonmix with
|
| Latest commit: |
ff4ff3f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://38eb8b4b.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-g-mv31-exact-fx-edi.arsonmix.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06eb6f0813
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
/arsonmix-ci ui ff4ff3f |
G-MV31 FINAL — MERGED
|
G-MV31 — complete FX editor navigation ownership in one pure FX Rack ViewModel
The approved bridge used to schedule
openVerifiedInsertedFx()throughqueueMicrotaskand recheck onlyinstanceId/catalogId. A physical session could be replaced or an offline.smixworkspace swapped before that click runs, so an older confirmed insert might trigger an editor in a new authority. Manual M4 edit also inspected raw inventory and host tokens directly in the bridge instead of the existing pure admission boundary.Implementation (one substantive GUI milestone):
fxRackVM.editorNavigationPlannow builds ONE pure, immutable FX instance navigation lease from independently accepted ChannelId or logical read models. The identity captures authority, exact uint64 ChannelId, slot, real instance/catalog, graph revision, roster revision, offline workspace token or physical device epoch + driver configuration. No PCM, browser IPC or HWND logic in the ViewModel.fxRackVM.editorNavigationLeaseMatchesrevalidates the full lease immediately before deferred editor invocation: oldqueueMicrotaskactions cannot cross rebind, reconnect, topology, roster, plugin replacement, offline workspace or same-epoch physical configuration change. GUI display stays on the already-approved/preview/.openPluginclick and post-insert deferred path use the SAME ViewModel admission. The bridge retains exact existing built-in EQ/Compressor/Harmonice/Vocal Delay/SonKu editor dispatch, genuine JUCE ImmerSIB/vendor VST3 HWND and offline vendor editor transport, but no longer decides acceptance from a loosecurrent.admitted||current.logicalbranch.fxRackVM.m4EditorPlanreplacesverifiedFxForraw-inventory lookup in the bridge. M4 manual editor and picker require exact admitted M4 device/routing owner; only existing host numeric tokens are dispatched, no fake ChannelIds..smixworkspace switch, invalid M4 routing/inventory and the real bridge adapter. Existing RC operator contract updated to check the new owned policy.Scope: four files (
web/approved-fx-rack-view-model.js,web/approved-native-bridge.js,tests/approved_native_m2_contract.test.cjs,tests/rc_operator_workflow_contract.test.mjs). No JUCE DSP, native host, installer, CMake, ASIO hardware, public CSS or layout changes. Preserve one PCM/VST3 renderer, native ACK/readback and producer authority. Parallel I/O PRs and FX editor native PR #731 not modified.Qualification pending: base
main@089e35e381ad2784a4cbe49c2c2554f7fbc72914, head06eb6f081328e8f48823d0c03447de4015177105. Fast UI/Native checks then one exact-head Chromium milestone and required merge gate must PASS before protected squash. Not a Windows hardware FAT or installed release.