Skip to content

refactor(gui G-MV31): exact FX editor navigation leases for native, offline and M4 - #826

Merged
masarray merged 2 commits into
mainfrom
refactor/g-mv31-exact-fx-editor-lease-20261119
Nov 19, 2026
Merged

masarray merged 2 commits into
mainfrom
refactor/g-mv31-exact-fx-editor-lease-20261119

Conversation

@masarray

Copy link
Copy Markdown
Owner

G-MV31 — complete FX editor navigation ownership in one pure FX Rack ViewModel

The approved bridge used to schedule openVerifiedInsertedFx() through queueMicrotask and recheck only instanceId/catalogId. A physical session could be replaced or an offline .smix workspace swapped before that click runs, so an older confirmed insert might trigger an editor in a new authority. Manual M4 edit also inspected raw inventory and host tokens directly in the bridge instead of the existing pure admission boundary.

Implementation (one substantive GUI milestone):

  • fxRackVM.editorNavigationPlan now builds ONE pure, immutable FX instance navigation lease from independently accepted ChannelId or logical read models. The identity captures authority, exact uint64 ChannelId, slot, real instance/catalog, graph revision, roster revision, offline workspace token or physical device epoch + driver configuration. No PCM, browser IPC or HWND logic in the ViewModel.
  • fxRackVM.editorNavigationLeaseMatches revalidates the full lease immediately before deferred editor invocation: old queueMicrotask actions cannot cross rebind, reconnect, topology, roster, plugin replacement, offline workspace or same-epoch physical configuration change. GUI display stays on the already-approved /preview/.
  • Direct openPlugin click and post-insert deferred path use the SAME ViewModel admission. The bridge retains exact existing built-in EQ/Compressor/Harmonice/Vocal Delay/SonKu editor dispatch, genuine JUCE ImmerSIB/vendor VST3 HWND and offline vendor editor transport, but no longer decides acceptance from a loose current.admitted||current.logical branch.
  • fxRackVM.m4EditorPlan replaces verifiedFxFor raw-inventory lookup in the bridge. M4 manual editor and picker require exact admitted M4 device/routing owner; only existing host numeric tokens are dispatched, no fake ChannelIds.
  • Deterministic contract regressions cover exact 64-bit identities, device/graph/roster/plugin/authority and hardware remap, .smix workspace switch, invalid M4 routing/inventory and the real bridge adapter. Existing RC operator contract updated to check the new owned policy.

Scope: four files (web/approved-fx-rack-view-model.js, web/approved-native-bridge.js, tests/approved_native_m2_contract.test.cjs, tests/rc_operator_workflow_contract.test.mjs). No JUCE DSP, native host, installer, CMake, ASIO hardware, public CSS or layout changes. Preserve one PCM/VST3 renderer, native ACK/readback and producer authority. Parallel I/O PRs and FX editor native PR #731 not modified.

Qualification pending: base main@089e35e381ad2784a4cbe49c2c2554f7fbc72914, head 06eb6f081328e8f48823d0c03447de4015177105. Fast UI/Native checks then one exact-head Chromium milestone and required merge gate must PASS before protected squash. Not a Windows hardware FAT or installed release.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T13:53:57.135397Z 06eb6f0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff4ff3f
Status: ✅  Deploy successful!
Preview URL: https://38eb8b4b.arsonmix.pages.dev
Branch Preview URL: https://refactor-g-mv31-exact-fx-edi.arsonmix.pages.dev

View logs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 06eb6f0813

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui ff4ff3f

@masarray
masarray merged commit 3b9f9e2 into main Nov 19, 2026
37 checks passed

Copy link
Copy Markdown
Owner Author

G-MV31 FINAL — MERGED main (2026-11-19)

User outcome: Automatic openVerifiedInsertedFx editor click scheduled after an accepted ChannelId or .smix FX insert now retains an immutable lease and verifies it again immediately before microtask dispatch. The lease includes exact uint64 ChannelId, slot/FX instance/catalog, native graph + roster revisions, authority and physical epoch + hardware configuration, or exact offline workspace token. Reconnect, physical remap, FX replacement, a different roster, or .smix workspace switch prevents opening an old FX editor in the new context. Manual ChannelId/logical clicks use the same pure ViewModel plan; manual M4 editor admission is now in fxRackVM.m4EditorPlan instead of the bridge's retired verifiedFxFor, requiring the exact installed M4 route+device before native HWND open.

Real status: Protected squash MERGED MAIN at 3b9f9e26fb5cd67ae7d07103a31016806b96c851 after PR head ff4ff3fec4cb6aa47f197122c4bd6a249db6b4a6 qualified. Exactly four GUI/test files changed: web/approved-fx-rack-view-model.js, web/approved-native-bridge.js, tests/approved_native_m2_contract.test.cjs, tests/rc_operator_workflow_contract.test.mjs. Native PCM, JUCE, CMake, ASIO, CSS/PNG /preview/ visuals and transport envelope unchanged. No second JS state authority or audio callback.

Verified evidence: exact-head Fast UI PASS #44538059682, Fast Native PASS #44538059751, Full Chromium /preview/ PASS #44538484891; ArSonMix / Required CI Merge Gate actual commit status SUCCESS, published by #44540448259. An older source-contract assertion initially failed from the retired bridge function; fixed and rerun before the expensive browser gate. Codex review finding about those outdated assertions answered and resolved. The workflow_dispatch gate-refresh issue remains separately tracked in #823: we reran only the already-successful Fast UI job to refresh the protected status; no check was bypassed.

Nonclaims: post-merge main@3b9f9e26 UI #44540602626 and native #44540602474 were still in progress on final audit. Not an installer, not a physical ASIO hardware FAT, not a public release. I/O #825/#816 and native FX editor #731 were not modified.

Next G-MV: rationalize repeated M4 host-admission checks across FX Power/Insert/Editor into one pure lease admission core, and/or extract remaining confirmed FX lifecycle without growing bridge/controller state. Operator action: TIDAK PERLU MELAKUKAN APA-APA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant