Skip to content

refactor(gui G-MV33): one M4 FX host authority, hardware lease and first-ACK-wins - #827

Merged
masarray merged 4 commits into
mainfrom
refactor/g-mv33-unified-m4-fx-host-leases-20261119
Nov 19, 2026
Merged

masarray merged 4 commits into
mainfrom
refactor/g-mv33-unified-m4-fx-host-leases-20261119

Conversation

@masarray

Copy link
Copy Markdown
Owner

G-MV33 — one M4 FX host authority + exact hardware lease / first-ACK-wins

Base: main@3b9f9e26fb5cd67ae7d07103a31016806b96c851. Current source head: c0b5eb8ec1e139e03f51a0389830cdcec2594b0b.

User-visible reliability improvement

  • Physical legacy M4 FX Rack ON/OFF, slot bypass, insert and editor now consult the same pure m4FxHost admission gate, rather than three diverging bridge-adjacent rules.
  • Host checks exact native M4 authority, accepted routing epoch/revision, 10-channel M4 roster, safe host numeric tokens, ChannelId ownership exclusion, retained/offline status and slot ordinal validity.
  • The three physical pending FX flows now capture the already-approved canonical driver sample-rate/buffer/input/output pin fingerprint from protocol.nativeHardwareConfiguration. An in-flight rack/slot/insert cannot confirm using readback from a same-epoch pin/rate/buffer remap. Missing physical hardware fingerprint fails closed for live actions. Historic pure fixtures without the extra option preserve legacy shape.
  • For M4 Rack, Slot and Insert, first correlated positive ACK wins; a late duplicate or contradictory negative ACK cannot discard the pending independent PCM verification. First negative ACK still rejects, and ACK contents are never trusted as installed FX inventory.
  • The bridge still owns ONE native IPC dispatch, pending maps, timers, and independent v6 snapshot settlement. Pure FX VM contains no DOM/timer/IPC or accepted audio state. Never automatically arm MAIN.

Tests and compatibility

Qualification (fail-closed)

Source committed. Fast UI and Fast Native PENDING; exact-head full Chromium /preview/ and Codex review NOT RUN. Do not merge until exact final source SHA has fast contracts, relevant UI gate, review, Required CI Merge Gate success and fresh main reconciliation. Windows hardware FAT NOT RUN; no installer and no product release claim.

Operator: no action needed during code review; existing main remains the shipped development baseline.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: c3d05b6
Status: ✅  Deploy successful!
Preview URL: https://b3e8ae81.arsonmix.pages.dev
Branch Preview URL: https://refactor-g-mv33-unified-m4-f.arsonmix.pages.dev

View logs

@masarray
masarray marked this pull request as ready for review November 19, 2026 14:42
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T14:56:45.665572Z c3d05b6 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui f2d70cb

Copy link
Copy Markdown
Owner Author

@codex review

Exact current integration HEAD: c3d05b6cab6ed68b5f53bf95eee04301ea40ead9. Please review the reconciled main tree (includes IO-2 #816) and the four-file G-MV33 source diff. Previous review was for f2d70cb; no stale-review acceptance.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui c3d05b6

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: c3d05b6cab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@masarray
masarray merged commit 9a62f6d into main Nov 19, 2026
37 checks passed

Copy link
Copy Markdown
Owner Author

G-MV33 FINAL — MERGED main · 19 Nov 2026

HASIL UNTUK PENGGUNA: Perintah FX Rack ON/OFF, bypass insert, VST3 Insert dan Editor pada kompatibilitas fisik M4 kini menggunakan satu admission m4FxHost pure ViewModel (tanpa pengulangan pengecekan otoritas yang berbeda). Pending FX Rack/Slot/Insert mengunci fingerprint konfigurasi hardware yang diterbitkan oleh protocol native, sehingga pergantian pin/rate/buffer pada epoch yang sama tidak dapat mengesahkan FX lama. ACK positif pertama tidak dapat dibatalkan oleh ACK negatif duplikat; ACK tetap bukan bukti FX terpasang sampai readback PCM independen cocok. Slot malformed/missing ditolak.

STATUS NYATA: kode + regresi ditulis, review dan exact-head UI/native PASS, MERGED MAIN pada squash 9a62f6d6a8d1579c0ec42dca756b051d263ff069. Qualified head c3d05b6cab6ed68b5f53bf95eee04301ea40ead9, tree identik a173fead6179aa3cc336d6680450728ecb832ee7. Full Chromium #44549265463 SUCCESS; fast UI #44548938960 PASS, fast native #44548938974 PASS; exact SHA Codex code review COMPLETED, zero findings; protected Required CI Merge Gate SUCCESS. Status publisher workflow_dispatch issue #823 was handled without bypass: reran only successful Fast UI PR job after qualified Chromium.

INTEGRASI AMAN: IO-2 #816 advanced main during qualification. Explicit disjoint reconciliation used a two-parent commit and main-derived tree, preserving all IO-2 native/C++ files and only 4 G-MV33 GUI/test files in the feature diff. No engine C++, PCM/VST3 rendering, ASIO callback, CMake, approved /preview/ assets, .smix schema or physical output ARM changed.

AMAN DIPAKAI? Existing development main now contains the improvement; BELUM an installed field-certified binary/release. Post-merge UI #44551440260 and Native #44551440232 are IN PROGRESS at this checkpoint. Physical ASIO FAT / installed Windows release: NOT RUN / NOT PUBLISHED by this PR.

TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA.

LANGKAH BERIKUTNYA: audit remaining FX lifecycle bridge decisions and precise M4/ChannelId native editor transactions; integrate future qualified IO-2C device sources only after their native readback is merged. Preserve one accepted PCM graph and exact native ACK/readback, avoid micro-PR cosmetic splits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant