Skip to content

refactor(gui): Channel Strip SOURCE/OUT presentation and readback (GUI-1) - #769

Merged
masarray merged 4 commits into
mainfrom
refactor/gui1-channel-strip-presentation-20261118
Nov 18, 2026
Merged

masarray merged 4 commits into
mainfrom
refactor/gui1-channel-strip-presentation-20261118

Conversation

@masarray

Copy link
Copy Markdown
Owner

GUI-1 — one meaningful presentation vertical slice

Baseline: merged native Device Setup #767 (main@3fb4c17cc4e8a6d4c23ee3fd229aceb67e216be9); duplicate alternative #768 is CLOSED, not merged. Unique #768 safety scenarios have been reviewed and minimally forward-ported without adopting its draft architecture.

What shipped in this PR:

  • One pure approved-channel-strip-view-model.js owns physical IN picker, external OUTPUT picker, MAIN/BUS/SOURCE ONLY labels and identity-safe ChannelId target naming. Replaces corresponding per-strip option constructors and primary-out display mapping in approved-native-bridge.js.
  • Readback projection is pure, derived from installed source and primary destination; no JS source or graph-authoritative store.
  • Pending EXTERNAL OUT resolution is now a pure testable function: ACK alone cannot claim LIVE or clear pending, wrong stereo pins cannot clear, new device epoch invalidates a stale request; existing one bridge-side Map/dispatcher remains.
  • The native-only JUCE/WebView2 assembled /preview/ bundle loads the Channel Strip VM before bridge; public /preview/ and HTML/CSS/PNGs stay unchanged.
  • Exact small safety repair to merged refactor(mvvm): one native Device Setup draft and selection ViewModel #767: combined-device output selection synchronizes input+output, stale pin/rate/buffer draft resets, one-pin physical Apply cannot be submitted, and the shared native pin readback selector is used for request masks. No duplicate Device Setup reducer.
  • Isolated tests for label collisions/reserved names, exact uint64 ids, SOURCE ONLY, stale physical pins, ACK/readback pending, combined JUCE device, one-pin reject; native bundle parity and cold-start Chromium injection.

Measured source change: bridge 4190 → 4153 lines (-37) with original inline picker/readback/pending responsibility removed. Pure strip selector is 96 lines. 7 files changed; zero C++/DSP/PCM/VST3 changes. Device Setup original #767 VM remains the ONLY draft/Apply owner; native dispatcher unchanged.

Qualification before merge: fast UI/native contracts, actual native-assembled full Chromium exact HEAD, exact merge-gate; CI/Windows/hardware not presumed. Superseded #768 full Chromium run 44197725729 succeeded for its own SHA but is not proof of GUI-1. No physical dual-ASIO or acoustic FAT and no consumer installer built.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: f59f483
Status: ✅  Deploy successful!
Preview URL: https://5d1aa61a.arsonmix.pages.dev
Branch Preview URL: https://refactor-gui1-channel-strip.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 5bb5d3a

@masarray
masarray marked this pull request as ready for review November 17, 2026 23:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T23:43:16.994785Z 5bb5d3a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

GUI-1 cross-thread reconciliation — exact source verified (2026-11-18)

MV-2 canonical implementation is merged PR #767 (3fb4c17cc4e8a6d4c23ee3fd229aceb67e216be9), with PR #768 closed unmerged as an overlapping alternative. This GUI-1 branch takes only the reviewed unique duplex-output/one-pin safety corrections; one existing Device Setup reducer and one arMixAction Apply dispatcher remain.

GUI-1 branch was reconciled non-force from 5bb5d3a06a398c5460e08efbb8eb79d675ab9f8c to f59f483a7901902c3dea1d033b50b2f3a1a13bf5 with main 3d133d8614ca6f2b4c231e96cdc2613bf23ddb90, retaining concurrent independent IO-0 C++ files. Main-vs-PR comparison behind=0, GUI delta remains 8 files (no C++/ASIO/DSP/CSS/PNG).

At reconciled SHA fast UI PASS 44223460997, fast native Node/Python + PCM golden PASS 44223461145, release contracts PASS 44223460990. Original GUI-1 full native assembled Chromium PASS at 5bb5d3a 44200351195; requalify exact reconciled SHA before merge. Physical Windows/ASIO, installer and speaker listening NOT RUN. No second feature implementation was created.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui f59f483

@masarray
masarray merged commit c733b10 into main Nov 18, 2026
30 checks passed

Copy link
Copy Markdown
Owner Author

FINAL GUI-1 — MERGED MAIN (18 November 2026)

HASIL: One real native /preview/ Channel Strip SOURCE/OUTPUT presentation module web/approved-channel-strip-view-model.js now owns pure physical-source/source-only/output-target options, safe duplicate/reserved-label handling with exact ChannelId strings, installed source/primary destination readback and pending EXTERNAL OUT reconciliation. Removed the old repeated selection/readback/pending presentation rules from web/approved-native-bridge.js. The bridge remains the original DOM binder and one native event dispatcher; native source graph/session/PCM untouched. scripts/build_approved_native_gui.py packs the module, and tests assert assembled native bundle parity. Existing Device Setup #767 is still the only draft/Apply authority. #768 was closed unmerged; its unique duplex selection and one-pin safety fixes were reviewed and forward-ported minimally rather than merging parallel reducers.

STATUS: SUDAH MERGED KE MAIN. PR #769 reviewed head f59f483a7901902c3dea1d033b50b2f3a1a13bf5, final squash merge/main SHA c733b102718ad7203e8e27094d76b037b1149de6. Source updated after a safe non-force merge of concurrent IO-0 C++ commit (no GUI file conflicts; no branch clobber).

Bukti: 8 changed files, new 95-line pure Channel Strip VM; existing native bridge 4190→4153 (-37 net) with former render/choice/pending rules removed; ~137 added Node contract lines, packaged native GUI bundle and cold-start tests. At final reviewed branch SHA: fast UI PASS 44223460997, fast native contracts PASS 44223461145, release contracts PASS 44223460990, FULL Chromium native /preview/ PASS 44223701543, required merge status SUCCESS republished by non-bypass gate run 44223456113. Branch protection was respected. ZERO C++/DSP/VST3/CSS/HTML/PNG changes from GUI-1. Regression risks corrected: invalid non-separate capture/playback mismatch, same-device one-output-pin Apply, stale physical output pending conditions. No observed new CI failures at reconciled exact HEAD.

AMAN DIPAKAI?: YA as verified source baseline in main, BELUM claimed as newly installed Windows EXE or physically measured audio. Hardware/FAT/installer NOT RUN for presentation-only GUI-1. No new secondary ASIO capability and no speaker auto-arm.

TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA.

BERIKUTNYA: GUI-2 FX Rack presentation on latest main after rechecking active PR #731 FX Editor and other FX-related branches. Preserve plugin instance identity, native editor lifecycle, bypass/ACK and native PCM authority. Do not resume Device Setup or open second GUI-1 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant