Repository navigation
refactor(gui): Channel Strip SOURCE/OUT presentation and readback (GUI-1) - #769
Conversation
Deploying arsonmix with
|
| Latest commit: |
f59f483
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5d1aa61a.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-gui1-channel-strip.arsonmix.pages.dev |
|
/arsonmix-ci ui 5bb5d3a |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
GUI-1 cross-thread reconciliation — exact source verified (2026-11-18)MV-2 canonical implementation is merged PR #767 ( GUI-1 branch was reconciled non-force from At reconciled SHA fast UI PASS 44223460997, fast native Node/Python + PCM golden PASS 44223461145, release contracts PASS 44223460990. Original GUI-1 full native assembled Chromium PASS at |
|
/arsonmix-ci ui f59f483 |
FINAL GUI-1 — MERGED MAIN (18 November 2026)HASIL: One real native STATUS: SUDAH MERGED KE MAIN. PR #769 reviewed head Bukti: 8 changed files, new 95-line pure Channel Strip VM; existing native bridge 4190→4153 (-37 net) with former render/choice/pending rules removed; ~137 added Node contract lines, packaged native GUI bundle and cold-start tests. At final reviewed branch SHA: fast UI PASS 44223460997, fast native contracts PASS 44223461145, release contracts PASS 44223460990, FULL Chromium native AMAN DIPAKAI?: YA as verified source baseline in main, BELUM claimed as newly installed Windows EXE or physically measured audio. Hardware/FAT/installer NOT RUN for presentation-only GUI-1. No new secondary ASIO capability and no speaker auto-arm. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA. BERIKUTNYA: GUI-2 FX Rack presentation on latest main after rechecking active PR #731 FX Editor and other FX-related branches. Preserve plugin instance identity, native editor lifecycle, bypass/ACK and native PCM authority. Do not resume Device Setup or open second GUI-1 PR. |
GUI-1 — one meaningful presentation vertical slice
Baseline: merged native Device Setup #767 (
main@3fb4c17cc4e8a6d4c23ee3fd229aceb67e216be9); duplicate alternative #768 is CLOSED, not merged. Unique #768 safety scenarios have been reviewed and minimally forward-ported without adopting its draft architecture.What shipped in this PR:
approved-channel-strip-view-model.jsowns physical IN picker, external OUTPUT picker, MAIN/BUS/SOURCE ONLY labels and identity-safe ChannelId target naming. Replaces corresponding per-strip option constructors and primary-out display mapping inapproved-native-bridge.js./preview/bundle loads the Channel Strip VM before bridge; public/preview/and HTML/CSS/PNGs stay unchanged.Measured source change: bridge 4190 → 4153 lines (-37) with original inline picker/readback/pending responsibility removed. Pure strip selector is 96 lines. 7 files changed; zero C++/DSP/PCM/VST3 changes. Device Setup original #767 VM remains the ONLY draft/Apply owner; native dispatcher unchanged.
Qualification before merge: fast UI/native contracts, actual native-assembled full Chromium exact HEAD, exact merge-gate; CI/Windows/hardware not presumed. Superseded #768 full Chromium run 44197725729 succeeded for its own SHA but is not proof of GUI-1. No physical dual-ASIO or acoustic FAT and no consumer installer built.