Repository navigation
refactor(mvvm): native FX Rack scalar/readback presentation ViewModel (GUI-2) - #773
Conversation
…ter in native bridge
…le approved /preview/
…regression harnesses
…regression harnesses
…ce matching and missing-value rejection
… instance controls
|
/arsonmix-ci ui 1b3d124 |
Deploying arsonmix with
|
| Latest commit: |
1b3d124
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://78625036.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-mvvm-native-fx-rack.arsonmix.pages.dev |
GUI-2 owner checkpoint — native FX Rack readback MVVM (2026-11-18)HASIL: Pure STATUS: KODE DIBUAT / Fast CI KODE DIUJI, PR #773 OPEN DRAFT, NOT YET MERGED. Exact SHA Proof: Fast Native 44226458270 PASS; Fast UI 44226458272 PASS; release contracts 44226458265 PASS; Required Merge Gate 44226458509 PASS. FULL exact-SHA Chromium 44226621568 IN PROGRESS, including native-assembled FX/fader tests; do not mark PASS before completion. Physical hardware / Windows MSVC / installer / acoustic FAT NOT RUN (no native code changes). AMAN DIPAKAI? Safe source-only presentation isolation, not proof of new installer or physical audio. Installed FX engine/PCM path unchanged. No demo LIVE authority. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA. LANGKAH BERIKUTNYA: finish same-SHA Chromium; only if PASS and main reconciled, make Ready and merge. Next separate vertical slice is WIRE selectors/readback or MV-3 native snapshot consolidation without duplicating the accepted graph. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
OWNER DELIVERY — GUI-2 FX Rack Modular MVVM • 18 November 2026HASIL: Native approved STATUS: MERGED MAIN, PR #773 squash commit AMAN DIPAKAI? YA for the merged source-only GUI presentation refactor under the existing approved application; BELUM as a new installer/hardware-qualified build. Audio DSP/native device and .smix unchanged. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA. BUKTI: Fast Native 44226458270 PASS, Fast UI 44226458272 PASS, Full exact-head Chromium native assembled 44226621568 PASS (109/109 steps), Required Merge Gate SUCCESS before squash merge, merge HEAD LANGKAH BERIKUTNYA: Separate GUI-3/WIRE or MV-3 native read-model consolidation, preserving one accepted ChannelId/EdgeId graph and no duplicate transport. Independent IO-1 native capture PR #771 untouched; it has its own MSVC/hardware evidence. |
GUI-2 — Native FX Rack readback ViewModel, one accepted DSP/PCM authority
Milestone (implementation, not docs): Extract rack/global/individual-insert power and label/latency projection from the 4,153-line
web/approved-native-bridge.jsinto pureweb/approved-fx-rack-view-model.js. A second pure function verifies that every mounted FX control belongs to the exact accepted nativeinstanceId + slotbefore ANY DOM write. The bridge is now the DOM adapter; it retains the same native ACK/request dispatcher and never owns DSP/VST3/session state. On stale or replaced FX instance it returns false, invoking the existing structural re-projection from the accepted graph.Delivered source
web/approved-fx-rack-view-model.js—powerReadbackandmountedRackMatches. Only passed native snapshot determines rack enabled, global bypass, independent per-slot bypass/effective flags, header/slot labels and latency warning. Missing/incomplete readback isnull, not a fabricated ON. No DOM, callback, state storage or dispatch.web/approved-native-bridge.js— removed old bypass/effective/label policy and inline instance-mount matcher, paints the pure projection only. Existing GAIN/SOF alternate views, virtualized banks, held faders, focus, and exact slot-power button identity remain unchanged. Rejects noncanonical DOM slot tokens and changed instance owner before writing.scripts/build_approved_native_gui.py— adds the VM before bridge only in the existing native-assembled /preview/ bundle, not public Pages. Asset byte parity and HTML reversal remain.tests/approved_native_m2_contract.test.cjs— pure scenario coverage for rack-vs-slot-vs-global power, missing native fields, readback immutability, latency metadata, wrong/stale/duplicate slot ids, and refactor boundary. Existing comprehensive mounted DOM / negative ACK and still-captured fader regression retained.tests/live_fader_held_drag.test.cjs,tests/approved_native_gui_bundle_test.py,tests/approved_native_cold_start_smoke.py— existing harness receives the VM, verifies native-only injection and actual assembled Chromium VM.Measured delta from branch base: bridge 4,153 → 4,133 lines (about 20 responsibility lines removed); one 68-line pure VM. Feature commands are unchanged, removed old combined selector/painter decision; no duplicate source-of-truth. No C++, ASIO/PCM, FX processing, signal routing, .smix, CSS, HTML layout, SonKu/ImmerSIB or plugin editor modifications.
Conflict avoidance: #769 GUI-1 already merged in
main@c733b102718ad7203e8e27094d76b037b1149de6; #768 duplicate closed unmerged; independent #771 IO-1 C++ keeps its branch untouched. This branch starts on latest merged GUI-1.Verification requirement: Fast native/fast UI Node+Python on exact HEAD, then one explicit full Chromium native-/preview/ on final SHA before merge. C++ unchanged: MSVC/CTest not required. Physical ASIO, installer, audio FAT NOT RUN, this PR does not claim new audio features. Do not merge until exact-head required gate and CI pass.
Owner-facing HASIL: FX rack readback code separated into testable pure model, native controls unchanged. STATUS: KODE DIBUAT / CI PENDING. AMAN DIPAKAI? not as a new installer, source scope presentation-only. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA. LANGKAH BERIKUTNYA: fix any deterministic/Chromium regressions, merge, then continue WIRE readback selectors without second graph.