Repository navigation
Conversation
This was referenced Oct 28, 2026
This was referenced Oct 28, 2026
moetemp
force-pushed
the
moe/up/resource-binding-types
branch
from
October 29, 2026 04:00
d9ed245 to
8d7b2b8
Compare
moetemp
force-pushed
the
moe/up/python-empty-request-signature
branch
2 times, most recently
from
October 29, 2026 06:28
8765209 to
8045102
Compare
moetemp
force-pushed
the
moe/up/resource-binding-types
branch
from
October 29, 2026 06:28
8d7b2b8 to
5c24067
Compare
moetemp
force-pushed
the
moe/up/python-empty-request-signature
branch
from
October 29, 2026 07:00
8045102 to
93e1d90
Compare
moetemp
force-pushed
the
moe/up/resource-binding-types
branch
from
October 29, 2026 07:00
5c24067 to
33695de
Compare
Python renders a bare `*` with no keyword parameter after it, in the user-service client method and in the type-showcase operation function. So those files don't parse, and the Python output keeps its previous content.
Python refuses a bare `*` with no parameter after it. An unpacked operation with an empty request rendered one, in the client of a service with no endpoint and in an operation function. The user-service client generates its `notify_all` method, and type-showcase its `ping` function.
moetemp
force-pushed
the
moe/up/resource-binding-types
branch
from
October 29, 2026 07:35
33695de to
a27caee
Compare
moetemp
force-pushed
the
moe/up/python-empty-request-signature
branch
from
October 29, 2026 07:35
93e1d90 to
9ec3d43
Compare
Contributor
Author
|
Closing this. The Streams stack doesn't need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR removes the bare
*from a Python operation signature with no parameters, in<Service>Clientmethods and in operation functions.The first commit adds an operation with an empty request to
user-service, which has no endpoint, and totype-showcase, which has one, with today's output. Python has no output for them in that commit, since their files don't parse. The second commit is the fix.It replaces moetemp#71.
It's based on #309.
Why?
async def notify_all(self, *,)is aSyntaxError, so the module doesn't parse.How did you test it?
Link to a test plan if any -
The Python tests of
user-serviceandtype-showcasecall the new methods from a Workflow through a real Nexus endpoint.