Skip to content

feat(python): add RPC options to client calls - #82

Closed
moetemp wants to merge 1 commit into
moe/up/stream-writer-syncfrom
moe/up/python-rpc-options
Closed

moetemp wants to merge 1 commit into
moe/up/stream-writer-syncfrom
moe/up/python-rpc-options

Conversation

@moetemp

@moetemp moetemp commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

What changed?

This PR adds the RPC options to the Python client calls.

  • Each client call and each method of a client resource takes rpc_metadata and rpc_timeout, and passes them to the start_operation of its Nexus client.
  • nexgen refuses a request field or a method parameter with one of these names in the client target.

TypeScript and .NET get the options in a follow-up PR.

Why?

The proposal has rpc_metadata and rpc_timeout on every call, as the Temporal client does.

How did you test it?

Link to a test plan if any -

  • Unit Tests
  • Staging
  • End to End Tests

The client-target and stream client tests check that the options reach start_operation. A fixture checks a request field with one of the names.

@moetemp
moetemp force-pushed the moe/up/python-rpc-options branch from 803aadb to dffa48a Compare October 29, 2026 04:00
@moetemp
moetemp force-pushed the moe/up/resource-definition branch 2 times, most recently from a5d352a to 1fd4ea6 Compare October 31, 2026 13:08
@moetemp
moetemp force-pushed the moe/up/python-rpc-options branch from dffa48a to 3886769 Compare October 31, 2026 13:08
@moetemp moetemp changed the title feat(python): return a client call's result, with its RPC options feat(python): add RPC options to client calls Oct 31, 2026
@moetemp
moetemp force-pushed the moe/up/resource-definition branch from 1fd4ea6 to 5bd1eef Compare November 3, 2026 15:22
@moetemp
moetemp force-pushed the moe/up/python-rpc-options branch 2 times, most recently from 1aa317f to dc14c2d Compare November 4, 2026 09:34
@moetemp
moetemp force-pushed the moe/up/resource-definition branch from 5bd1eef to 5e46777 Compare November 4, 2026 09:34
@moetemp
moetemp changed the base branch from moe/up/resource-definition to moe/up/stream-sample-sync November 5, 2026 04:29
@moetemp
moetemp force-pushed the moe/up/python-rpc-options branch 2 times, most recently from d6c9b34 to 84e4b1a Compare November 5, 2026 07:27
@moetemp
moetemp force-pushed the moe/up/stream-sample-sync branch from 1262c4a to 059773b Compare November 5, 2026 07:27
Each client call and client resource method takes `rpc_metadata` and `rpc_timeout`, and passes
them to the `start_operation` of its Nexus client.
@moetemp
moetemp force-pushed the moe/up/python-rpc-options branch from 84e4b1a to cddac5b Compare November 5, 2026 22:22
@moetemp
moetemp changed the base branch from moe/up/stream-sample-sync to moe/up/stream-writer-sync November 5, 2026 22:23
@moetemp

moetemp commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

Replaced by temporalio#366.

@moetemp moetemp closed this Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant