Repository navigation
Conversation
This was referenced Oct 28, 2026
moetemp
force-pushed
the
moe/up/field-flatten
branch
from
October 29, 2026 04:00
427d8be to
e185234
Compare
moetemp
force-pushed
the
moe/up/source-targets
branch
from
October 29, 2026 04:00
4ad0591 to
0b8405f
Compare
1 of 3 tasks
moetemp
force-pushed
the
moe/up/field-flatten
branch
from
October 31, 2026 13:08
e185234 to
f4435b6
Compare
moetemp
force-pushed
the
moe/up/source-targets
branch
from
October 31, 2026 13:08
0b8405f to
f76c7e1
Compare
moetemp
force-pushed
the
moe/up/source-targets
branch
from
November 3, 2026 15:22
f76c7e1 to
b020739
Compare
moetemp
force-pushed
the
moe/up/field-flatten
branch
from
November 3, 2026 15:22
f4435b6 to
3bbac1d
Compare
moetemp
force-pushed
the
moe/up/source-targets
branch
from
November 4, 2026 09:34
b020739 to
bf06cd9
Compare
moetemp
force-pushed
the
moe/up/field-flatten
branch
2 times, most recently
from
November 5, 2026 05:19
7731e40 to
751ad5b
Compare
moetemp
force-pushed
the
moe/up/source-targets
branch
from
November 5, 2026 05:19
bf06cd9 to
41d2f1d
Compare
moetemp
force-pushed
the
moe/up/field-flatten
branch
from
November 5, 2026 07:27
751ad5b to
b5dafd5
Compare
moetemp
force-pushed
the
moe/up/source-targets
branch
from
November 5, 2026 07:27
41d2f1d to
2ece8b5
Compare
`@nexus.flatten-in-api fields="..."` on a field makes the call take those fields of its record. The Stream create takes the id and the backend of its ref this way.
moetemp
force-pushed
the
moe/up/source-targets
branch
from
November 5, 2026 22:22
2ece8b5 to
d7b69f0
Compare
moetemp
force-pushed
the
moe/up/field-flatten
branch
from
November 5, 2026 22:22
b5dafd5 to
6c9b2f1
Compare
Owner
Author
|
Moved to temporalio#368, on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR lets
@nexus.flatten-in-apiapply to a field, so a call takes only some fields of that field's record.record create-stream-request { /// @nexus.flatten-in-api fields="id backend" stream-ref: stream-ref, }fieldslists the fields of the record that become parameters of the call, and the call builds the record from them.fields. The field can't also have a source, a default, an api-omit or@nexus.omit.Why?
The proposal has
client.create_stream[T](id, *, backend=None), and the create request has the id and the backend in itsstream_ref. A record-level flatten would promote every field ofStreamRefin every request that has one.How did you test it?
Link to a test plan if any -
The Python, TypeScript and .NET tests check the ref of a Stream create. Fixtures cover the refused flattens.