Repository navigation
Conversation
This was referenced Oct 28, 2026
moetemp
force-pushed
the
moe/up/field-flatten
branch
from
October 29, 2026 04:00
427d8be to
e185234
Compare
moetemp
force-pushed
the
moe/up/resource-factory
branch
2 times, most recently
from
October 31, 2026 13:08
3e97846 to
ff120ff
Compare
moetemp
force-pushed
the
moe/up/field-flatten
branch
from
October 31, 2026 13:08
e185234 to
f4435b6
Compare
moetemp
force-pushed
the
moe/up/resource-factory
branch
from
November 3, 2026 15:22
ff120ff to
c0e998f
Compare
moetemp
force-pushed
the
moe/up/field-flatten
branch
from
November 4, 2026 09:34
3bbac1d to
7731e40
Compare
moetemp
force-pushed
the
moe/up/resource-factory
branch
from
November 4, 2026 09:34
c0e998f to
242c137
Compare
moetemp
force-pushed
the
moe/up/field-flatten
branch
from
November 5, 2026 05:19
7731e40 to
751ad5b
Compare
moetemp
force-pushed
the
moe/up/resource-factory
branch
2 times, most recently
from
November 5, 2026 07:27
801829b to
de23557
Compare
moetemp
force-pushed
the
moe/up/field-flatten
branch
from
November 5, 2026 07:27
751ad5b to
b5dafd5
Compare
Workflow code builds a handle on an existing Stream with the factory, from an id and a backend.
moetemp
force-pushed
the
moe/up/field-flatten
branch
from
November 5, 2026 22:22
b5dafd5 to
6c9b2f1
Compare
moetemp
force-pushed
the
moe/up/resource-factory
branch
from
November 5, 2026 22:22
de23557 to
097799a
Compare
Owner
Author
|
Replaced by temporalio#373. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds a Workflow factory for each Python resource.
get_<resource>factory of Add independent Python client generation and explicit API targets temporalio/nexgen#344 takes the flattened fields and the runtime types, as inclient.get_stream(id="s1", body_type=Turn). The Workflow package exports a factory with the same name, as instream_service.get_stream(id="s1", body_type=Turn). When an operationget_<resource>already returns the resource, asget-senderof thedefaultssample does, the resource gets no factory. nexgen refuses any other operation with the factory's name. A factory makes no call.@nexus.flatten-in-api param="ref" fields="id backend" keep=trueon a resource lets the factory take fields of one constructor parameter, or the whole value. Soid="s1"andref=refboth work.TypeScript and .NET get the resource flatten on their factories in a follow-up PR.
Why?
The proposal builds a Stream with no call, like
get_workflow_handle, from an id and a backend or from a whole ref. The ref is data, and code turns it into a Stream explicitly, so no converter turns a payload into a resource.How did you test it?
Link to a test plan if any -
Python tests build Streams with both factories, from the fields of the flattened parameter and from the whole value.