Repository navigation
Conversation
This was referenced Oct 28, 2026
moetemp
force-pushed
the
moe/up/python-rpc-options
branch
from
October 29, 2026 04:00
803aadb to
dffa48a
Compare
moetemp
force-pushed
the
moe/up/source-targets
branch
from
October 29, 2026 04:00
4ad0591 to
0b8405f
Compare
1 of 3 tasks
Owner
Author
|
Closing. temporalio#344 already lets |
Owner
Author
|
Reopened. On top of temporalio#346 we may still need three of its rules: the private request methods fill unset sources, a source can read a create's |
moetemp
force-pushed
the
moe/up/source-targets
branch
from
October 31, 2026 13:08
0b8405f to
f76c7e1
Compare
moetemp
force-pushed
the
moe/up/source-targets
branch
from
November 3, 2026 15:22
f76c7e1 to
b020739
Compare
moetemp
force-pushed
the
moe/up/python-rpc-options
branch
2 times, most recently
from
November 4, 2026 09:34
1aa317f to
dc14c2d
Compare
moetemp
force-pushed
the
moe/up/source-targets
branch
from
November 4, 2026 09:34
b020739 to
bf06cd9
Compare
moetemp
force-pushed
the
moe/up/python-rpc-options
branch
from
November 5, 2026 05:19
dc14c2d to
d6c9b34
Compare
moetemp
force-pushed
the
moe/up/source-targets
branch
from
November 5, 2026 05:19
bf06cd9 to
41d2f1d
Compare
@nexus.api-omit to some targets
moetemp
force-pushed
the
moe/up/python-rpc-options
branch
from
November 5, 2026 07:27
d6c9b34 to
84e4b1a
Compare
moetemp
force-pushed
the
moe/up/source-targets
branch
from
November 5, 2026 07:27
41d2f1d to
2ece8b5
Compare
A field can leave the API of one target and take a source in another. A call of a target that omits a required list sends it empty.
moetemp
force-pushed
the
moe/up/source-targets
branch
from
November 5, 2026 22:22
2ece8b5 to
d7b69f0
Compare
moetemp
force-pushed
the
moe/up/python-rpc-options
branch
from
November 5, 2026 22:22
84e4b1a to
cddac5b
Compare
Owner
Author
|
Moved to temporalio#371, on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR lets
@nexus.api-omitomit a field from some targets only.@nexus.api-omit targets="workflow"drops the field from the Workflow API only. Here the client target fills it from its own source.list<T>. A Python, TypeScript or .NET call that omits it sends it empty.@nexus.name, its optionality and itsLongtype.In the stream sample, the Workflow read takes no
last.Why?
A Workflow read can't take
last, since replay needs a fixed range, while a client read can.How did you test it?
Link to a test plan if any -
Python, TypeScript and .NET tests check the filled requests, and fixtures cover the refused combinations.