Repository navigation
Conversation
This was referenced Oct 28, 2026
This was referenced Oct 28, 2026
This was referenced Oct 28, 2026
moetemp
force-pushed
the
moe/up/python-render-targets
branch
from
October 29, 2026 04:00
acbcec8 to
e73ff45
Compare
moetemp
force-pushed
the
moe/up/system-nexus-generic-interceptors
branch
from
October 29, 2026 04:00
5c03b49 to
e3c7d8a
Compare
moetemp
force-pushed
the
moe/up/python-render-targets
branch
from
October 29, 2026 06:28
e73ff45 to
f6b2ea8
Compare
moetemp
force-pushed
the
moe/up/system-nexus-generic-interceptors
branch
2 times, most recently
from
October 29, 2026 07:00
0fe04d5 to
3c0cbb6
Compare
moetemp
force-pushed
the
moe/up/python-render-targets
branch
from
October 29, 2026 07:00
f6b2ea8 to
2196319
Compare
The operation renderers that the client target shares take a `PythonTarget` and start each line at its indent. The client target can then render the same operations as methods, with no thread-local flag and no re-indented text. Only services with an endpoint reach these renderers, so their branches for a service with no endpoint are gone. The output doesn't change.
moetemp
force-pushed
the
moe/up/system-nexus-generic-interceptors
branch
from
October 29, 2026 07:35
3c0cbb6 to
fd062d3
Compare
moetemp
force-pushed
the
moe/up/python-render-targets
branch
from
October 29, 2026 07:35
2196319 to
08e197f
Compare
Contributor
Author
|
Folded into #324. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR makes the Python operation renderers that the client target shares take a target value,
PythonTarget, and start each line at that target's indent. The body indent comes from that indent, one level deeper.render_request_only_operation_functionkeeps the Workflow indents, since only the Workflow target calls it. The PR also removes the branches for a service with no endpoint, since that service's<Service>Clienthas its own renderers. The output doesn't change.It's based on #322.
Why?
#324 adds the client target, which renders the same operations as client methods. With a target value, each renderer that depends on the target takes it. moetemp#54 used a thread-local flag and re-indented text instead.
How did you test it?
Link to a test plan if any -
Every sample regenerates with no change.