Repository navigation
Conversation
This was referenced Oct 28, 2026
This was referenced Oct 28, 2026
moetemp
force-pushed
the
moe/up/python-empty-request-signature
branch
from
October 29, 2026 04:00
4b930b3 to
8765209
Compare
moetemp
force-pushed
the
moe/up/python-caller-docstring-indent
branch
from
October 29, 2026 04:00
451fef4 to
78851a5
Compare
moetemp
force-pushed
the
moe/up/python-empty-request-signature
branch
from
October 29, 2026 06:28
8765209 to
8045102
Compare
moetemp
force-pushed
the
moe/up/python-caller-docstring-indent
branch
from
October 29, 2026 06:28
78851a5 to
2a68fff
Compare
moetemp
changed the title
moetemp
force-pushed
the
moe/up/python-caller-docstring-indent
branch
from
October 29, 2026 07:00
2a68fff to
c0884a7
Compare
moetemp
force-pushed
the
moe/up/python-empty-request-signature
branch
from
October 29, 2026 07:00
8045102 to
93e1d90
Compare
Python's client method takes the docstring indent of a module function, so its services.py doesn't parse and the Python output keeps its previous content.
The client of a service with no endpoint took the docstring indent of a module function, so a documented or experimental operation broke the module. The user-service client generates with the doc of `notify_all`.
moetemp
force-pushed
the
moe/up/python-caller-docstring-indent
branch
from
October 29, 2026 07:35
c0884a7 to
a5ce60d
Compare
moetemp
force-pushed
the
moe/up/python-empty-request-signature
branch
from
October 29, 2026 07:35
93e1d90 to
9ec3d43
Compare
Contributor
Author
|
Closing this. The Streams stack doesn't need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR indents the docstring of a Python
<Service>Clientmethod at the method body, not at the module function indent. A service with no@nexus.endpointgets that class.The first commit documents
notify-allinuser-servicewith today's output, and the second is the fix.It replaces moetemp#60.
It's based on #318.
Why?
A
@nexus.docor@nexus.experimentalon an operation of such a service madeservices.pyfail to parse.How did you test it?
Link to a test plan if any -
The Python
user-servicetest checks the docstring ofnotify_all.