Repository navigation
M3 FIRST REAL SOUND — wire approved GUI closed state into native bridge; fix fader commit and FX safety - #396
Conversation
…ack and pointerup owner
|
Milestone A integrator coordination: thank you for addressing native-only Pages IIFE scope and pointer fader ordering; these are genuine M3-A blockers and must be tested against the exact approved |
|
M2.5 handoff: #395 closed as redundant native controller/producer; please port only missing safety regressions from exact #395 head |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d13e0b978a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| " g.box.releasePointerCapture?.(ev.pointerId);\n", | ||
| " const g=faderGesture;faderGesture=null;\n" | ||
| " g.box.releasePointerCapture?.(ev.pointerId);\n" | ||
| " if(window.__ARMIX_NATIVE_M2__?.consumeField?.({target:g.input,type:'change'}))return;\n"), |
There was a problem hiding this comment.
Preserve Sends on Faders semantics when committing native gestures
With an admitted native graph containing a GROUP or FX_RETURN, #sofToggle still enables Sends on Faders through the original GUI handler. This new pointer-release hook nevertheless calls consumeField, which unconditionally translates level into SET_FADER; it never checks sofEnabled or the selected send destination. Consequently, moving a fader labeled SEND changes the channel's main gain instead of its send, despite toggleSof() explicitly promising that main faders are protected. Expose the active fader mode and dispatch the appropriate native send operation, or block Sends on Faders until that operation is supported.
AGENTS.md reference: AGENTS.md:L16-L16
Useful? React with 👍 / 👎.
| box?.style?.setProperty("--fader-fill",p+"%"); | ||
| box?.style?.setProperty("--fader-lit",String(p/100)); | ||
| box?.style?.setProperty("--fader-y",(100-p)+"%"); | ||
| box?.style?.setProperty("--fader-frac",String(p/100)); |
There was a problem hiding this comment.
Restore the accepted fader position when a pointer drag is canceled
If a native fader drag ends with pointercancel rather than pointerup, these new CSS updates leave the cap at the uncommitted position. The original cancellation handler in site/preview-v2/index.html only clears faderGesture, so no intent is submitted and no ACK rejection or timeout triggers the new rollback path. Subsequent unchanged native snapshots also skip projection through lastPaintedSignature, leaving the displayed gain inconsistent with accepted audio state indefinitely. Add a native cancellation hook that restores the input and cap from the accepted track state.
AGENTS.md reference: AGENTS.md:L18-L18
Useful? React with 👍 / 👎.
M3-A: actual approved GUI -> native ACK integration reliability (NOT full PCM yet)
Source branch from main@c1a11afd145380a944c9844937ccb6a97b5e0557. This preserves the sole public /preview/ HTML exactly, its approved hardware PNG assets, and one JUCE callback.
Root cause / code changes
tracks,make,render,findTrack,wireEdgesordisplayMeterDbfsbecause original Pages code executes within an IIFE. It could never project a genuine accepted native snapshot even if ENGINE [ENGINE SOLE OWNER] One native callback → full-fidelity ChannelId cutover (draft) #266 admitted one.__ARMIX_NATIVE_SCOPE__adapter inside the SAME approved GUI's existing IIFE. External bridge now maps real decimal-string ChannelId/EdgeId to this original state, with no second renderer/reducer and without JS PCM.finishFaderPointer, before original code clearsfaderGesture. Former externalwindow.pointeruplistener ran too late and silently dropped the intent.Verification gates / release truth
This code does NOT promote
productionCallbackLive, create a ChannelId engine, fake meter audio, or claim physical hardware FAT. ENGINE #266 + WIRE #387 must still be reconciled into the existingmainJUCE callback for M3-B real PCM, followed by Windows exact-SHA and physical #15 FAT. Keep DRAFT until Windows CTest, Chromium and bundle parity PASS.Related: #389, #266, #387, #270, #15.