Repository navigation
Milestone A integration gate: enforce ONLY /preview/ and genuine native ChannelId PCM admission - #398
Conversation
…in Milestone A gate
…shot in WebView bridge
… native LIVE admission
Milestone A integrator source gate — exact-head evidenceCurrent HEAD
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 688c862014
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert.equal(status(inspect(fake),'intent-dispatch-not-g0-rejection').pass,false, | ||
| 'G0 REJECTED dispatch must still prohibit release'); | ||
| assert.equal(inspect(fake).integration.every(x=>x.pass),false); |
There was a problem hiding this comment.
Make the negative fixture explicitly retain G0 rejection
When Main.cpp replaces the blanket G0 rejection with the real native intent dispatcher, this assertion will fail even though the integration is correct: fake.entry inherits the current Main.cpp without explicitly restoring a G0 rejection. Replacing the existing rejection with consoleBridge_.processNativeBusIntent(args, accepted) makes both the dispatcher check and every integration check pass for this fixture, contradicting its assertions. Because cli() unconditionally runs this test before inspecting sources, the intended engine integration will then fail both ordinary and release preflights in the Windows and UI workflows. Make the negative fixture explicitly inject the rejected dispatcher rather than depending on the production source remaining G0.
Useful? React with 👍 / 👎.
Milestone A / P0 #389 — actual integration protection, not another GUI or DSP
OWNER: integration/release gate only. ENGINE #266 retains exclusive callback/PCM/VST3 ownership; M2 #394 is already merged into main. No edits to GUI visual source,
src/Main.cpp,src/LiveAudioEngine.h, or realtime graph.Changes
scripts/check_console_puzzle.mjsthat still targeted rejectedweb/mixer-layout.js, old GUI GUI #271 — Native adaptation of approved PR #278 V8 Mixer Console (draft) #271 smoke and nonexistent FAT mock./preview/bundle used by JUCE ResourceProvider, plus genuine Subscribe/Intent/Snapshot/Ack and canonical native ID readback controller.tests/milestone_a_native_contract_test.mjs: rejects alternate GUI embedding, missing native ACK/snapshot, stale approved assembler and forged engine-only graph fixture.--releasenow checks source ownership before JUCE checkout; actual byte/asset CMake bundle check remains after CMake generation via existingcheck_approved_native_gui_release.mjs. No invalid requirement to verify nonexistent build artifacts in preflight.Status / acceptance
src/Main.cppapproved native bridge.web/console-native.*or introduce an alternative GUI.Coordination posted in #389 and #266 on 2026-11-05 WIB.