Skip to content

Milestone A integration gate: enforce ONLY /preview/ and genuine native ChannelId PCM admission - #398

Merged
masarray merged 5 commits into
mainfrom
integration/milestone-a-approved-console-source-gate-20261105
Nov 4, 2026
Merged

masarray merged 5 commits into
mainfrom
integration/milestone-a-approved-console-source-gate-20261105

Conversation

@masarray

@masarray masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Milestone A / P0 #389 — actual integration protection, not another GUI or DSP

OWNER: integration/release gate only. ENGINE #266 retains exclusive callback/PCM/VST3 ownership; M2 #394 is already merged into main. No edits to GUI visual source, src/Main.cpp, src/LiveAudioEngine.h, or realtime graph.

Changes

  • Replaces stale scripts/check_console_puzzle.mjs that still targeted rejected web/mixer-layout.js, old GUI GUI #271 — Native adaptation of approved PR #278 V8 Mixer Console (draft) #271 smoke and nonexistent FAT mock.
  • Validates the ONLY approved Pages /preview/ bundle used by JUCE ResourceProvider, plus genuine Subscribe/Intent/Snapshot/Ack and canonical native ID readback controller.
  • Fail-closed release preflight requires real v8 producer installed, non-G0 dispatch, native callback ChannelId evidence, C++ graph impulse tests and Windows packaging verifier. A passing source preflight is explicitly not UAT or physical audio certification.
  • Adds tests/milestone_a_native_contract_test.mjs: rejects alternate GUI embedding, missing native ACK/snapshot, stale approved assembler and forged engine-only graph fixture.
  • --release now checks source ownership before JUCE checkout; actual byte/asset CMake bundle check remains after CMake generation via existing check_approved_native_gui_release.mjs. No invalid requirement to verify nonexistent build artifacts in preflight.

Status / acceptance

Coordination posted in #389 and #266 on 2026-11-05 WIB.

masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

Milestone A integrator source gate — exact-head evidence

Current HEAD 688c8620142036717146bef34cdebbf323da0800 (PR #398), based on main c1a11afd.

node scripts/check_console_puzzle.mjs --release is expected to BLOCK current main G0; that is correct. Only real accepted ChannelId callback + native dispatch should unblock the source gate. Even then, Windows screenshot and actual hardware #15/#270 FAT must be proven separately.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T20:14:51.664810Z 688c862 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 688c862014

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +52 to +54
assert.equal(status(inspect(fake),'intent-dispatch-not-g0-rejection').pass,false,
'G0 REJECTED dispatch must still prohibit release');
assert.equal(inspect(fake).integration.every(x=>x.pass),false);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Make the negative fixture explicitly retain G0 rejection

When Main.cpp replaces the blanket G0 rejection with the real native intent dispatcher, this assertion will fail even though the integration is correct: fake.entry inherits the current Main.cpp without explicitly restoring a G0 rejection. Replacing the existing rejection with consoleBridge_.processNativeBusIntent(args, accepted) makes both the dispatcher check and every integration check pass for this fixture, contradicting its assertions. Because cli() unconditionally runs this test before inspecting sources, the intended engine integration will then fail both ordinary and release preflights in the Windows and UI workflows. Make the negative fixture explicitly inject the rejected dispatcher rather than depending on the production source remaining G0.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant