Repository navigation
Conversation
…n end. Brook used it to close a run's Streams at the eviction after an accepted completion. A run end now closes nothing on Redis, so Core keeps upstream behavior.
Covers a reschedule after a backoff timer, failed tasks on more than one history page, and two Local Activities of one activation.
This was referenced Oct 25, 2026
Owner
Author
|
Closed in favor of the review series. Its net change is C1, #211, cut fresh onto upstream |
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops the cache-off eviction reason from Core and adds tests for the Local Activity's
workflow_task.Brook, the Redis Streams stack, closed a run's Streams at the eviction after an accepted completion. It needed the reason
WORKFLOW_EXECUTION_ENDINGfor that eviction with the Workflow cache off. After the SDK review, a run end closes nothing on Redis, so Core can use the upstream reason again.What changed?
320e725frevertsb565c433. With the Workflow cache off, a completed run's eviction has the reasonCACHE_FULLagain, as upstream. The revert also removes the test of that reason.ActivityTask.Start.workflow_task, stays. TheCHANGELOG.mdentry now names all of its fields. These are the started event id, attempt and start time,previous_started_event_id, andfailed_tasks(the last 100 failed or timed out Workflow Tasks).core_tests/local_activity_workflow_task.rshas new mock-poller tests. A reschedule after a backoff timer gets the later task.failed_taskshas the failed tasks of every History page. The Local Activities of one activation get the same task.workflow_taskandWorkflowTaskAttemptsay that the values come from the poll response and the History. They also say that Core sets only the last 100 failed tasks.Why?
An independent review of Brook and Jetty found that the
CHANGELOG.mdentry left out two fields ofworkflow_task. The Streams crate uses these fields to withdraw the Records of Local Activities whose Workflow Task never completed. The code was correct, but backoffs and paged History had no test.How did you test it?
cargo test -p temporalio-sdk-core --libpasses, with the new tests.cargo fmt --all --checkand clippy ontemporalio-sdk-coreandtemporalio-protospass. On the fork CI, every job passes except the ubuntu-arm jobs andHeavy Tests, which need runners that the fork doesn't have.The crate s23 and the superproject branch
temporalio/internal-ai-prototypes2026/10/ai198-streamspinf7826366, the tested commit. The head commit after it changes only comments and docs, so the pins don't change.