Repository navigation
Conversation
A bridge can route one generic lang call to the extension by method name, so a plugin's native code needs no bridge function of its own.
moetemp
changed the title
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #209, and the upstream review uses one fresh PR instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
callandcall_asynctoWorkerExtension. Each takes a method name and encoded input, and returns encoded output or anExtensionErrorwith atonic::Code, a message and encoded details. Both default toUnimplemented. Core never calls them.Why?
Lang code must reach a plugin's native code in the same library as Core, and the bridge should not have a function for each plugin. With these methods a bridge exposes one generic
extension_call, and lang maps the code and details to its own errors.How did you test it?
Link to a test plan if any -
Unit tests for the default methods and for an extension that routes by method name and returns details.