Repository navigation
Conversation
…n end. Brook used it to close a run's Streams at the eviction after an accepted completion. A run end now closes nothing on Redis, so Core keeps upstream behavior.
…10-no-eviction-reason
Covers a reschedule after a backoff timer, failed tasks on more than one history page, and two Local Activities of one activation.
…10-no-eviction-reason
…10-no-eviction-reason
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges Brook #209 into the Jetty Core, so Jetty also drops the cache-off eviction reason and gets the new
workflow_tasktests.Jetty's sdk-rust is Brook's Core layers plus
Connection::raw_unary, which the native Stream backend uses to call the server's Stream service. On native, the server closes a Workflow's Streams at the Run Chain end, so no SDK close needs the eviction reason.What changed?
CACHE_FULLagain, as upstream. Field 20,ActivityTask.Start.workflow_task, stays, and itsCHANGELOG.mdentry names all of its fields. New mock-poller tests cover the task that a Local Activity gets after a backoff timer and over History pages.raw_unarydocs and theCHANGELOG.mdentry say that the call uses the connection's TLS, API key, headers, interceptors, metrics and retry policy. The test helper docs nameGetSystemInfo.Why?
An independent review of Brook and Jetty found the gap in the
CHANGELOG.mdentry, which #209 fixes. Jetty's Core is Brook's Core plus Jetty commits, so each Brook Core layer is merged into it.How did you test it?
cargo test -p temporalio-client --libandcargo test -p temporalio-sdk-core --libpass. A port race failedget_free_port_can_bind_immediatelyonce while other builds ran, and it passed on a rerun.cargo fmt --all --checkpasses, and clippy shows only two upstream warnings intemporalio-client. The crate at moetemp/sdk-streams#42 and sdk-python at moetemp/sdk-python#366 build on2de24aef, and their suites pass. On the fork CI, every job passes except the ubuntu-arm jobs andHeavy Tests, which need runners that the fork doesn't have.The crate at moetemp/sdk-streams#42 and the superproject branch
temporalio/internal-ai-prototypes2026/10/ai198-streamspin2de24aef, the tested commit. The merge and the commit after it change only comments and docs, so the pins don't change.