Repository navigation
Conversation
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #209, and the upstream review uses one fresh PR instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
previous_started_event_id = 4andfailed_tasks = 5toWorkflowTaskAttempt, the dispatching task that each local activity start names.previous_started_event_idcomes from the poll response of the dispatching task.failed_tasksholds the started event ids of the run'sWorkflowTaskFailedandWorkflowTaskTimedOutevents in history. Core keeps only the last 100 of them per run.Why?
A Stream write from a local activity sends these facts, so the Store can withdraw the Records of local activities whose workflow task never completed. A failed task before the last completed one is only known by its id, so the list is needed too.
How did you test it?
The core tests of the local activity task check both fields, including a timed out task. The
sdk-coreunit tests pass.🤖 Generated with Claude Code