Repository navigation
Conversation
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #209, and the upstream review uses one fresh PR instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR removes the Workflow Task hooks that no extension uses.
Removed:
WorkflowTaskInterceptorand its info types (WorkflowTaskCompletionInfo,WorkflowTaskEpoch,WorkflowTaskFailedInfo,WorkflowTaskInterceptError,RunCloseKind), andWorkerExtension::workflow_task_interceptor. Also gone are the calls around each completion and on a failed task and an eviction, the History facts they needed (the task index of the machines, the previous started id, the receipt time, the first run id), and their core tests.Kept:
WorkerExtensionwithcallandcall_async, andActivityTask.Start.workflow_task(field 20) with its stamp on each new Local Activity. sdk-python puts field 20 in a user Local Activity's Stream Producer epoch. The changelog drops the hook entries.Why?
Decision S108. Workflow writes are a Local Activity per call, so the Stream crate (sdk-streams s19) no longer buffers per run, and nothing calls the hooks. They came in on this Brook chain (c1 to c4), so they go out on it too.
How did you test it?
cargo fmt --all -- --check,cargo lint, andcargo test -p temporalio-sdk-core --lib.