Repository navigation
Conversation
Core only passed the extension through to lang. A bridge can build its own object per client connection, so Core needs no trait or config field for it.
With no workflow cache, Core asked for a cache-full eviction before it reported the completion, so lang never saw that the execution ended. A worker that acts after an accepted completion needs that reason. Co-authored-by: Dan Davison <dandavison7@gmail.com>
1 of 3 tasks
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #209, and the upstream review uses one fresh PR instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR removes the
WorkerExtensiontrait,WorkerConfig.extensionand the replay worker's drop of it (S123). Core keeps only field 20 on a Local Activity start.It also takes Dan's eviction fix (S121). With the workflow cache off, the eviction after a terminal completion that the server accepted has reason
WORKFLOW_EXECUTION_ENDING, as with a cache, notCACHE_FULL.Why?
Core only passed the extension through to lang. The bridge can build the crate object per client connection, as Dan's bridge does, so Core needs no trait or config field for it.
On Redis the close with the run goes after Core reports the accepted completion, through the eviction. With no cache Core reported
CACHE_FULL, so lang could not tell that the run ended.How did you test it?
The two zero-cache eviction tests are Dan's. The accepted case fails without the fix, with
CacheFull.cargo lint,cargo test-lint,cargo fmt --checkand the Local Activity task tests pass.